Add return attribute to CoreMatrixUtils public API #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Apr 27, 2020
6 tasks
sebastienlagarde
added a commit
that referenced
this pull request
May 23, 2020
* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394)
* First pass of light loop optimizations (still single threaded) (#6367)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Address review points
* Add comment
* changelog
* Shadow cascade tooltip fix (when using the metric mode) (#6448)
* fix tooltip and public API about shadow cascades
* minor modifications in the text
* Add default tooltips
* Add assert in case we support more cascades in the future
* Minor text edit
* Changlog
* Updated tooltip text
* update TAA screenshots
* Disable POM test and update ref images (#6445)
* Focus on Decal uses the extends of the projectors (#6449)
* Added Alpha To Mask for HDRP and ShaderGraph (#6297)
* Added AlphaToMask render state
* AlphaToMask
* AlphaToMask test
* Updated changelog
* Updated LayeredLit and AxF test
* Added reference images
* Fix depth and motion vector passes for Unlit
* AlphaToMask doc. Unified doc and fixed links for Alpha Clipping
* Updated reference screenshots
* Update CHANGELOG.md
* Fix motion vector settings for test scenes
* Block AlphaToMask state in deferred or not MSAA. Updated test screenshots
* Fix MRT blend state
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Move scene view camera settings to camera settings window (#6390)
* Move the HDRP scene view settings to the Editor camera settings widget
* Changelog + tooltips
* update upgrade guide
* fix spelling
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed how the area light influence volume is computed to match rasterization. (#6454)
* - Fixed how the area light influence volume is computed to match rasterization.
* Fix issue in the axis order
* Update DebugDisplay.cs (#6467)
* Fix shadow tesselation culling (#6477)
* Fix custom pass culling params
* Fixed shadow tessellation culling
* revert custom pass code
* Adding 5 automated test scenes (#6483)
* Sharing more code for light data building (RT) and building a more optimal atlas (#6370)
* - Sharing GetLightData code between rasterization and ray tracing to avoid duplication and lack of features
- Inject all lights at the same time (rasterization and ray tracing) into the cookie atlas to avoid waste of space.
- Added a test scene to make sure it works properly
* correcting debug mistake
* Forgot to add the screenshot and to enable the test in the editor build settings
* - Fixed usage of light size data that are not available at runtime. (#6489)
* Hdrp /lookdev ui fixes (#6491)
* Fix no environment text wraping
* Add missing toolbar tooltips
* Fix camera button-dropdown layout
* Fix uss loss at domain reload
* Update CHANGELOG.md
* Fix custom pass depth copy (#6484)
* Fixed the depth buffer copy made before custom pass after opaque and normal injection point
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6479)
* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on (#6473)
* Use different hash to prevent the perennial dirtying of baked probes.
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp /fix drag area width at left of light intensity (#6471)
* Fix drag area width at left of light's intensity
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp /fix reset of HDAdditionalLightData (#6453)
* fix type resolving issue when reseting HDAdditionalLightdata
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to disable XR rendering on the camera settings (#6372)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix unused leftover (#6497)
* Split HDRP Test scene 1900 in two scene (#6498)
* Fix custom pass test reference images (#6512)
* Updated ref image for PT fog test (5005). (#6513)
* Review corrections for previous PR (#6494)
* Fixed an usage of a a compute buffer not bound (1229964) (#6476)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520)
Fixing an issue with sub-surface scattering and updating screenshots
* fix typo (#6500)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor.
* Update changelog.
* Additional fix for regular inspector
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480)
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems.
* Update changelog
* Removed wrongly serialized fields in StaticLightingSky (#6441)
* Removed unnecessarily serialized members in StaticLightingSky component.
* Update changelog
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504)
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).
* Small fix to avoid overlapping
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix a compilation issue to to a backport that did not go well. (#9)
* Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31)
* Clamp probes compression factor to 0 (#19)
* Clamp to positive
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* path validation when creating new volume profile (#36)
* Validate whole path when creating new profile
* Changelog
Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com>
* Alpha to coverage frame setting (#33)
* Added FrameSettingsField.AlphaToMask
* Changelog + Documentation
* Changed field index
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile…
alelievr
pushed a commit
that referenced
this pull request
May 25, 2020
* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394)
* First pass of light loop optimizations (still single threaded) (#6367)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Address review points
* Add comment
* changelog
* Shadow cascade tooltip fix (when using the metric mode) (#6448)
* fix tooltip and public API about shadow cascades
* minor modifications in the text
* Add default tooltips
* Add assert in case we support more cascades in the future
* Minor text edit
* Changlog
* Updated tooltip text
* update TAA screenshots
* Disable POM test and update ref images (#6445)
* Focus on Decal uses the extends of the projectors (#6449)
* Added Alpha To Mask for HDRP and ShaderGraph (#6297)
* Added AlphaToMask render state
* AlphaToMask
* AlphaToMask test
* Updated changelog
* Updated LayeredLit and AxF test
* Added reference images
* Fix depth and motion vector passes for Unlit
* AlphaToMask doc. Unified doc and fixed links for Alpha Clipping
* Updated reference screenshots
* Update CHANGELOG.md
* Fix motion vector settings for test scenes
* Block AlphaToMask state in deferred or not MSAA. Updated test screenshots
* Fix MRT blend state
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Move scene view camera settings to camera settings window (#6390)
* Move the HDRP scene view settings to the Editor camera settings widget
* Changelog + tooltips
* update upgrade guide
* fix spelling
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed how the area light influence volume is computed to match rasterization. (#6454)
* - Fixed how the area light influence volume is computed to match rasterization.
* Fix issue in the axis order
* Update DebugDisplay.cs (#6467)
* Fix shadow tesselation culling (#6477)
* Fix custom pass culling params
* Fixed shadow tessellation culling
* revert custom pass code
* Adding 5 automated test scenes (#6483)
* Sharing more code for light data building (RT) and building a more optimal atlas (#6370)
* - Sharing GetLightData code between rasterization and ray tracing to avoid duplication and lack of features
- Inject all lights at the same time (rasterization and ray tracing) into the cookie atlas to avoid waste of space.
- Added a test scene to make sure it works properly
* correcting debug mistake
* Forgot to add the screenshot and to enable the test in the editor build settings
* - Fixed usage of light size data that are not available at runtime. (#6489)
* Hdrp /lookdev ui fixes (#6491)
* Fix no environment text wraping
* Add missing toolbar tooltips
* Fix camera button-dropdown layout
* Fix uss loss at domain reload
* Update CHANGELOG.md
* Fix custom pass depth copy (#6484)
* Fixed the depth buffer copy made before custom pass after opaque and normal injection point
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6479)
* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on (#6473)
* Use different hash to prevent the perennial dirtying of baked probes.
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp /fix drag area width at left of light intensity (#6471)
* Fix drag area width at left of light's intensity
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp /fix reset of HDAdditionalLightData (#6453)
* fix type resolving issue when reseting HDAdditionalLightdata
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to disable XR rendering on the camera settings (#6372)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix unused leftover (#6497)
* Split HDRP Test scene 1900 in two scene (#6498)
* Fix custom pass test reference images (#6512)
* Updated ref image for PT fog test (5005). (#6513)
* Review corrections for previous PR (#6494)
* Fixed an usage of a a compute buffer not bound (1229964) (#6476)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520)
Fixing an issue with sub-surface scattering and updating screenshots
* fix typo (#6500)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor.
* Update changelog.
* Additional fix for regular inspector
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480)
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems.
* Update changelog
* Removed wrongly serialized fields in StaticLightingSky (#6441)
* Removed unnecessarily serialized members in StaticLightingSky component.
* Update changelog
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504)
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).
* Small fix to avoid overlapping
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix a compilation issue to to a backport that did not go well. (#9)
* Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31)
* Clamp probes compression factor to 0 (#19)
* Clamp to positive
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* path validation when creating new volume profile (#36)
* Validate whole path when creating new profile
* Changelog
Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com>
* Alpha to coverage frame setting (#33)
* Added FrameSettingsField.AlphaToMask
* Changelog + Documentation
* Changed field index
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers …
sebastienlagarde
added a commit
that referenced
this pull request
May 27, 2020
* Added Alpha To Mask for HDRP and ShaderGraph (#6297)
* Added AlphaToMask render state
* AlphaToMask
* AlphaToMask test
* Updated changelog
* Updated LayeredLit and AxF test
* Added reference images
* Fix depth and motion vector passes for Unlit
* AlphaToMask doc. Unified doc and fixed links for Alpha Clipping
* Updated reference screenshots
* Update CHANGELOG.md
* Fix motion vector settings for test scenes
* Block AlphaToMask state in deferred or not MSAA. Updated test screenshots
* Fix MRT blend state
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Move scene view camera settings to camera settings window (#6390)
* Move the HDRP scene view settings to the Editor camera settings widget
* Changelog + tooltips
* update upgrade guide
* fix spelling
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed how the area light influence volume is computed to match rasterization. (#6454)
* - Fixed how the area light influence volume is computed to match rasterization.
* Fix issue in the axis order
* Update DebugDisplay.cs (#6467)
* Fix shadow tesselation culling (#6477)
* Fix custom pass culling params
* Fixed shadow tessellation culling
* revert custom pass code
* Adding 5 automated test scenes (#6483)
* Sharing more code for light data building (RT) and building a more optimal atlas (#6370)
* - Sharing GetLightData code between rasterization and ray tracing to avoid duplication and lack of features
- Inject all lights at the same time (rasterization and ray tracing) into the cookie atlas to avoid waste of space.
- Added a test scene to make sure it works properly
* correcting debug mistake
* Forgot to add the screenshot and to enable the test in the editor build settings
* - Fixed usage of light size data that are not available at runtime. (#6489)
* Hdrp /lookdev ui fixes (#6491)
* Fix no environment text wraping
* Add missing toolbar tooltips
* Fix camera button-dropdown layout
* Fix uss loss at domain reload
* Update CHANGELOG.md
* Fix custom pass depth copy (#6484)
* Fixed the depth buffer copy made before custom pass after opaque and normal injection point
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6479)
* Fix issue with baked reflection probes constantly marked as dirty with auto-bake on (#6473)
* Use different hash to prevent the perennial dirtying of baked probes.
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp /fix drag area width at left of light intensity (#6471)
* Fix drag area width at left of light's intensity
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp /fix reset of HDAdditionalLightData (#6453)
* fix type resolving issue when reseting HDAdditionalLightdata
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to disable XR rendering on the camera settings (#6372)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix unused leftover (#6497)
* Split HDRP Test scene 1900 in two scene (#6498)
* Fix custom pass test reference images (#6512)
* Updated ref image for PT fog test (5005). (#6513)
* Review corrections for previous PR (#6494)
* Fixed an usage of a a compute buffer not bound (1229964) (#6476)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520)
Fixing an issue with sub-surface scattering and updating screenshots
* fix typo (#6500)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor.
* Update changelog.
* Additional fix for regular inspector
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480)
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems.
* Update changelog
* Removed wrongly serialized fields in StaticLightingSky (#6441)
* Removed unnecessarily serialized members in StaticLightingSky component.
* Update changelog
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504)
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).
* Small fix to avoid overlapping
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix a compilation issue to to a backport that did not go well. (#9)
* Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31)
* Clamp probes compression factor to 0 (#19)
* Clamp to positive
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* path validation when creating new volume profile (#36)
* Validate whole path when creating new profile
* Changelog
Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com>
* Alpha to coverage frame setting (#33)
* Added FrameSettingsField.AlphaToMask
* Changelog + Documentation
* Changed field index
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 2, 2020
* Hdrp /fix reset of HDAdditionalLightData (#6453)
* fix type resolving issue when reseting HDAdditionalLightdata
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to disable XR rendering on the camera settings (#6372)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix unused leftover (#6497)
* Split HDRP Test scene 1900 in two scene (#6498)
* Fix custom pass test reference images (#6512)
* Updated ref image for PT fog test (5005). (#6513)
* Review corrections for previous PR (#6494)
* Fixed an usage of a a compute buffer not bound (1229964) (#6476)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520)
Fixing an issue with sub-surface scattering and updating screenshots
* fix typo (#6500)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor.
* Update changelog.
* Additional fix for regular inspector
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480)
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems.
* Update changelog
* Removed wrongly serialized fields in StaticLightingSky (#6441)
* Removed unnecessarily serialized members in StaticLightingSky component.
* Update changelog
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504)
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).
* Small fix to avoid overlapping
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix a compilation issue to to a backport that did not go well. (#9)
* Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31)
* Clamp probes compression factor to 0 (#19)
* Clamp to positive
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* path validation when creating new volume profile (#36)
* Validate whole path when creating new profile
* Changelog
Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com>
* Alpha to coverage frame setting (#33)
* Added FrameSettingsField.AlphaToMask
* Changelog + Documentation
* Changed field index
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly in the…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 2, 2020
* Hdrp /fix reset of HDAdditionalLightData (#6453)
* fix type resolving issue when reseting HDAdditionalLightdata
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to disable XR rendering on the camera settings (#6372)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix unused leftover (#6497)
* Split HDRP Test scene 1900 in two scene (#6498)
* Fix custom pass test reference images (#6512)
* Updated ref image for PT fog test (5005). (#6513)
* Review corrections for previous PR (#6494)
* Fixed an usage of a a compute buffer not bound (1229964) (#6476)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520)
Fixing an issue with sub-surface scattering and updating screenshots
* fix typo (#6500)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor.
* Update changelog.
* Additional fix for regular inspector
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480)
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems.
* Update changelog
* Removed wrongly serialized fields in StaticLightingSky (#6441)
* Removed unnecessarily serialized members in StaticLightingSky component.
* Update changelog
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504)
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).
* Small fix to avoid overlapping
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix a compilation issue to to a backport that did not go well. (#9)
* Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31)
* Clamp probes compression factor to 0 (#19)
* Clamp to positive
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* path validation when creating new volume profile (#36)
* Validate whole path when creating new profile
* Changelog
Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com>
* Alpha to coverage frame setting (#33)
* Added FrameSettingsField.AlphaToMask
* Changelog + Documentation
* Changed field index
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly in the…
10 tasks
sebastienlagarde
added a commit
that referenced
this pull request
Jun 2, 2020
* Hdrp /fix reset of HDAdditionalLightData (#6453)
* fix type resolving issue when reseting HDAdditionalLightdata
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to disable XR rendering on the camera settings (#6372)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix unused leftover (#6497)
* Split HDRP Test scene 1900 in two scene (#6498)
* Fix custom pass test reference images (#6512)
* Updated ref image for PT fog test (5005). (#6513)
* Review corrections for previous PR (#6494)
* Fixed an usage of a a compute buffer not bound (1229964) (#6476)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520)
Fixing an issue with sub-surface scattering and updating screenshots
* fix typo (#6500)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493)
* Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor.
* Update changelog.
* Additional fix for regular inspector
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480)
* Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems.
* Update changelog
* Removed wrongly serialized fields in StaticLightingSky (#6441)
* Removed unnecessarily serialized members in StaticLightingSky component.
* Update changelog
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504)
* Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045).
* Small fix to avoid overlapping
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix a compilation issue to to a backport that did not go well. (#9)
* Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31)
* Clamp probes compression factor to 0 (#19)
* Clamp to positive
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* path validation when creating new volume profile (#36)
* Validate whole path when creating new profile
* Changelog
Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com>
* Alpha to coverage frame setting (#33)
* Added FrameSettingsField.AlphaToMask
* Changelog + Documentation
* Changed field index
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 6, 2020
* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41)
* AxF: Add support for specular AA from geometric curvature.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights.
* AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe.
* AxF: Use get scalar roughness function to factor out code.
* AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model.
* Add changelog entries.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement constant buffers for HDRP global variables. (#52)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Fixed color/depth pyramid debug
* Cleanup
* Small fix
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Add Performance framework package and HDRP performance tests (#45)
* Added performance test project
* Added new test scene system and memory p[rofiling
* Added shader analysis package
* Create symlink folder in library directory
* Update editor window
* Update shader analysis selection
* Added CLI utility to execute shader analysis reports
* Added example for the cli
* Removed problematic HDRP graphic test packages
* Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903)
* Update memory profiling test sample count
* Update shader graph support
* Updated project settings
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Empty commit for Performance reports
* Use background job API and improved progress reporting
* Empty commit for Performance reports
* Updated ui
* Empty commit for Performance reports
* Empty commit for Performance reports
* Added filter on shader pass and variants
* Added option to only generate shader variants
* Empty commit for Performance reports
* Increase garlic heap size
* Begin to add build profiling
* Added more build info
* Working version of the shader compilation time reporting
* wip
* Removed useless cli
* Added util functions to name test and sample groups
* Renamed all markers and finished the build profiling
* Update test framework package
* Updated shader analysis tests
* Updated API
* Updated API and log command for compiler
* Updated api
* Use unknown metric instead of time one as workaround
* Enable the CPU profiling API
* Fix when deleting an analyzed shader
* Load reference on enable
* Added shader analysis package
* Fixed PS4 test name
* Fixed memory unit
* Added more test scenes
* Force performance tests to run on PS4 base
* Fixed sample units and use the same SampleGroup for multiple frames in counter test
* Begin to create the graphic perf test
* Finished the first version of performance graphic test package
* Fixed build tests
* Increase static analysis timeout
* More timeout
* Removed Lit shader static analysis
* Fix counters tests
* Added performance settings window in project settings
* Re-add Forward build test scene
* Fixed shader analysis filter
* PR fixes
* Begin to write the doc
* Finished V1 of the performance package doc
* Added grafana image and doc description
* Updated doc
* Maybe fix yamayo tests
* Update documentation for static analysis
* Added note on core asmdef
* Removed debug
* Fixed total memory
* Added tesselation counters test
* Tessellation shadow test
* Added per scene settings
* Added naming convention doc
* Fixed build issue on yamato
* Compilation fix to revert
* Begin to write the new doc page
* Completed performance doc
* Fixed build test
* Added Lit in static analysis
* Removed deferred static analysis
Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
* Hdrp/fix/custom pass msaa rendering info (#42)
* Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass AOV API (#50)
* Very basic AOV support for custom pass
* Updated AOV API for custom passes
* Changelog
* Update AOV API
* API improvements
* API documentation
* API doc, factorize all push texture calls in RenderCustomPass
* added default values and constructor for CustomPassAOVBuffers
* fix merge conflicts
* Fix GC alloc during rendering: use a for loop instead of findIndex+lambda
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window.
* Update changelog
* Fix Unlit.template in shadergraph (#637)
* Remove unused unlitpass.template
* Update Lit.hlsl
* re-add unlit pass
* Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609)
* - Fixed a bug where the light list is not cleared but still used when resizing the RT.
* add changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram view improvements (#589)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* print exposure values in debug view
* commit but it is nothing, need to switch branch
* Add option to center histogram around exposure (fixed tonemap curve)
* change color of text
* fixup debug display merge issue
* fixup merge issues
* fixup issue with tonemap curve
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 9702_CustomPass_API.png.meta
* Fix warning (#663)
* add shader macros for XR single-pass (#687)
* Adding 2 SG Pathtracer test scenes (#624)
* New unlit pt scene
* Add scene for PT Lit
* Removing collider from the meshes
* Renaming
* Adding screenshots for PT scenes
* Changing threshold for SSS deferred tests for stability
* updating screenshot after staging being merged
* Slightly increasing threshold for 5007 and 902 unlit scenes
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Render Graph Unit Tests (#607)
* Render Graph Unit test WIP
Fixed pruning of passes with no output.
* Render Graph tests WIP
* Increase max limit in UX of lights (#702)
* Raise the max for lights
* Update CHANGELOG.md
* Fix null reference in volume debug menu (#705)
* Update reference image for "502_RecursiveRenderingDisabled" (#704)
* Update screen…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 8, 2020
* Implement Constant Buffers for HDRP (part 2) (#87)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Minor adjustments to TAA anti flicker (#97)
* small adjust to taa antiflicker
* Changelog
* Add support for lighting decomposition debug mode (+ AOV) (#99)
* Add lighting decomposition debug mode
* fix compil issue with probe volumes
* Fix usage of debug exposure in debug mode
* Add Test 3001 + fix reflection when sky only
* remode _DebugExposure after merge
* remode _DebugExposure after merge
* fix merge issue
* add exposure compensation to Fixed exposure mode
* Update ColorUtils.cs
* Fix MSAA resolve when there is no motion vectors (#1)
* Fix MSAA resolve when there is no motion vectors
* Update CHANGELOG.md
* Cleaned up code
* use multi_compile
* Added _
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix switch shader compilation (#111)
* DXR Automated tests shader graph optimizations (#116)
* Split 902 scene into 5 scenes + SG optimizations
* Deleting old image for splited scene
* Fix various leaks in HDRP. (#113)
* Fixed a number of leak in HDRP
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile error with XR SubsystemManager (#107)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update SceneViewDrawMode.cs (#118)
* Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114)
* Follow references when unloading unneeded assets
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix culling of reflection probes that change position (#121)
* Fix culling of reflection probes that change position
* Avoid null reference
* Avoid null reference - try 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix null reference when processing light probe (#131)
* Hdrp/runtimetests/ps4 fix (#129)
* Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset.
* Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res.
* Fix issues causing planar probes to be broken with multiple cameras in the scene (#4)
* Set appropriate render datas before rendering cameras
* changelog
* update doc
* comment update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix black screen in XR when HDRP package is present but not used (#137)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18)
* Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader).
* update ssr screenshot
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window.
* Update changelog
* Fix Unlit.template in shadergraph (#637)
* Remove unused unlitpass.template
* Update Lit.hlsl
* re-add unlit pass
* Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609)
* - Fixed a bug where the light list is not cleared but still used when resizing the RT.
* add changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram view improvements (#589)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* print exposure values in debug view
* commit but it is nothing, need to switch branch
* Add option to center histogram around exposure (fixed tonemap curve)
* change color of text
* fixup debug display merge issue
* fixup merge issues
* fixup issue with tonemap curve
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 9702_CustomPass_API.png.meta
* Fix warning (#663)
* add shader macros for XR single-pass (#687)
* Adding 2 SG Pathtracer test scenes (#624)
* New unlit pt scene
* Add scene for PT Lit
* Removing collider from the meshes
* Renaming
* Adding screenshots for PT scenes
* Changing threshold for SSS deferred tests for stability
* updating screenshot after staging being merged
* Slightly increasing threshold for 5007 and 902 unlit scenes
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Render Graph Unit Tests (#607)
* Render Graph Unit test WIP
Fixed pruning of passes with no output.
* Render Graph tests WIP
* Increase max limit in UX of lights (#702)
* Raise the max for lights
* Update CHANGELOG.md
* Fix null reference in volume debug menu (#705)
* Update reference image for "502_RecursiveRenderingDisabled" (#704)
* Update screenshot for 502 recursive rendering disabled test scene
* upgrade shader material
* Fix transparent movec scene view (#698)
* Disable transparent movec when object motion vectors are disabled
* changelog
* Port (#599)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass API part 2 (#227)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Added the API to override camera rendering
* Updated changelog
* Updated changelog
* Fixed compilation issue
* Added custom pass API test scene
* Begin to add custom pass override test
* Factorized protection function
* Update custom pass test scene
* Fixed custom pass API doc
* Begin to add camera override tests
* Fixed camera override in scene view
* Finished RenderFrom API fucntions
* Fixed XR disable class
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations
* Finished to fix the RenderFrom* functions
* Moved obsolete execute function into the new one
* Update reference images
* Added all the API doc
* Updated changelog
* revert mats
* Updated custom clear pass to use the new API
* Fixed depth buffer random read/write error
* Disable custom pass blur test part
* Revert camera pixel rect changes
* Rename multi-pass to single pass
* Disable custom pass test on vulkan and XR
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix line that got lost in merge (#729)
* Porting console fixes to staging (#699)
* Path tracer: added support for transparency on the Unlit shader. (#717)
* Added support for transparency in Unlit.
* Updated Changelog.
* Update capture for 5007_PathTracing Unlit
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor related fixes (#730)
* Fixes for the compositor test
* Enable the compoositor test in build settings
* Avoid gc alloc, hide internal components from vomume menu
* Vulkan and DX12 screens, adjust compositor UI refresh
* Fixed a vulkan and metal warning in the SSGI compute shader. (#715)
* - Fixed a vulkan and metal warning in the SSGI compute shader.
* - Fixed an exception due to the color pyramid not allocated when SSGI is enabled.
- Fixed an issue with the first depth history mip was incorrectly copied.
* Fix path traced DoF focusing issue (#732)
* Remove mip padding from PlanarReflectionProbeCache.cs
* Disable 9702 test nor working + 9041 XR (instable)
* Hdrp/pt pass no bsdf data (#710)
* Removed direct use of BSDFData in path tracing pass.
* Updated changelog.
* Fixed float3 typo...
* fix metal 9800 reference screnshots
* update meta file and testcasefilter
* Pre warm RT Handle system so that reallocations are reduced. (#713)
* Pre warm rt handle system and initialize to screen width/height
* changelog
* not all was pushed
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Various fixes for Graphics tests with Render Graph (#725)
* WIP for enabling valid graphics tests with Render Graph.
Fixed a lot of gcalloc.
* Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled.
* First batch of disabled tests.
* Fixed decal rendering
* Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral)
* Revert "First batch of disabled tests."
This reverts commit 505924b6967041787c0698b4ede1d158686f990e.
* Temp "texture not bound" error fix until bloom is implemented.
* Fixed an error when using a stale invalid renderer list handle.
Reduced error message spam when encountering an execution error.
* Add some debug info to compiled passes and removed wrong refCount++ on passes.
* Added possibility to disallow pass pruning
Fixed a number of pass pruning issues.
* Small fixes
* temporarily removed pruning of passes without product
* Fixed HDRP asset for test 5009
* Implement alpha copy for post processes
* Small render graph error fix for motion vector pass.
* Disabled for render graph tests that are currently broken.
* Updated yamato with new render graph configurations
* Fixed lens distortion
* Reenabled 4021
* Revert "Reenabled 4021"
This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64.
* Revert "Updated yamato with new render graph configurations"
This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9.
* Revert "Disabled for render graph tests that are currently broken."
This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026.
* Reverted HDRP test framework files (will go to another PR)
* Revert "Fixed HDRP asset for test 5009"
This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Various fix and improvements for ray traced effects (#597)
* Adding a minimal lit used for RTGI in peformance mode
Dispatch binned rays in 1D instead of 2D
Fix an issue with the half resolution Mode for RTGI
Only read the geometric attributes that are required using the share pass info and shader graph defines
Fix an issue with the color intensity of emissive for performance rtgi
* Correct bug with shadow history rejection
* reduce the exponential accumulation value a bit
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Procedural metering mask that follows target (#723)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* start of procedural mask
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* Some basic version of procedural working
* need to switch branch
* Exposure target and threshold.
* fix merge mess
* Fixes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* - Added presets quality settings for RTAO and RTGI. (#724)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compilation issue in HDRaytracingIndirectDiffuse
* fix shader warning in exposure
* Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648)
* - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR).
* Simplifying the culling override.
* Update 708_ShadowExtendedCulling.png
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Removed reference image for player (unused) in HDRP Test
* Update preview naming (#753)
* Cloud layer volume override (#461)
* Added uv distorsion for …
sebastienlagarde
added a commit
that referenced
this pull request
Jun 8, 2020
* Add isHidden flag for Blocks
* Add Universal SpriteColor block for upgrades (happy-json)
* Add isHidden flag for Blocks
* UpdateActiveBlocks on block deletion
* Fix requirements from Blocks
* Update HDRenderPipelineAsset.asset (#210)
* Improve block requirement handling
* Fix preview target
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix fragment normal block descriptors
* Fix Sprite normals
* Fix Sprite normals
* Fixup after merge
* Handle SaveContext call on HDRP when no asset assigned
* Update data to new serialization
* Fix issue after merge
* Update change log
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fix issue when creating new graphs
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* fix some issues with creating new shadergraphs
* fix uncaught merge issue
* Bump com.unity.testframework.graphics version
* Upgrade path for Unlit and PBR
* Bump test dependencies
* fix UTP reporter version
* Upgrade path for HDUnlit
* Fix block map for multiple target upgrades
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* next utp reporter version
* Upgrade path for HDLit
* Upgrade path for Decal
* Upgrade path for Eye
* Copy more default values in MaterialSlot
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Upgrade path for Fabric
* Upgrade path for Hair
* Upgrade path for StackLit
* Fix for missing SlotMask bits on HDLit
* Add missing Vertex blocks for Decal
* Fix Block requirements for custom descs (mainline)
* Fix HairStrandDirection field (master)
* Fix shader property upgrade issue
* Implement Undo core and URP targets
* Implement Undo HDRP targets
* Fixup after merge
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Cretae per-pipeline menu items
* Fix HairStrandDirection field
* Fix color property upgrade
* Remove old master node and target classes
* Revert old Pragma.OnlyRenderers change
* Add display names to blocks
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Validate HD naming conventions
* Define StackLit lobe A conceptually the same as Lit lobe
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove unnecessary descriptor null checks
* Move SpriteMask block to URP namespace
* Add paths for block descriptors via attribute
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Auto add/remove blocks when changing target settings
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Fix up after merge
* Fix drawing master from upstream node changes
* Fix up PreviewManager after merge
* Fix up after merge
* Fix target initiailization
* Support upgrading blockmaps from multiple targets
* merge of cross pipeline mvp into stack master v2 upgrade hdrp
* fixing bugs
* remove old function
* fixing some test code
* Shadergraph/bugfix 1186867 (#65)
* Adding in check for error in graph to allow warnings to not break graphs and subgraphs
* Adding changelog
* retry to push changelog
* readd of update to changelog
* Adding graphics test for warnings and errors
* Edited CHANGELOG.md
* removing graphics test for shadergraph since it relies on a graph outputting an error and was more to teach me how to add a graphics test in the first place
* update code
Co-authored-by: Elizabeth LeGros <elizabeth.legros>
Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
* more bugfix, one on creation of minimalgraphdata and updating some testcode calls which used guid instead of objectid
* Minor fixes
* working on node updates and unknown node types
* replace unkown node with known node
* Add contextual menu for Context separators
* Rename PassDescriptor block masks
* Fix SG test project
* Bump importers
* Add upgrade path for VFX
* Fix VFX tests
* handling unknown json types
* Changes to get branch to compile
* Moved target and subtarget settings to Internal Inspector
* Remove temporary inspector
* Fix HDLit clip threshold
* Re-enable HD shader stripping for SG shaders
* Fix HD SG vertex modification
* Various HDRP test fixes
* Remove excess changes
* fixing various upgrade bugs
* maybe fixed validity/activity???
* [skip ci] fixing window handling issues with preview and BB, code cleanup
[skip ci]
* [Skip CI] Fix upgrade of AlphaClip / AlphaTest
* [Skip CI] Fix condition for HDRP transparent cull mode GUI
* [Skip CI] Fix shadeBaseUsingRefractedAngles GUI
* [Skip CI] Fix StackLit debug GUI conditional
* [Skip CI] Revert some unecessary changes
* [Skip CI] Fix sub window layout serialization
* [Skip CI] Fix compiling of downstream BlockNode
* [Skip CI] Pass connected nodes to GetFields (Fix HD test 1202)
* [Skip CI] Hotfix for previews
* [Skip CI] Fix Unlit zWrite upgrade for HDRP (Fix HD test 8104)
* [skip ci] Inspector: Fixed bug 1244134 and property visible in inspector after deletion
* Fixed bug 1244134 with precision settings on nodes
* Fixed 8105_b test material data
* [Skip CI] Add unit tests
* Fix 8104 materials
* Upgraded HDRP Test material version
* [Skip CI] Revert HDRP DXR test 902 reference
* [Skip CI] Fix HD DXR tests 101, 102, 103 and 900
* [Skip CI] Fix HD test 8103 - Wrong condition for depth post pass
* Updated HDRP Runtime Tests materials
* Updated DXR test materials
* Updated perf and template materials
* Updated HDRP Hybrid materials
* created active state to deal with weird isactive states
* removing some logic from grapheditorview that really belongs at graph level and grabbing fix for searcher
* Added behavior to hide inspector when nothing is selected
* code cleanup and test case fixing
* removed IHasSettings and moved subgraph/custom node settings to inspector
* Adding more types to HDRP target allowed nodes and fixing serialization helper bug
* fixing some vfx serialization issues and adding another node to the HDTarget
* Started to re-organize the HDRP subtargets
* Sg/stack master v2 upgrade hdrp fix preview (#398)
* WIP : converted to tracking most things by preview instead of node
* Fix for softlock when a non-compiling node exists on a graph
* WIP : Fixed issues with Master Preview transform
Optimized property collection and timed node treatment
* Subgraph Previews working
Master node preview redraws when resized
Better early out of render code
* Moved preview mode computation to unified UpdateTopology()
Cleaned up code
* making diffusion profile material slot mark dependency on the asset and changing minimalgraphdata to acess serialized slots on legacy graphs to take this into account
* Fix for Default Block Node slots not affecting initial preview renders
* Fix for previews not rendering.
Also a bit of code cleanup
* fixes for node property drawers, selection with undo/redo and inspector and reordering targets
* Fix for Virtual Texture usage
* Fixing issues with PBR passes referencing old sigular Normal rather than NormalWS/TS/OS
* fix function signature
* removed reference to old IHasSettings interface
* Fix for Duplicate Node and Copy/Paste exceptions that soft lock the graph
* Fix for redirect nodes
* fixing issue where orphaned edges would try and update active trees on deleted nodes
* Properly handle ShaderGraph failure when subgraph doesn't exist.
* Fix for issues after deleting a subgraph used by a graph.
Also cleaned up error messages generated by the asset importer dependencies in the case that the subgraphs never existed in the project.
* Disallow dragging block nodes into groups
* Continue to clean HDRP subtargets
* fixing bug where changing active targets after load would not update node activity/validity
* fixing bug where material slots did not properly update on add/remove of edges
* Fixing 3 small issues in PreviewManager:
VT Textures were not set in URP preview
Occasional error spew from mismatched preview pass count
Incorrect profiling marker name
* make target property gui context a visual element
* fixing a PBR upgrade issue that would not set correct surface settings when upgrading a transparent master node
* Merge HDRP/staging into shader stack branch (#580)
* [9.x.x] Merge Hdrp/staging [Skip CI] (#366)
* Fixed an issue where AO override would not override specular occlusion. (#6222)
* Fixed an issue where AO override would not override specular occlusion.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6252)
* Fixed an issue where Volume inspector might not refresh correctly in some cases.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* render XR mirror view only for camera with no RT (#6306)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Split set rendering feature set and API validity check (#6301)
* Split set rendering feature set and API validity check
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/probe scale 1219246 (#6288)
* Fix when scale down < 0 all direction of box Influence Volume
* Update Change log
* Hdrp/fix/particle light shadows (#6111)
* Tried to fix particle light shadows
* Fixed particle shadows
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Recording of accumulation motion blur and path tracing (#6114)
* Pt and accumulation motion blur recording
Fix merge issues
Fix merge issues #2
Bugfix: accumulation with one sample
Chengelog
Don't set the fixed-time in the subframe manager - should be set in the recorder
Properly set and reset the fixed time
Updated documentation
Small fix to make physics simulation work with scaled time / accumulation mb
Post rebase fixes and disable accumulation when using only one sub-frame
* Fix post merge issues
* hdrp resources asset file
* remove duplicate code
* Move most compute shaders to use multi_compile API (#6307)
* Squashed commit of the following:
commit ed9e485efc69a7949e34f0512666d522470dc73e
Author: FrancescoC-Unity <francescoc@unity3d.com>
Date: Fri Mar 20 11:47:59 2020 +0100
Revert "Squashed commit of the following:"
This reverts commit 0dd46577be82abeaefc839cbcd9f3875b05d48e6.
commit 0dd46577be82abeaefc839cbcd9f3875b05d48e6
Author: FrancescoC-Unity <francescoc@unity3d.com>
Date: Fri Mar 20 10:39:28 2020 +0100
Squashed commit of the following:
commit 0e1815814ce8204cfa42ae3050ba655fe769c550
Merge: ac6809ec032 2b018dfe8a9
Author: Sebastien Lagarde <sebastien@unity3d.com>
Date: Thu Mar 19 18:19:45 2020 +0100
Merge branch 'master' into HDRP/staging
commit 2b018dfe8a9f5f304e4b95d6279dda60f632c9dc
Author: sebastienlagarde <sebastien@unity3d.com>
Date: Thu Mar 19 18:19:02 2020 +0100
Merge Hdrp/staging (#6293)
* Custom pass cleanup (#5507)
* Fix custom pass cleanup issue with multiple volumes
* Updated changelog
* Delay discard of fragments during decal projection (#5283)
* Delay discard of fragments during decal projection
Metal Shading Language declares that fragment discard invalidates
derivatives for the rest of the quad, so we need to reorder when
we discard during decal projection, or we get artifacts along the
edges of the projection (any partial quads get bad partial derivatives
regardless of whether they are computed implicitly or explicitly).
* Better re-arrangement of decal code
* Update TerrainLitPasses.hlsl
* Update TerrainLitPasses.hlsl
* Update TerrainLitPasses.hlsl
* Update ShaderPassDecal.hlsl
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixing unnecessary memory allocations in the ray tracing cluster build and Updating the screen shots for the ray tracing tests (#5465)
* Fixing unnecessary memory allocations in the ray tracing cluster build
Updating the screen shots for the ray tracing tests
* Update test scene and screenshots
* - Discarding the ray tracing history for AO, reflection, diffuse shadows and GI when the viewport size changes.
- Update and disable some tests that still need to be updated
* Add a counter for ray tracing frame index and update screenshots
* Fixing the Area Shadows Denoiser Test
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Change the default volume used by the ray tracing tests to make them work again (#5510)
* Change the default volume used for the ray tracing tests, fixes the tests back.
* Fix access to the ray tracing frame index in ray tracing ambient occlusion (doesn't change behavior)
* Missing term in the ray tracing frame index access (#5511)
* Fix colum headers (#5517)
* Fix colum headers
* Update CHANGELOG.md
* Rename post formats (#5505)
* Renamed the post processing format to the new convention
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed the first frame flash with auto exposure (#5491)
* Fixed flashes with low and high exposure scenes when Automatic Exposure is in use
* Moved postfx history reset to per-camera reset
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update DefaultSettingsVolumeProfile.asset
* Hdrp/small enhencements for DXR (#5493)
* Add Warning for DXR and AsyncExecution in FrameSettings
* move restarting at end of all fix in wizard for DXR
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/update default scenes (#5485)
* Replace default scenes with scene prepared for scene-template
* Update of DefaultSettingsProfile
* Update DXR scene
* Add ScreenSpaceShadow to Camera's default FrameSettings
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactoring pre-existing materials to share code between rasterization and ray tracing (#5441)
* Refactoring pre-existing materials to share code between rasterization and ray tracing
Update the test scene
* update changelog
* Changing the color of an unlit in the reflection test scene
* review corrections
* Fixing unlit shader graph
* Fix specular AA related issue
* Update the reflection test
* Fix an issue with debug display for ray tracing shaders
Always use ray tracing frame index 0 for ray tracing tests
Update tests screenshots
Update ray traced reflection test scene
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/staging thin (#5509)
* Adding a REFRACTION_THIN model.
* Fixed thin distance.
* ... and fixed it.
* Updated changelog, removed unused REFRACTION attrs from Fabric template.
* Added a REFRACTION_THIN_DISTANCE macro.
* Finished support for thin refraction.
* Fixed LitTesselation (was missing thin refraction model).
* fix issue when merging Refactoring of DoAlphaTest
* Fixed an issue where passing a null ProfilingSampler would cause a null ref exception. (#5555)
* Fixing the area shadow denoised test (#5544)
* Fix leak in Sky when matcap view (#5556)
* skip pre render sky in matcap view
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compilation issues of ApplyExposure on platforms that don't support VR (#5575)
* Fix
* changelog
* Remove Preview from physically based sky
* HDRP asset migration (#5580)
* Initialize the HDRP asset version to the latest one so new assets are not migrated
* Updated changelog
* Hdrp/remove wind resources (#5578)
* Remove wind resources
Remove wind resources no longer used and containing big files
* Update changelog
* revert: Hdrp/update default scenes (#5485)
* Fix issue with missing texture in test
* Disable POM test in 1708 SG_OnSG as it is unstable
* Add missing texture in runtime test
* update caption for geometric normal debug in forward
* add missing texture to runtime test
* Create Textures.meta
* fix SG on decal SG
* Fixed an issue where ambient occlusion and screen space reflections editors would generate null ref exceptions when HDRP was not set as the current pipeline. (#5577)
* Fixed a null reference exception in the probe UI when no HDRP asset is present. (#5582)
* Fixed a null reference exception in the probe UI when no HDRP asset is present.
* Indentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix custom pass outline (#5590)
* Fixed custom pass outline resolution screen resolution dependent
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null reference exception in the HDRI Sky editor when no HDRP asset is present. (#5596)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix decal orientation when created from script. (#5592)
* Fixed all migration classes to default to latest version so that Decals created by script to get migrated.
Fixed decal created through context menu so that they get the proper rotation convention.
* Update changelog
* Moved the GetEnumLastValue to TypeInfo class
* Updated super old test scenes to the proper latest version for decals
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor of HDCamera (accesibility mostly) [Skip CI] (#5548)
* Refactor of HDCamera
- Made internal/private APIs that should not have been public
- Fixed naming convention for private members
- Moved everything by accessibility for clarity (public, internal, then private)
* Added Doc and returned some API public.
* Fix visibility of Density Volumes in reflections [Skip CI] (#5589)
* Oblique projection frustum fix, first try
* HDCamera frustum now recalculates near and far plane to avoid issues with oblique projection matrices.
* Update changelog
* Added comments
* Indentation
* Fixed camera relative position of frustum
* Indentation
* Fixed a null reference exception in Path Tracing, Recursive Rendering and raytraced Global Illumination editors when no HDRP asset is present. (#5597)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix ray tracing tests and add a test scene for lights and cookies in ray tracing (#5604)
* expose StartSinglePass() and StopSinglePass() as public interface for XRPass (#5605)
* Add missing custom pass API documentation (#5530)
* Add missing custom pass API documentation
* Fix doc spells and grammar
* Stencil Refactor and Material migration fixes (#5581)
* Remove leftover code
* commit to switch machine
* Remove hard coded stencil values in shaders
* clear stencil
* tmp commit, start of splitting decal in dbuffer and normal patchup
* Make decal patching up run after GBuffer
* Remove hardcoded value for SSS split lighting
* Tmp commit to switch branch
* Finalize build coarse stencil (with debug leftover and render graph NOT handled)
* The AA bits (the easy one :-) )
* split in two enums
* Distortion vectors bit sorted
* SSR bit
* Motion vector bit
* decals bit
* Lighting bits
* Use HTile for SSR
* HTile SSS -> Incomplete, verify and test.
* SSS fixes, but still not working (probably not HTile related, but main stencil)
* Make decal patch normal work and remove stencil bit
* some leftover fixes
* was commited by mistake
* Update materials
* Revert "Update materials"
This reverts commit 4a0de82ef51750b77546020d77ad6b5d773e60af.
* Fix issues with MSAA and with migration
* Forgot this out
* update materials and maps
* default materials
* don't have SSR on unlit
* Fix some leftovers
* Renaming
* Revert "update materials and maps"
This reverts commit 103f1cb71d8fffa49b0c2ef57f1b41b36d0a3dbf.
* Revert "default materials"
This reverts commit 978740acd825562717a01437dcc0c74fc4cfefb0.
* Fix migration
* white line
* Fix migration
* Add render queue overide to the material placer.
Also add PackageInfo.cs to HDRP, so the graphic tests can call it's internal methods and objects.
* Default material post migration
* com.unity.testing.hdrp post reimport
* Updated materials from test
* Disable tests that are to be updated or not needed anymore
* Fix VFX issues (To be fixed better by @PaulDemeulenaere )
* Lit hardcoded default was off
* Update VFX Test materials ( @PaulDemeulenaere for awareness )
* Fix issue with stencil in TAA
* Revert lighting data
* revert light map data
* Revert other lighting asset
* Cleanup post processor.
* Update DXR test material
* Update commnets
* Early (need testing) new migration workflow
* Revert "Early (need testing) new migration workflow"
This reverts commit 2db025002d66165dd00e90f5f5d3c944ed53f361.
* Update post processor
* Add manual option to migrate
* Add dialog box
Co-authored-by: RemyUnity <32760367+RemyUnity@users.noreply.github.com>
* Push updated hdrp version in test project (#5617)
* Push m_LastMaterialVersion update
* Dont open dialog on yamato
* Update test projects with recent stencil refector PR (#5618)
* Update runtime test project
* Create HDRPProjectSettings.asset
* update DXR project
* Revert "update caption for geometric normal debug in forward"
This reverts commit 150d68279b891529be272b37f374c36b879646f4.
* Run reimport during update (to avoid unwanted extra dialog during dialog box) (#5620)
* Make user stencil bits public (#5616)
* Expose bits to user
* Update documentation
* Update HDStencilUsage.cs
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement history rejection based on object velocity (#5532)
* Implement history rejection based on object velocity
* Update changelog
* Fix an issue with ambient occlusion denoising being broken after adding the history rejection feature
Adding the GPU Light type for history validation and rejection
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed initial state of material created through the context menu. (#5603)
* Fixed an issue where materials newly created from the contextual menu would have an invalid state, causing various problems until it was edited.
* Forgot DecalUI (for non shader graph decals)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update HDLightUI.Skin.cs
* Cookie and planar atlas (#5518)
* Added support for cookie atlas
* Begin to move planar reflection into atlas
* Added texture atlas for planar reflection probe plus a limit to on screen planar probes
* Removed debug log
* Fixed planar probe atlas scale issue and useless mipmap generation of the atlas
* Refactor Texture2D atlas
* Move ScaleBias for planar probes to a separate list
* Fix cookie mode for directional lights
* Added error log for non square cookie textures in the atlas
* Fix merge
* Fixed cookie atlas
* Trying to fix area light cookies
* Fixed area light cookie
* Disable mipmap for non area light cookies
* Added cookie atlas format control + fixed size warnings in HDRP cookie ui
* Add resolution in Capture Settings reflection probe drawer
* Removed warnings
* Added the point light cookie texture array in the debug menu
* Fix cookies in ray tracing + celestial body texture
* Update dynamic light cookie screenshot
* Update Animated cookie test + fix reflection probe texture format
* Fix area light cookie
* Update HDRP asset cookie and planar atlas sizes
* Increase cookie atlas size for area light test
* Simplify code
* Fix cookie mip clamp
* Fixed compilation and CG alloc
* Added atlas layouting when there is no more space
* Fix directional light cookie
* Updated reference image of cookie area lights
* Fix hardcoded format and cookie layout
* Remove useless mip update
* Fix area light cookie x flip
* Added the debug exposure option for debug planar reflection atlas
* reverted the fix for area light cookie x flip
* Tried to simplify the code of the atlas
* Update reference image
* Added an error when max planar reflection probe on screen is reached
* Fixed space parenthesis
* Fixed mipmap not updated properly and area light cookie convolution temp texture format
* Fixed atlas reset mips
* Update tooltip and fixed cookie insertion order when there is no more space in the atlas
* Enable exposure on cookie atlas debug
* Fix debug overlap
* Update reference image
* Added migration code for the cookie atlas size and fixed point light cookie debug exposure
* Added planar atlas size upgrade code
* Updated planar reflection atlas message
* Fixed resolution dependent cookie mip maps
* Updated changelog
* Fixed cookies for ray tracing
* Fix cookie in the ray tracing light loop requested without being reserved
* Clamp UV when doing the area light convolution
* Update reference images
* Remove debug symbols
* Fixed area light convolution UV limit
* Fixed half pixel clamp and updated reference images
* Fixed planar reflection mip map edge bleeding and update reference images
* Updated more image reference
* Updated DXR cookie test scene
* Fix default material transparent created with ZWrite enabled (#5621)
* Fixed transparent material craeted with ZWrite enabled
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/fix decal gizmo mouseover (#5626)
* Remove controlID on projection direction of DecalProjector that conflict with other handles
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/smallfixes lookdev (#5619)
* Fix zoom being stuck around 0
* fix crash forbiding view manipulation while using directly hdri without passing by an environment
* Fix hitch in FPS displacement mode
* Fix when user destroy the EnvironmentLibrary being used.
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Mask was never set for some debug pixel deferred shaders [Skip CI] (#5627)
* Mask was never set
* changelog
* Added comments
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed an issue where creating decals at runtime could cause a null reference exception. (#5594)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Make APIs internal when they should be - 1 - [Skip CI] (#5531)
* First pass of making APIs internal when they should be.
* Indentation
* Compilation fixes + review feedback.
* Make APIs internal when they should be - 2 - [Skip CI] (#5533)
* First pass of making APIs internal when they should be.
* Indentation
* WIP
* Missing file
* More
* Revert some changes based on review feedback
* Compilation fix
* Compilation fixes + review feedback.
* Updated HDUtils accessibility
* More editor internals.
* Better (not hardcoded) stencil handling in VFX (#5624)
* Stencil update for vfx
* Fix issues
* fix missing templates
* Avoid displaying material upgrader dialog on new project (#5631)
* Don't run dialog on new project creation
* skip only on first creation
* Check file existence before showing dialog
* typo
* Push test materials after ZWrite PR (#5632)
* Update HDRP_Test project
* Update DXR test assets
* Update run time tests
* Discard invalid pixels when doing deferred lighting in compute (for camera stacking) (#5339)
* Discard invalid pixels when doing deferred lighting in compute (as required for camera stacking)
Small comment modification
Update changelog
* Use stencil buffer (instead of normals) to discard pixels in deferred compute
* Remove not required if statement when binding the stencil
* Small fixes to API visibility. (#5637)
* Fixed some more public APIs to internal.
* Made hasCustomRender public again.
* Moved the tier defining from the asset to the concerned volume components. (#5519)
* Alpha post-processing bugfixes and improvements (#5512)
* Bug fix for post processing alpha with chrommatic aberation + minor fixes
* Avoid double blending in DOF
* Unit tests for alpha post-processing (TAA/DoF)
Vulkan test images
Vulkan meta files
* Fix runtime tests (#5639)
* Update runtime test screenshots
* Update planar resolution
* Add test (#5641)
* fix material and project settings for VFX (#5642)
* Revert change to GBuffer (normalbuffer usage) as it broke the raytracing code
* Fix various issues with time and animated materials (#5480)
* Fix various issues with time and animated materials
* Changelog
* Add getters
* Only update time once per frame
* Fix animation in reflection
* Fix null ref exception
* Re-applied code after impossible merge.
* Comment change
* Remove commented code.
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix graphic test (#5651)
* renaming test 1901 -> 1451 and 1709 -> 1710
* Update EditorBuildSettings.asset
* Update 1710_Decals_Normal_Patch.png
* update screenshots
* update scene backgroud
* Update manifest.json
* Update decal patch screenshots
* update 4052_TAA
* Changing the tier system for a preset mode system and removing unnecessary options (#5646)
* Changing from a tier management to a "mode" management for reflection and GI and removing the ability to enable/disable deferred and ray bining (they are now implied by performance mode)
* Update the scene scenes
* Update changelog
* Fixing an instability with the light shadows in ray tracing
* Update to light explorer (#5615)
- Fixed SkyType display when no Visual Environment is present
- Changed fog display to reflect the updated fog system
- Changed Global to "Mode" as it is in Volume UI now.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 1710_Decals_Normal_Patch.png
* disable TAA test for XR
* Hdrp/add documentation tool (#5655)
* Add the documentation tool to HDRP test project
* Fixed window serialization
* Update the documentation for the diffusion profile (#5654)
* Update the documentation for the diffusion profile
* Update Diffusion-Profile.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add missing hdlight api (useVolumetrics) (#5652)
* Add missing API to the HDAdditionalLightData
* Updated changelog
* Global Settings API doc. (#5649)
* Fog Volume Component API doc. (#5645)
* Debug Display API doc. (#5643)
* Color picker API doc.
* FullScreen Debug API doc.
* Decal debug API doc
* False Color debug API doc
* Lighting Debug API doc
* Material Debug API doc.
* DebugDisplaySettings API doc.
* Restored contact shadow fade debug.
* API documentation for sky related classes. (#5640)
* API documentation for sky related classes.
* Document the PBR sky
* Hdrp/small wizard fixes for dxr (#5633)
* Add ScreenSpaceShadow to Camera's default FrameSettings
* Forbid to atmpt creating default scene if the hdrpAsset is not right (we depend on its resources)
* Update CHANGELOG.md
* Add OS and Hardware check in wizard for DXR
* Update CHANGELOG.md
* Fixe typos
* Add missing check on Shadows
* Update Documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Documentation (#5613)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix custom pass disable stencil (#5545)
* Disable the strencil in custom passes when overwriting the depth and not writing into it
* Updated changelog
* Rephrase doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add option to exclude camera motion contribution from motion blur (#5656)
* Remove camera component from motion blur if desired
* changelog
* Documentation update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Semi-transparent Shadows for Point and Spot lights (#5490)
* Make the shadow behavior for transparent and transmissive objects more intuitive.
* Update changelog
* Implementing semi transparent ray traced shadows for point and spot light
Adding a test scene for both cases
Moving contact shadow ray tracing code to a seperate file
Changing the direction of contact shadow rays to be coherent with the other shadows
* update changelog
* Update the test scenes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fix shader warning in termporal AA
* Support semi-transparent shadows for unlit shader and unlit shader graph (#5663)
* Not doing ray tracing when the stencil bit is off for ssr (#5665)
adding a test case for it
* Restored serialization of deprecated parameters to fix migration. (#5666)
* Shadow Atlas is no longer allocated for area lights when they are disabled in the shader config file. (#5662)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Updated HDRP documentation (#5664)
* Updated HDRP asset doc
* Update the upgrade guide for cookies and planars
* Added warning in the material sorting priority doc for depth write
* Added a section about surface option properties for ShaderGraphs
* Fix link name
* Alpha output documentation (#5658)
* Update documentation for HDRI-Sky-Backplate (AO) (#5670)
* Avoid MRT Clear on PS4 [Skip CI] (#5675)
* Avoid MRT Clear on PS4
* changelog
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Change name of option (#5681)
* More code share between inspector materials (#5635)
* Share stencil code for inspector materials (Akin to what happens in shadergraph)
* changelog
* Add comment and fix issue
* Better handling of setting state (if not available, don't write it)
* Update BaseLitGUI.cs
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Expose alpha cutoff material for ShaderGraphs (#5667)
* Expose alpha clip to material UI for ShaderGraphs
* Updated changelog
* Replace #if by #ifdef
* Fix debug menu bitfield (#5683)
* Fixed runtime debug menu bitfield controls
* Updated changelog
* Hdrp/update default scenes (#5634)
* Replace default scenes with scene prepared for scene-template
* Update of DefaultSettingsProfile
* Update DXR scene
* fix missing profile in default scene dxr
* Update CHANGELOG.md
* Fix missing HDRI Sky references in DXR new scene
* Fixed VFX Tests Default volume profile
* Changed Default Volume settings to an empty one.
* Missing volume asset files + update manifest and meta
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* - Fixed the radius value used for ray traced directional light. (#5682)
- Fixed compilation issues with the layered lit in ray tracing shaders.
- Changed the way the length parameter is used for ray traced contact shadows.
- Added contact shadow test scenes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* fixed XR autotests viewport size rounding (#5684)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Material samples bis (#5686)
* Add ball
* update Material samples #5638
* Update CHANGELOG.md
* Remove unused version property from Material
* Updating the documentation for ray tracing (#5680)
* Updating the documentation for ray tracing
* review corrections
* Fix mip slider reflectionprobe (#5689)
* Remove the slider knob when the reflection probe preview has no mipmap
* Updated changelog
* edit VR documentation (#5685)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Better directional PCSS blur handling (#5688)
* Use correct penumbra calculation for directional.
* Update visual test
* Need cleaning uo
* Cleaning
* screenshot update
* Small cleanup
* typo leftover
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 001-HDTemplate.png
* Adding the initial implementation of sub-surface scattering (#5625)
* Initial implementation of ray traced sub surface scattering
Added a test scene for ray traced sub surface scaterring
* Update changelog
* Updating the tests
* Update 8103_PrePostPass.unity
* Remove unnecessary skip of material upgrade dialog box. (#5692)
* Remove unnecessary skip of material upgrade dialog box.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix warning after metal fixup (#5704)
* Various API doc update. (#5705)
* Various doc + FrameSettings WIP
* Finished frame settings API doc and added various other missing doc.
Also made internal wrongly public API in HDRP
* Fix density volume blend distance (#5698)
* Fixed adjusting positive axis of Blend Distance slides the negative axis
* Updated changelog
* edit VR doc (#5699)
* Hdrp/wizard update vr installation (#5706)
* Add installatation checker in UsedPackageRetriever
* Add PackageInstaller
* Add better control on the displayed HelpBox
* Update VR fixes
* fix typo
* Move Install Config Package Button above with HDRP Package info
* Update CHANGELOG.md
* Update documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Removing unused alpha threshold depth prepass and post pass for fabric shader graph (#5711)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix default volume profiles location (#5710)
* Ray traced reflection smoothness fade and fallback fixes. (#5700)
* Fix fall back for ray traced reflections when denoising is enabled
Make Smoothness Fade start work with ray traced reflections
Fix the blend of reflections based on the weight
Add the contact shadow test scenes back
* Change the name of the weight function and add it to all shading models
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix iridescence color space (#5691)
* Fix iridescence color space
* Fixed compilation and updated test screenshots
* fix test
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Fix Terrain Detail Mesh (stop to spam) [Require C++ PR] (#5690)
* disable support of Terrain Detail
Fix for error spam issue in HDRP: https://fogbugz.unity3d.com/f/cases/1211848/
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* [Waiting for C++] Disable probes in renderers (#5648)
* Disable probes section in the Renderer editors
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Merge Hdrp/fix/case 1210058 to master (#5612)
* Fix for 1210058 - NaNs at certain view angles
Issue is caused by NaNs/INFs when computing basis on extremely thin (subpixel-width) geometry. Putting some safeguards fixes the issue
* Update CHANGELOG.md to reflect 1210058 fix.
* Updated fix for issue #1210058
Overwrite the UVs to fix the derivatives.
* Updated fix for issue #1210058
Make sure the UVs are zero if unused to fix the derivatives.
* Undo last.change -- UV fix addresses NaNs
Zeroing the unused UV1 channel on the material seems to do the trick.
* Changelog adjustments to be moved
Current version puts everything in HDRP, so there is no change in core.
* Update CHANGELOG.md
Reflect fix for NaNs
* Fixed UV1 for lightmaps and detail maps.
* update comment
* Update NormalSurfaceGradient.hlsl
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Minor code cleanup
* Added script documentation for SSR, SSAO (ray tracing), GI, Light Cluter, RayTracingSettings, Ray Counters, ray traced SSS andRecursive Rendering. (#5732)
* Added script documentation for SSR, SSAO (ray tracing), GI, Light Cluster, RayTracingSettings, Ray Counters, ray traced SSS andRecursive Rendering.
* udpate changelog
* Implementation of ScreenSpaceReflections for Transparent materials (#4968)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix HDRP duplicated frame settings (#5850)
* - Added a fallback for ray traced area light shadows in case the material is forward or the lit mode is forward. (#5749)
- Fixed a bug related to ray traced area light shadow history.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie index usage (#5871)
* Hdrp/merge staging (#5943)
* fix case 1205791 custom mesh issue (#5551)
* fic case 1205791 custom mesh issue
* Updated changelog
* Added a call to Dirty() (#5420)
* Added a call to Dirty()
* Updated changelog
Co-authored-by: Marc Templin <marctem@users.noreply.github.com>
* Fix shadergraph analytics. (#5912)
* Fix analytics.
* Added changelog
* Fix for case 1200161 Save as subgraph issue (#5503)
* Fix for case 1200161
* Edited CHANGELOG.md
* Added comment to the code
Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
Co-authored-by: Marc Templin <marctem@users.noreply.github.com>
* fix for unreported keyword bug (#5863)
* Fixed fogbugz case 1197958 (#5671)
* * Fixed fogbugz case 1197958.
* * Updated CHANGELOG.md.
* * Added spacing.
* Added #if ENABLE_VR && ENABLE_VR_MODULE guard to XR code.
* Added Logic to Inject render pass to base renderer (#5901)
* Moved render pass injection code from Forward Renderer to ScriptableRenderer to be able to use for all renderers.
* added changelog
* Disabling the GetDefaultRenderer() test for now until it is redone. (#5924)
* [Yamato] [skip ci] Setting up master to run on 2020.1 (#5936)
* added 2020.1 and fast to editors
* added 2020.1/staging and fast to the rest of the files
* [CI] Bors setup (#5841)
* Create bors.toml
* Update bors.toml
* Update bors.toml
* Update upm-ci-projects.yml
* Create testcommit
* Update bors.toml
* adding trying trigger
* add staging trigger
* Delete testcommit
* use squash merge
* updating job that bors will run
* [skip ci] update job that bors will run
* Fixed MAD and RCP definitions in OpenGL. (#5922)
Co-authored-by: Martin Thorzen <35328557+martint-unity@users.noreply.github.com>
Co-authored-by: Marc Templin <marctem@users.noreply.github.com>
Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
Co-authored-by: Zachary Diller <zackd44@gmail.com>
Co-authored-by: thomas-zeng <49886741+thomas-zeng@users.noreply.github.com>
Co-authored-by: Felipe Lira <felipedrl@gmail.com>
Co-authored-by: Elvar Örn Unnþórsson <ellioman@ellioman.com>
Co-authored-by: Liis Kivistik <kivistik.liis@gmail.com>
Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com>
* Fix whitespace
* Misc fixes for the sky (#5974)
* Static lighting sky now takes the default volume into account.
* Fixed a leak in the PBR sky renderer.
* Added a tooltip to the Ambient Mode parameter in the Visual Environment volume component.
* Update changelog
* Fixed null ref
* Fixed an issue where having ambient mode set to dynamic might prevent the sky from being included in baking.
* Forces an update of static sky when changing it in the Environment panel.
* Fixed a problem with static sky when multiple skies are rendered at the same time.
* Revert probes renderer PR (#5990)
* Re-enable the probes section of renderers as it was not supposed to be disabled
* Updated changelog
* Fix a leak in the sky system. (#5967)
* Fixed a cubemap leak when rendering previews for the first time.
Also changed the debug name of the cubemap used for static lighting.
* Update changelog.
* Fixed an assert getting fired for the wrong reason.
* Added a new light layer debug mode (#5942)
* Moved lighting debug settings in containers
* Light layers debug mode
* Categories for Lighting Debug Panel Documentation
* Light layers debug mode documentation
* DebugUI.BitField now uses correct display names
* Added unit test scene
* Added changelog
* Revert "Added changelog"
This reverts commit a148fc2f97ef5288123f8f16485ba35f57b80f5e.
* Updated CHANGELOG
* Disable light layer debug mode after testing
* reset all debug display settings
* Renamed Shadow Layers option
* Editable layer color. Defaults to color blind friendly colors
* Fix when enabling an exclusive setting
* Updated screenshots with new colors
* Simplified variable API
* Renamed class
* Fix division by 0. Updated doc
Co-authored-by: Adrien <adrien.detocqueville@gmail.com>
* Hdrp/ssr toggle (#5996)
* Added an "enable" checkbox to the SSR volume component.
* Update changelog
* Fix build when not in editor (#6024)
* Fixed SSR in scene 1710 (#6028)
* Fix merge error
* Removed MSAA Buffers allocation when lit shader mode is set to "deferred only" (#6012)
* Removed MSAA Buffers allocation when lit shader mode is set to "deferred only".
* Removed MSAA SSS Buffer allocation when deferred only.
* Invalid cast for realtime reflection probes (case 1220504) (#6026)
* Invalid cast for realtime reflection probes (case 1220504)
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Aov Buffers tests (#6023)
* Deactivate Preview Camera for HDCameraEditor to prevent it from rende… (#6022)
* Deactivate Preview Camera for HDCameraEditor to prevent it from rendering in the render loop (case 1105163)
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable reflection probes section (#5994)
* Disable reflection probes in the renderer components
* Updated changelog
* Remove version guard for terrainDetailUnsupported
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Integrate first skeleton of post process in render graph. (#5856)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Fix DXR Tests (#6073)
* Made ssr enable parameter true by default. (#6076)
* Add comment (#6056)
* Hdrp /tests/shuriken light module (#6021)
* Add shurikent light module test
* Fixed Simulate
* Fix texts and image ratio
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/pt7 (#5831)
* Added support for anisotropy.
* Tidied the code up, plus moved to correlated G term for aniso GGX.
* Added anisotropic refractive sampling.
* Disable path tracing for the shading graph preview camera.
* Added support for alpha culling.
* Fixed issue with transmission rays.
* Updated Changelog.
* Added support for punctual and directional light cookies.
* Updated Changelog.
* Added support for area light cookies.
* Fixed bug with area cookies atlas not being properly generated when
rebuilding library.
* Made sure maxDepth > minDepth always, and added support for AO from mask.
* Added support for transparent shadows.
* Updated Changelog.
* Toggling path tracing on/off does not reset iteration anymore.
* Reverted change on enable, was causing minor issues.
* Made sure we don't have transparent behaviour when shader is set to
opaque.
* Minor changes.
* Tweaks on transparency behaviour.
* Updated changelog.
* Added path-tracing specific payload.
* Added support for iridescence.
* Updated Changelog.
* Added multiple scattering compensation for specular.
* Added Path tracing test.
* PT test part 2.
* Updated Changelog.
* Added proper area light range attenuation.
* Fixed issue with alpha clipping in ray-tracing.
* Cosmetic.
* Fix on the rect area light range.
* In the editor, dragging manipulators around now resets accumulation.
* Added material dirtiness tracking.
* Does not apply intensity clamping to camera rays.
* Reste PT iteration when saving a shader graph.
* Added dirtiness tracking for acceleration structure and lights.
* Added support for bg color.
* Minor change to progress bar display.
* Minor change to iteration counter, so that it never goes over the max.
* Updated path tracing test.
* Hdrp/rendergraph cleanup (#6083)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* post merge fix
* Removed useless comment.
* Missing doc
* Hdrp /fix light prefab infinite reload on inspector gui (#6054)
* fix infinite reload loop for light prefab
* Update CHANGELOG.md
* Fixed an issue where fog sky color mode could sample NaNs in the sky cubemap (#6027)
* Fixed an issue where fog sky color mode could sample NaNs in the sky cubemap.
* Update changelog.
# Conflicts:
# com.unity.render-pipelines.high-definition/CHANGELOG.md
* Fixed sampling of the sky texture in a more general way (not just fog)
updated tests screenshots as well.
* Missing screenshot
* Fixed the issue properly by generating 7 mips of convolution.
* Reverted screenshots
* Reverted useless change.
* Fix culling group was not disposed error in the build (#5880)
* Fix culling group was not disposed error in build
* Fix culling was not disposed error in build
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Material Samples : Revert correct GUIDs (#5875)
* Revert correct GUID
Change the GUID of the prefab to the correct one referenced in the scene
* Fix fern material GUID
* Hdrp/light multiplier (#6077)
* Allow the light dimmer to get values higher than one
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update documentation typo (#5860)
* Add warning and workaround instructions if XR single-pass is enabled after the first frame with XR SDK (#5853)
* added warning and workaround instructions if XR single-pass is enabled after the first frame with XR SDK
* edit VR doc
* Updated CHANGELOG.md
* Updated VR-Overview.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
* Remove info box on Visual Environment and replaced it with info on documentation (#6099)
* Remove info box and update documentation
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 9801_ShurikenLightModule.png
* Add missing exposure and mipmap sliders to the planar reflection probe preview (#5847)
* Added planar reflection probe preview mip and exposure sliders
* Updated changelog
* Disable mip map as we don't have them anymore
* Re-edited changelog
* Use SRP macros in shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix upgrade cookie planar size (#6104)
* Fixed the size of the planar reflection / cookie atlas after an upgrade of the HDRP asset
* Updated changelog
* Fixing merge issue for SSR transparent
* Fix universal and yamato after merge.
* fixuniversal after merge
* renormalize files
* Update 9801_ShurikenLightModule.unity
* Make isEditorCameraPreview and sky public (#6147)
* Update HDAdditionalCameraData.cs
* Update SkySettings.cs
* Update 9801_ShurikenLightModule.unity
* Update HDAdditionalCameraData.cs
* Update 9801_ShurikenLightModule.unity
* Fixing ray tracing tests (#6158)
* Fixed transparent SSR for shader graph. (#6163)
* - Fixed transparent SSR for shader graph.
* changelog
* Added old graphics tests and modifications (#6143)
* Update scenes
* update blendstates
* added OSX reference images
* win reference images
* fix lit light difference
* Update blendstates-c-lit-unlit
* disable check memory alloc due to ref probe issues
* update ref images
* rename test 1709 to 1711
* rename test 1709 to 1711 - bis
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with blend mode and with keyword (#6164)
* Fixed an issue with emissive light meshes not being in the RAS (#6174)
* Hdrp/pt8 (#6090)
* Added support for anisotropy.
* Tidied the code up, plus moved to correlated G term for aniso GGX.
* Added anisotropic refractive sampling.
* Disable path tracing for the shading graph preview camera.
* Added support for alpha culling.
* Fixed issue with transmission rays.
* Updated Changelog.
* Added support for punctual and directional light cookies.
* Updated Changelog.
* Added support for area light cookies.
* Fixed bug with area cookies atlas not being properly generated when
rebuilding library.
* Made sure maxDepth > minDepth always, and added support for AO from mask.
* Added support for transparent shadows.
* Updated Changelog.
* Toggling path tracing on/off does not reset iteration anymore.
* Reverted change on enable, was causing minor issues.
* Made sure we don't have transparent behaviour when shader is set to
opaque.
* Minor changes.
* Tweaks on transparency behaviour.
* Updated changelog.
* Added path-tracing specific payload.
* Added support for iridescence.
* Updated Changelog.
* Added multiple scattering compensation for specular.
* Added Path tracing test.
* PT test part 2.
* Updated Changelog.
* Added proper area light range attenuation.
* Fixed issue with alpha clipping in ray-tracing.
* Cosmetic.
* Fix on the rect area light range.
* In the editor, dragging manipulators around now resets accumulation.
* Added material dirtiness tracking.
* Does not apply intensity clamping to camera rays.
* Reste PT iteration when saving a shader graph.
* Added dirtiness tracking for acceleration structure and lights.
* Added support for bg color.
* Minor change to progress bar display.
* Minor change to iteration counter, so th…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 9, 2020
* Added support for rasterized area light shadows in StackLit + slight refactor (#39)
* Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled.
* Doc: remove note about area light shadows for stacklit. [skipci]
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110)
* Fix for white flash happening when changing lighting condition (like teleport) (#140)
* fix
* Update PostProcessSystem.cs
* Update CHANGELOG.md
* Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection
* Update CHANGELOG.md
* adress PR feedback
* Fix default volume profile collapse (#138)
* Only re-create the volume profile editor when the asset is changed
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Bind missing buffer (#159)
Bind buffer to make sure that something is bound
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162)
* Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163)
* fix warning
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window.
* Update changelog
* Fix Unlit.template in shadergraph (#637)
* Remove unused unlitpass.template
* Update Lit.hlsl
* re-add unlit pass
* Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609)
* - Fixed a bug where the light list is not cleared but still used when resizing the RT.
* add changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram view improvements (#589)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* print exposure values in debug view
* commit but it is nothing, need to switch branch
* Add option to center histogram around exposure (fixed tonemap curve)
* change color of text
* fixup debug display merge issue
* fixup merge issues
* fixup issue with tonemap curve
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 9702_CustomPass_API.png.meta
* Fix warning (#663)
* add shader macros for XR single-pass (#687)
* Adding 2 SG Pathtracer test scenes (#624)
* New unlit pt scene
* Add scene for PT Lit
* Removing collider from the meshes
* Renaming
* Adding screenshots for PT scenes
* Changing threshold for SSS deferred tests for stability
* updating screenshot after staging being merged
* Slightly increasing threshold for 5007 and 902 unlit scenes
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Render Graph Unit Tests (#607)
* Render Graph Unit test WIP
Fixed pruning of passes with no output.
* Render Graph tests WIP
* Increase max limit in UX of lights (#702)
* Raise the max for lights
* Update CHANGELOG.md
* Fix null reference in volume debug menu (#705)
* Update reference image for "502_RecursiveRenderingDisabled" (#704)
* Update screenshot for 502 recursive rendering disabled test scene
* upgrade shader material
* Fix transparent movec scene view (#698)
* Disable transparent movec when object motion vectors are disabled
* changelog
* Port (#599)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass API part 2 (#227)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Added the API to override camera rendering
* Updated changelog
* Updated changelog
* Fixed compilation issue
* Added custom pass API test scene
* Begin to add custom pass override test
* Factorized protection function
* Update custom pass test scene
* Fixed custom pass API doc
* Begin to add camera override tests
* Fixed camera override in scene view
* Finished RenderFrom API fucntions
* Fixed XR disable class
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations
* Finished to fix the RenderFrom* functions
* Moved obsolete execute function into the new one
* Update reference images
* Added all the API doc
* Updated changelog
* revert mats
* Updated custom clear pass to use the new API
* Fixed depth buffer random read/write error
* Disable custom pass blur test part
* Revert camera pixel rect changes
* Rename multi-pass to single pass
* Disable custom pass test on vulkan and XR
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix line that got lost in merge (#729)
* Porting console fixes to staging (#699)
* Path tracer: added support for transparency on the Unlit shader. (#717)
* Added support for transparency in Unlit.
* Updated Changelog.
* Update capture for 5007_PathTracing Unlit
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor related fixes (#730)
* Fixes for the compositor test
* Enable the compoositor test in build settings
* Avoid gc alloc, hide internal components from vomume menu
* Vulkan and DX12 screens, adjust compositor UI refresh
* Fixed a vulkan and metal warning in the SSGI compute shader. (#715)
* - Fixed a vulkan and metal warning in the SSGI compute shader.
* - Fixed an exception due to the color pyramid not allocated when SSGI is enabled.
- Fixed an issue with the first depth history mip was incorrectly copied.
* Fix path traced DoF focusing issue (#732)
* Remove mip padding from PlanarReflectionProbeCache.cs
* Disable 9702 test nor working + 9041 XR (instable)
* Hdrp/pt pass no bsdf data (#710)
* Removed direct use of BSDFData in path tracing pass.
* Updated changelog.
* Fixed float3 typo...
* fix metal 9800 reference screnshots
* update meta file and testcasefilter
* Pre warm RT Handle system so that reallocations are reduced. (#713)
* Pre warm rt handle system and initialize to screen width/height
* changelog
* not all was pushed
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Various fixes for Graphics tests with Render Graph (#725)
* WIP for enabling valid graphics tests with Render Graph.
Fixed a lot of gcalloc.
* Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled.
* First batch of disabled tests.
* Fixed decal rendering
* Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral)
* Revert "First batch of disabled tests."
This reverts commit 505924b6967041787c0698b4ede1d158686f990e.
* Temp "texture not bound" error fix until bloom is implemented.
* Fixed an error when using a stale invalid renderer list handle.
Reduced error message spam when encountering an execution error.
* Add some debug info to compiled passes and removed wrong refCount++ on passes.
* Added possibility to disallow pass pruning
Fixed a number of pass pruning issues.
* Small fixes
* temporarily removed pruning of passes without product
* Fixed HDRP asset for test 5009
* Implement alpha copy for post processes
* Small render graph error fix for motion vector pass.
* Disabled for render graph tests that are currently broken.
* Updated yamato with new render graph configurations
* Fixed lens distortion
* Reenabled 4021
* Revert "Reenabled 4021"
This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64.
* Revert "Updated yamato with new render graph configurations"
This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9.
* Revert "Disabled for render graph tests that are currently broken."
This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026.
* Reverted HDRP test framework files (will go to another PR)
* Revert "Fixed HDRP asset for test 5009"
This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Various fix and improvements for ray traced effects (#597)
* Adding a minimal lit used for RTGI in peformance mode
Dispatch binned rays in 1D instead of 2D
Fix an issue with the half resolution Mode for RTGI
Only read the geometric attributes that are required using the share pass info and shader graph defines
Fix an issue with the color intensity of emissive for performance rtgi
* Correct bug with shadow history rejection
* reduce the exponential accumulation value a bit
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Procedural metering mask that follows target (#723)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* start of procedural mask
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* Some basic version of procedural working
* need to switch branch
* Exposure target and threshold.
* fix merge mess
* Fixes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* - Added presets quality settings for RTAO and RTGI. (#724)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compilation issue in HDRaytracingIndirectDiffuse
* fix shader warning in exposure
* Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648)
* - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR).
* Simplifying the culling override.
* Update 708_ShadowExtendedCulling.png
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Removed reference image for player (unused) in HDRP Test
* Update preview naming (#753)
* Cloud layer volume override (#461)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* CloudLayer HDRI
* CloudLayer Gradient
* CloudLayer Physically Based
* Documentation
* Add clouds to Static Lighting Sky
* Fix spherical conversion
* Fix procedural flow
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* sync with hdri flow
* Renamed variables
* Allow full sphere coverage for procedural flowmap
* Added missing doc
* Fix cloud reset and unrelated warnings in hdri sky shader
* Try different blending method
* Fixes + test another blending
* Tint and intensity parameters. Fix static sky used by lightmapper
* Added graphic test. Updated doc
* Updated tests using a disabled static sky
If a sky override is used for static lighting and is disabled in the volume, it is not used anymore
* Update LocalAmbientOcclusionNoisy.asset
* update linux screenshots
* Update CloudLayer.cs
* update OSX screenshots
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Introduce LightLoop output structure (#754)
* Add concept of LightLoop Output
* update upgrade guide
* Update Upgrading-from-2020.1-to-2020.2.md
* update upgrade guide
* Fix lightloop-output (#755)
* Fix rendering when XrMaxViews is different than 2 (#733)
* Use a fixed size for xr related fields in cbuffers
* changelog
* Update local shader config
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Improve transition between LOD for lit and layeredLit tessellation (#517)
* Forest scale for tessellation change
* Forest scale for tessellation change
* Update Upgrading-from-2019.3-to-2020.1.md
* Update Upgrading-from-2019.3-to-2020.1.md
* fix ray tracing with XR single-pass (#769)
* Revert "fix ray tracing with XR single-pass (#769)"
This reverts commit 3e366334444febf450568b47ada2c00e4164ba12.
* reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766)
* Probe Volumes: Update SampleBakedGI() API (#759)
* Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time.
* Add some comment
Co-authored-by: pastasfuture <pastasfuture@gmail.com>
* Initial implementation for the new planar reflection filtering (#337)
* Initial implementation for the new planar reflection filtering
* Small improvement and "proper" support of oblique projection
* quality improvement to the filtering.
* Update PlanarReflectionFiltering.compute
* review corrections
* Update planar filter for all material (was not replaced) + update screenshots
* Update IBLFilterGGX.cs
* fix shader warning on vulkan
* update references screenshots
* Fixes for the plane normal and number of mips to be computed
* Fix shift that was to the right in the blurred version
* update references screenshots
* fix shader warning
* Some cleanup
* change to fast Atan
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fast memory support (#772)
* temp, gonna revert this, but have to merge staging.
* again, need to switch branch, nothing functional
* ESRAM support
* changelog
* Add guards
* Standard terrain upgrader (#762)
* Add render graph specific pipeline to HDRP tests. (#728)
* Added an option to ignore tests when render graph is enabled.
* Disabled for render graph tests that are currently broken.
* Reenabled 4021
* Updated yamato script to add the RenderGraph pipeline.
* Fixed HDRP asset for test 5009
* Revert unrelated yml files changes due to old configuration (#714)
* Fixed an issue with not unregistering render graph debug.
Disabled test 9401 for render graph after merge conflict.
* Disabled 9800 for render graph
* Revert hdrp asset for 5009
Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com>
* Added CPU and GPU timings for ray tracing effects. (#774)
* Added CPU and GPU timings for ray tracing effects.
* Only displaying the counters if ray tracing is supported on the asset.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Workaround for GetKernelThreadGroupSizes returning wrong data (#760)
* Hard code group size
* changelog
* Add comment
* Fixed the distanced based denoising being exposed for area lights (1251558). (#782)
* Fix test project
* Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791)
* Fix issue accessing already released targets for rendergraph
* changelog
* Sanitize transparent motion vectors setting (#761)
* Sanitize transparent motion vectors setting
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Revert "Add render graph specific pipeline to HDRP tests. (#728)"
This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e.
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: victor-unity <50244023+victor-unity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Sean Puller <43151199+SeanPuller@users.nore…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 10, 2020
* Texture-weighted automatic exposure (#165)
* Exposure weighted by texture
* miss one in the renaming
* Doc update
* changelog
* doc update
* fix issue when disabling override
* Update 3003_LightingMode.unity
* Optimizing light loop part 2 (#2)
* Saving 10% off the PrepareLightForGPU
* 18% decrease in cost with this
* Around 12% cost shaving off GetLightData
* Around 6.5% win here
* Faster View matrix flip
* Missing *=-1
* About 7% win in preprocess light data
* Another small batch
* Small cleanup for first optimization pass
* Tiny bit more cleanup
* Make UpdateShadowRequests 12% cheaper
* Address review points
* A bit less than 20% win in ExtractPointLightData
* Add comment
* changelog
* 25% reduction of ExtractPointLightData
* 18% win in UpdateShadowRequest
* Another around 11% win for UpdateShadowRequest
* Move matrix multiply utils to core
* less lighttype computation
* Ooops
* fixup changelog
* Proper merge
* Missing leftovers .
* I'll manage to submit it all one day...
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added support for POM for emissive map (#51)
* Add option to use Base UV Mapping for emission
* Graphic test and doc
* Changelog
* Screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor Tool (#57)
* HDRP compositor tool, first code drop
documentation typo, move everything in compositor namespace
documentation typo
bugfix: dynamically add/remove properties when shadergraph changes
UI bugfix: properly compute height of UI elements
Missing tooltips, button to remove the compositor
toggle layers now works when player is paused
add chroma keying in the compositor test
Changelog, workflow bugfix
Use Unity's built'in icons
AOV bugfixes
AOV tooltip was wrong
bugfix: disabling the compositor now disables all compositor cameras
Proper monitoring of shadergraph changes
Updated test image + minor changes
Use better names for internal cameras
Bugfix: selecting the same res for a layer
Bugfix: deleting in-use texture layers from shadergraph now works
Bugfix: setting AOV to none now works properly
Use the term SubLayer in the UI
Improve AOV tooltip
Camera properties in layers are properly refreshed
UI: Move checkbox for overrides on the left side of the label
Remove default compositor camera when also deleting the compositor
Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again
Hdrp/docs/compositor (#6013)
* Added docs review
* Changed fodler for images
Bugfixe: deleting layers
Bugfix: reordering layers
Bugfix: creating a new compositor fails
Remove redundant check
Fix wrong tooltip
Bugfix when deleting camera stack layers
Bugfix: handle window resize
Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers
Bugfix: more robust re-ordering (also moves children)
Bugfix: mark scene dirty when adding a compositor
Bugfix: display warning when alpha is configured properly
Change video layer icon
Bugfix: adding a layer filter does not reset the UI state
Bugfix: do not show composition properties that are marked with hide-in-inspector
Better / more clean layer injection implementation
minor code clean up
Clear color mode should only be editable on the first layer of a stack
Bugfix: setup of custom render was not always called
Bugfix: make sure additional camera data always exist in the layer/compositor camera
Change test id to 9800
Fix typos
mark scene dirty when removing or disabling the compositor
Default composition shadergraph and profile are now cloned
Serialized objects are now properly updated
minor code change: range checks
bugfix: error message appears at beginning
remove layer list from the asset file
add default camera layer when creating the compositor
replace getter function with c-sharp property
update asset in unit test
* move compositor unit test images
* remove leftover code
* review feedback #1
* review feedback 2
* review feedback - custom clear shader
* fix variable names that don't affect serialization
* fix serialized variable names
* bugfix: image layers and camera stacking
* use enum utility functions
* Use multicompile in motion blur + bug fix
* Make some variables private
* Update Compositor-User-Guide.md
* Review feedback
* fix muticompile for motion blur without alpha
* Update to new constant buffer / shadergraph api
* Player test image for the compositor
* Properly fill camera entries for global constant buffer
* Fix after rebase / function rename
* Make bg red for better debugging qnd cqtch unity exception
* Disable compositor test until we fix it on yamato
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* PBR shader gbuffer ztest (#43)
* Fixed PBR shader rendering in deferred
* Updated changelog
* Enable Light Baking Cookies by default + Warning (#79)
* Enable
* Fix typo
* Importance Sampling Pipeline (#84)
* Multiple Importance Sampling for HDRI Sky (Ray Generation)
* backup
* Multiple helpers
* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
* backup
* Add SampleCubemapProjectionNode (Project cubemap to Geometry)
* delete useless files
* update
* Cube To LatLong for CubeArray
* Functional generation
* Integration on ray tracer step
* Store HDRI Integral
* .
* Integrate HDRI Sky
* Update Importance Sampling
* Update Algorithm with Hemisphere Path
* Backup
* Update merge
* Update Merge 001
* Update Merge 002
* Update Merge 003
* Update Merge 004
* Update Merge 005
* Update Merge 006
* Update Merge 007
* Cleanup
* Update Integration of HDRISky Upper Hemisphere
* Remove useless dump images on disk
* Fix change log issue
* backup
* Backup
* Pre-Clean
* Pre-Clean
* Clean Up - remove file
* Remove Debug Code
* Update
* Update ChangeLog
* Clean Up
* update
* Clean up
* Remove useless texture
* Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter"
* CleanUp
* remove useless comment
* Add variable (Atmospherical) + Rename/Comment
* Move parameter to CS, Clean & move to private RTHandleDeleter
* Revert "Importance Sampling Pipeline (#84)"
This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11.
* Reducing the number of variants for ray tracing when building a player (#94)
* - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform.
- Removed the dynamic lightmap multicompile.
- Remove the LOD cross fade multi compile for ray tracing.
- Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping.
* fix merge
* Update LayeredLit.shader
* Update LayeredLit.shader
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 3003_LightingMode.unity
* Fix compil issue with Enable BakeCookie
* Enable Light Baking Cookies by default + Warning - part 3 #79
* Avoid building the mip chain a second time for SSR for transparent objects. (#93)
* - Avoid building the mip chain a second time for SSR for transparent objects.
* Update ScreenSpaceReflections.compute
* fix merge issue
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Scalable volumetrics [skip ci] (#34)
* Adaptive sampling works
* Compute the PDF
* URL
* Fix stuff up (except for profile preview)
* Attempt to fix previews
* Fix transmission
* Support quality levels
* Clean shader
* Remove 2 kernels
* PURGE
* Automatically adjust the number of samples at runtime
* Changelog
* Spaaaaace
* Add comment
* Spaaaaaace
* Rename
* Update ref img 1215, 1216, 1217
* Revert "Update ref img 1215, 1216, 1217"
This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088.
* Robust filter radius
* Solve the NaN problem
* Save 1x VGPR
* Update SSS defaults
* Add migration steps
* Volume resolution WIP
* Shorter names FTW
* Comment
* Dynamic slice count works
* Dynamic res works
* Changelog
* Stretch the limits
* Fix bug (order matters)
* Comments
* Remove volumetric quality presets
* Changelog
* Reorder
* Solve the mystery of RTs going NULL
* More robust bad history detection
* Update test scenes for High Quality
* More bug fixes
* More accurate comment
* Do not reinvent the wheel
* Fix broken test 1351
* Attempt to migrate HQ SSS settings
* Remove all branches
* Optimize a bit
* 7x WF
* Fix the rounding error
* Fix the rounding error
* Remove garbage allocation
* Fix typos
* Copy the SSS value
* Revert HDRP asset changes
* Fix default UI value
* Pass the right asset
* Update ref img 1215
* update reference screenshots
* Update CHANGELOG.md
* Update CHANGELOG.md
* Switch to RTHandles
* Rename textures used by the fog filtering pass
* Fix reprojection
* Fix shader warning + typo+
* fix another shader warning
Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fixed runtime test for Yamato (#177)
* Revert "Hdrp/runtimetests/ps4 fix (#129)"
This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba.
* Update runtime test to use way less memory to be able to run on console
* Fixed screenshots and test
* Fix HDRP Wizard windows not compatible with "preview" package version (#178)
* Fix async compute throwing errors because of global constant buffers. (#130)
* Replaced commands incompatible with async compute in light list build process.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136)
* Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly.
* Update changelog
* Removed useless test
* Updated changelog message to add more info
* Refactoring to share the code for light list building better between probe volumes and lights. (#156)
* Refactoring to share the code for light list building better between probe volumes and lights.
* Remove commented code
* Fixed constant buffer update
* Fixed kernel used for cluster generation
* Fixed cluster kernel for oblique projection
* Restored a resize test for XR
* Removed unexpected Shuriken folder in Test Project
* Add range attenuation to box-shaped spotlights [Skip CI] (#101)
* Added range attenuation to box-shaped spotlights
* Update tests
* Update CHANGELOG.md
* Remove file duplication
* Added box range attenuation test
* Clarify documentation
* Update screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/decal transparent mip selection 1222437 (#96)
* Improve MIP selection for decals to transparent
* Add change logs
* Communize Helper (ComputeTextureLOD{Bias?}(...)
* Update
* Rename
* Comment
* fix white space and 0.f
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix cookie atlas alloc for cone spot lights (#187)
* Fix unneeded cookie texture allocation for cone stop lights
* Updated changelog
* Fix cone spot light cookie
* update template (#189)
* Hdrp/combine material samples with shader samples [Skip CI] (#117)
* Fix MaterialBalls having same guid issue
material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned
* Merge material samples and shader samples
Merge shader samples into material samples
* Update scene visuals
update frame prefab with new visual style
update scene to suit visual style
* Fix spelling and grammatical errors
alterates -> alters - this one isn't technically an error but alterates isn't used in common English
oder -> order
accross -> across
* Create fabric scene
create scene and rendering settings
* Add fabric ball prefab with fabric mesh
Add fabric ball prefab with fabric mesh
* Add threadmaps to project
Add threadmaps to project
* Add materials to project
Add materials to project
Linen
Nylon
Satin
Velvet
Wool
* Add scenes for hair and fabric and create prefabs for lighting and hair display
Add scenes for hair and fabric
Create prefabs for lighting and hair display
Fix Decal prefab
* Update scene and fix errors with materials that don't use threadmaps
Update scene and fix errors with materials that don't use threadmaps
* Update fabric materials and textures
Update fabric materials and textures
* Clean up project and add additional materials
Add ShotSilk material
Modify materials
Rename textures
Cleanup changes
Add information to fabric scene
* Update and organize scenes
Update and organize scenes
* Update Fabric scene , fix spelling errors and change to american spelling
Update Fabric scene , fix spelling errors and change to american spelling
* Update information in fabric scene
* Update scene lighting
Update scene lighting
* Align lighting and rendering across scenes, remove old sample scene
Create prefabs for common elements
Change sky gradient
Remove unused settings
Remove old sample scene
* Update textures and meshes
Update denim color to tga file format to conform with other files
Update cloth mesh to have better normals
Update scene after changes to prefab
* Update cloth mesh
Update cloth mesh
* Update scene text and cloth mesh
Update scene text and cloth mesh
* Update Changelog
Update Changelog
* Fix bug with material ball and parallax occlusion mapping due to mesh tangents
Fix bug with material ball and parallax occlusion mapping due to mesh tangents
* Remove shader samples from package json and update material samples description
Remove shader samples from package json and update material samples description
* Update sample content documentation
* Update scene text
* Move files in mesh folder to appropriate folders and remove additional material ball prefab
* Add micro shadows
* Update 1301_StackLitSG.png
* Change guid reference in MaterialSamples scene
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* DisplayInfo attribute. (#172)
* Added DisplayInfo attribute for generic display info.
* Implemented volume parameter sorting for default inspector.
* Update changelog
* Named parameters for tuples in Volume Component Editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Compute Buffer management for render graph (#194)
* Added import and usage of Compute Buffer API to render graph.
* Missing clear of Compute buffer write/read lists.
* Another missing clear.
* Light loop compute buffers WIP
# Conflicts:
# com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
# com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs
* Reverted Render Graph debug registering by default.
* Post merge fixes
* RenderPass debugger visualization and fixed null profiling sampler
* Missing using directive.
* Post merge fix
* Use new light list build ouptut for deferred lighting pass
* Use new light list build ouptut for contact shadow pass
* Use new light list build ouptut for volumetric passes
* Simplify the tooltip (#188)
* Added MovedFrom attribute (#182)
* Contact shadow min distance + fix scalarization code (#150)
* Min distance
* editor update
* Update doc
* Changelog
* fix some ui issues
* Update docs according to UI changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* TAA docs update (#132)
* update docs
* pr review
* Added indentation as dashed
* Hdrp/deferred shadow quality multi compile (#5)
* shadow mask
* Changelog
* Have shadow quality as multi_compile
* make old API obsolete
* Update comment
* Comment on pre processor
* Update docs
* Change shader versions of deferred
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/path traced dof (#164)
* Path traced DoF implementation
* Move focus distance from volume to physical camera
* Small fixes
* Small fixes in math
* Small fixes in math 2
* Compile error
* Make new functions private
* Cosmetic changes
* Move viewport matrix function to utils
* Keep focus distance in the volume
* Do not enable in scene view camera
* Changelog
* Review feedback
* Use scale and bias instead of matrix mul for the viewport transform
* Bugfix: post process DoF should still be executed for non-physical mode
* Typo
* avoid null reference when physical params is null
* remove redundant check
* Update HDRenderPipelineAsset.asset (#210)
* Fixed volume debug menu in playmode (#149)
* Refresh widgets in play mode. Added doc. Reduced refresh rate
* Changelog
* Added some code doc
* Fix refresh rate and scroll over hidden volumes in play mode
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new test scene for physical camera DoF in Pathtracer (#211)
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)
* fix bug 1238155
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* Update HDRenderPipelineAsset.cs
* Fix warning in PCSS code when using Vulkan (#229)
* Fix warning
* changelog
* Fix decal register + obsolete cookie API (#195)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Fix decal shader
* Fixed HDRP cookie
* Update HDLightUI.cs
* correctly fix decal
* Update CHANGELOG.md
* Update ColorAdjustments.cs
* Update ShaderVariablesDecal.hlsl
* fix compil on 2020.1
* Update HDRP_Test_Def.asset
* add test for 3RT decal
* update decal test
* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)
* Do code cleanup + bugfix shadow
* Update Upgrading-from-2020.1-to-2020.2.md
* Update LightLoopDef.hlsl
* Fixed issues with path traced SSS and accumulation. (#257)
* Add missing documentation for AOV API params (#254)
* Hdrp/public static sky (#253)
* Made the static lighting sky public so that users can change it by script for baking purpose.
* Update changelog
* Update HDAdditionalLightData.Migration.cs (#269)
* Add missing docs attributes (#271)
* Fixed an error about procedural sky being logged by mistake. (#273)
* Fixed an error about procedural sky being logged by mistake.
* Update changelog
* Fix quality settings UI and shadow mask UI (#122)
* Update HDRenderPipeline.cs
* Update HDRenderPipeline.cs
* Update CHANGELOG.md
* Update HDRenderPipeline.cs
* fix typo
* fix typo 2
* Updated raytracing async compute warning. (#274)
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)
* Fixed a null ref exception in static sky when the default volume profile is invalid.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added SubScenes cache to be compatible with HDRP/staging (#287)
* Update 2002_Light_DynamicMix.unity (#292)
* Update HDCubemapInspector.cs (#296)
* increase tolerance for test 5008 in VR due to recent changes (#311)
* Upate screenshot for HDRP DXR Test (#312)
* Fix SSS code doc (#319)
* Fix issue with screen-space shadows not enabled with RT off (#139)
* Fix issue with screen_space shadows not enabled with RT off
* Proper fix: only keep directional screen space shadows with RT off
* Fix shadow debug mode
* cosmetic changes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed a performance issue with stochastic ray traced area shadows. (#300)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix bad merge of the light loop optimization PR (an optimization was undone) (#321)
* Don't compute light type
* Typo
* Camera override API (#170)
* Added the API to override camera rendering
* Updated changelog
* Fixed compilation issue
* Factorized protection function
* Fixed camera override in scene view
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fixed camera override with dynamic resolution and moved it to internal
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix cookie srgb (#297)
* Fixed srgb flag not updating the cookie atlas
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering lighting in the scene and game view when lookdev is open. (#290)
* Fixed flickering of the game/scene view when lookdev is running.
* Update changelog.
* Added a function to reset the reference size of RTHandle systems. (#299)
* Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems.
* Update changelog
* Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291)
* render until ambient probe is ready
* changelog
* remove comment
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix Motion Vectors written by transparent when rendering with MSAA (#315)
* Add resolve if needed of transparent movec
* rename
* rendergraph
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Hdrp/reflection probe scale perf (#252)
* Use IEnumerable as interface for HDProbeSystem
* Added a perf test for probe registration
* Use HashSet instead of List to store HDProbes
* Updated planar reflection to use a HashSet
* Updated changelog
* Fix invalid length check
* Fixed build of planar probe array
* Fixed GC alloc issue
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* [9.x.x] Axf measurements into tilings (#289)
* AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support.
On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material.
This removes old materialU/V tiling and flakes tiling (AxF is still in preview though).
Update test scene to move old tiling property values into new properties so results don't change.
Update documentation.
* AxF measurements into tilings: Add changelog entry.
* AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings.
* Update the AlphaToMask test for AxF.
* Update all other editor and player platform references to match.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* fix 9402screenshots on vulkan
* Update HDRP graphic test framework with Test Broken / TestFilter script (#393)
* Update hdrp testing framework
* Update hdrp testing framework 2
* Update TestFilterGenerator.cs
* revert change on shader graph
* Hd/add layer modification on generated emissive mesh for area light (#364)
* Add Layer modification of EmissiveMesh generated by area light
Add Layer handling on Generated Emissive Mesh
* Update CHANGELOG.md
* Add "same as Light" hability for layer and make it default
* Add destruction on move in hierarchy and retrieve existing to secure the NotEditable
* Add sync on Static too
* Also the copy the static drop down
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Disable async compute for D3D12 [Hold] (#301)
* disable async on d3d12
* Change doc
* Hd/fix nullref while removing decal component (#416)
* fix nullref on DecalComponent removed from contextual menu
* Update CHANGELOG.md
* Added a flow map parameter to HDRI Sky (#44)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* Dropdown and upper hemisphere fix
* Updated doc
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with Uber Post process shader when alpha is enabled (#422)
* Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling
* Changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* replace fbx by the one from URP with no import errors (#427)
* Fix the bug (#430)
* Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418)
* Saturate vertex color to avoid negative values.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Renamed variables (#436)
* Fix issue with the resolve of motion vectors (#421)
* Hd/fix targets used in ongui in decalcomponent (#413)
* Fix Reset not resetting to default
* Delay MaterialEditor recreation to when possible
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implemented ray traced reflections for transparent objects. (#47)
* Implementation of ray traced reflections for transparent objects
* fix issue with ShowPrePassAndPostPass
* Change label for transparent SSR + change default value to false
* fix material not setup properly
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix custom pass graphic tests (#359)
* FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test
* Replaced canvas by a quad (more stable for graphic test)
* disable vulkan test as it is failing, need investigation
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Save scene-view camera settings in Editor prefs (#440)
* Sceneview camera settings are now saved in Editor prefs
* cosmetic changes
* add comment
* Small refactor to allow easily adding more prefs in the future
* fix comment
* fix comment 2
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue when switching back to custom sensor type in physical camera (#417)
* Fix issue when switching back to custom sensor type in physical camera
* make if comparison more explicit
* make if comparison more safe
* Per-camera history for the custom settings using a static dictionary
* Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix a null ref exception when running playmode tests (#360)
* fix a null ref exception when running playmode tests with the render pipeline debug window opened
* use empty array
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed some gcalloc in the debug window (#445)
* Fixed some GCAlloc in the debug window
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update reference screenshot dx12
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443)
* Fixed shader graphs not casting semi-transparent and color shadows (case 1242617)
* Fix an issue with thin refraction SG and updating screenshots
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Create Shaders.meta
* Hdrp/small ui update (#423)
* Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
* Update changelog.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update settings for DXR
* Update SetToCameraNearPlane.cs
* Add an option to disable shadow bias
* Don't query cull results if we don't have them (#449)
* test with a guard
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update screenshot (#463)
* Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12
* Update TestCaseFilters.asset
* Revert "Disable async compute for D3D12 [Hold] (#301)" (#469)
This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16.
* Revert "Add an option to disable shadow bias"
This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c.
* PBR Sky renderer now shares its internal precomputation table between different instances. (#250)
* PBR Sky renderer now shares its internal precomputation table between different instances.
* Update changelog
* Doc update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Makes sure quaternion is normalized and valid before converting to ma… (#331)
* Makes sure quaternion is normalized and valid before converting to matrix.
* Updated Changelo.
* Revert "Updated Changelo."
This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2.
* Update CHANGELOG.md
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* New tooltip for camera background and fixed exposure when switching the background mode. (#415)
* Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue causing not all baked reflection probes to be deleted (#441)
* Clear the queue once filled up and push elements that failed to be pushed.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed asset preview being rendered white because of static lighting sky. (#462)
* Fixed an issue where asset preview could be rendered white because of static lighting sky.
Also fixed an issue where static lighting was not updated when removing the static lighting sky profile.
* Update changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed null reference exception in LookDev when setting the SRP to None (#447)
* Fixed null reference exception in LookDev when setting the SRP to None
* Review feedback
* Review feedback 2
* Fix show cookie atlas debug mode (#475)
* Fix the show cookie atlas debug mode not displaying correctly
* Updated changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable DXR playmode test (#472)
* Update upm-ci-hdrp_dxr.yml
* add hdrp dxr playmode test to all hdrp ci
* Update upm-ci-hdrp.yml
* Update upm-ci-hdrp.yml
* change planar atlas size to 1024
* Update upm-ci-hdrp.yml
* Update 802_SubSurfaceScatteringForward.png
* update scene
* update 5001 lighting
* fix exposure for 5001 path tracing test
* update player screenshots
* disable 5001 path tracing as it fail on yamato
* Fix few multi-editing issues with Emission UI (#473)
* Working but not nice
* Remove unecessary cruft
* tiny changes
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Re-enable cubemap thumbnail gen only for d3d11 (#487)
* re-enable thumbnail gen only for d3d11
* Update changelog
* try enable metal
* Update changelog and comment
* Check reflection probe null pointer before use. (case 1244047) (#456)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Remove max atlas probe alloc size in HDRP asset (#458)
* Fixed max alloc planar size not taking in account the max cache size
* Removed the max cache clamp on texture atlases
* Hd/fix undo environmentlibrary lookdev (#490)
* fix undo redo for environment library
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix vulkan test
* SSGI Implementation (#95)
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Change Sky in 5001 PT Test to HDRI Sky + update image (#502)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 802_SubSurfaceScatteringForward.unity
* fix vulkan warring and wrong meta
* Update upm-ci-hdrp.yml
* Fix merge issue with Test filter
* Use path relative to package for depth of field (#523)
* Use absolute paths for dof include
* changelog
* Fix Light overlap (#444)
* Added the light overlap volume code
* Updated changelog
* Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode
* Fixed documentation
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed API breakage. (#524)
* [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532)
* AOV documentation
* minor change in the comments
* Accumulation documentation
* minor improvements
* Rewrite the AOV script. Now it is stand-alone.
* Typo
* Add path traced DoF documentation
* Reviewed AOV doc
* Reviewed accumulation doc
* Reviewed path-traced dof doc
* Add missing OnDestroy in example script
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
* Restore some XR HDRP tests (#382)
* restored XR tests
* revert and split changes for temporal effects in another branch
* fix XR tests using volumetrics
* 8103 is still acting randomly
* try to set timeout to 30s to confirm it's working
* set timeout to 5 min per test for HDRP instead of default 3 min
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix taaFrameIndex and restore TAA tests for XR (#534)
* fix taaFrameIndex and temporal effects with the test suite
* increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty
* update ref images
* set waitFrames for HDRP runtime test scene
* reset camera before waiting
* update reference images from Yamato
* revert change to 001-HDTemplate
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488)
* Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255)
* Add missing inverse exposure multiplier
* Add support for batchmode (#542)
* Update 9301_MotionVectorsOff-Forward-Dynamic.png
* Fix custom pass prefabs (#419)
* Fix custom pass integration with prefabs
* Updated changelog
* Fixed prefab highlight not updated when adding/removing custom passes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* Reverted volumetric lighting changes and now render graph version uses the shared textures.
* Clone in the Asset folder when the original volume profile is in a re… (#508)
* Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961)
* Added changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529)
* Custom Pass API (part 1) (#155)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Updated changelog
* Added custom pass API test scene
* Fixed custom pass API doc
* Moved obsolete execute function into the new one
* Updated custom clear pass to use the new API
* Updated custom pass API test reference image
* update reference screenshots
* Fixed various scale issues in the blur custom pass API and updated reference screenshot
* Disable custom pass API test because it's unstable
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Implement Constant Buffers for HDRP (part 3) (#98)
* Fixed execution error without raytracing
* Prepare Prepass refacto
* Another round of preparation
* Renamed XRPassScope to XRSinglePassScope
* RenderAfterPostProcess is now static
* Add AfterPostProcess to RenderGraph (WIP)
* AfterPostProcess implementation
* Fixed wrong RTHandle allocation
* Fixed light layers texture binding during deferred lighting pass
* Implemented Post Process Final Pass with RenderGraph
* Post merge fixes
* Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.
* Fixed alpha in post processes
* Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle
* Fixed decal normal patch pass
* Fixed stencil resolve render pass
* Fixed RenderDBuffer render pass function capturing variables.
* Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList
* Various fixes of things that diverged compared to regular path.
* Unified renderer list and texture invalid handle error.
* Revert wrong change
* Added constant buffer hlsl generation
* Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C#
* post merge fix
* Removed useless comment.
* Missing doc
* Started moving cmd.SetGlobalXXX to update the global CB (WIP)
* Implemented Volumetrics global CB and various fixes.
* Implemented shadow global CB update.
* Finished up Global Constant Buffer setup
* Fix null ref
* Fixed global constant buffer alignment issues.
* Fixed shadows and SSS
* Small ConstantBuffer API refacto
* Small fix
* Volumetric Constant Buffer implementation + Fix
* Fix ambient occlusion
* Removed redundant SetGlobalXXX
* Light list build global CB implementation
* Fixed path tracing frame index constant
* Fixed ao constant w/ raytracing
* Better path tracing fix.
* Refactored CB API to comply with Render Graph specificities
* Update test screenshot
* Fixed constant buffer generation to use macros.
* Implemented XR global constant buffer.
* Removed useless global constant
* Fixed XR global constant name
* Converted SSR to constant buffer.
* Converted AO to constant buffers.
* Fixed warning
* Removed some useless SetGlobalXXX in Light Cookie Manager
* Converted debug display to use constant buffer.
* Fixed color/depth pyramid debug
* Cleanup
* Implemented constant buffer for PBR sky global variables.
* Warning fix
* Small fix
* Cleanup of global setup happening before rendering (render graph path or not).
* Post merge fix
* Added global constant buffer hlsl generation.
* Post merge fix
* Converted raytracing lightloop variables to constant buffer.
* Converted RayTracing global variables to constant buffer.
* Removed obsolete comment
* Post merge fix
* Post merge fix
* Post merge fix 2
* Double inclusion fix.
* Fixed CB visibility
* Fixed compilation after the merge
* Indentation fix
* Removed temporary comments.
* Moved some constants around.
* Post merge fix + Port ProbeVolume global variables to constant buffers.
* Fixed deallocation of constant buffers
* Properly release Volumetric constant buffers.
* Another update to CB API
* Updated documentation.
* Missing generated file
* Post merge fix
* Fixed various issues with light probe volumes.
* Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene.
* Final fix for probe volumes
* Fixed a warning in shader compilation
* Changes from review feedback
* Compilation fix.
* Post merge fix
* Removed useless constant
* Crash fix
* Post merge fix
* Update 501_RecursiveRendering.png
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Hd/fix wizard defaultvolumeprofile creation (#565)
* Fix Wizard check on default volume profile
* Update CHANGELOG.md
* Small TAA Anti-flicker changes (#555)
* tweaks
* Change default so that is just high quality.
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix central depth sampling in TAA (#564)
* Fix sampling of central depth
* changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Render Graph Async Compute (#552)
* Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP)
* AO and Post Processes.
* Prefixed all history buffers with camera name for readability in the memory profiler.
* LIght volume debug and Volumetric (WIP)
* Fixed volumetric
* Fixed deallocation of SSS buffers
* Review feedback fixes.
* Init order fix for post process
* WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies.
* Implementation of async resource synchronization.
* Fixed synchronization (only partial fix)
* Added default profiling sampler for render graph passes not providing one.
* Async WIP
* Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async.
* Post merge fix
* Cleanup
* Removed comment.
* Disabled async contact shadows again.
* Small cleanup
* Change exposure compensation in the default volume profile to 0. (#388)
* Change profile (And add missing setting)
* changelog
* Upgrade guide
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram guided auto-exposure + debug modes (#372)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* Review feedback
* Bad merge fixup
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Refactor shadow caching system (#554)
* Very debuggy code just start nothing functional or usable yet.
* remove old cached stuff (not finished, need switch branch)
* revert wrongful commit
* A bit of restructuring
* A good point as any to sync up
* sync
* Move from old repo...
* fix regression
* Handle case in which shadow doesn't fit
* leftover not committed
* Fix some issues with culling of point lights from the
* preliminary support for cascaded shadows
* Fix some issue with the directional
* Subshadow update
* Add some guards, some debug and the new C++ api for infinite bounds
* Some UI for the resolution
* Fix merge issues
* Update debug cs.hlsl
* Render graph stuff and some leftover removal
* micro cleanup
* Fix behaviour when defragging and excess lights are there
* Public API
* Remove dbg names
* Bug on debug view of area atlas
* Missing field on new PCSS signature for directional
* More public API
* Refresh cached shadows on resolution changes.
* merge conflicts patchup
* Fix missing shadows on normal shadows
* Small cleanup and turning positive the doesn'tHavePlacement
* Fix case on switching light type and issue with non-rectangle area lights
* tentative fix for error on build
* Debug logging
* update naming of debug
* Fix issue with double inclusion
* DOCS
* upgrade guide
* post merge fixups
* leftover comment
* changelog
* Doc changes in upgrade guide
* have print debug info only in editor
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* update reference screenshots
* VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest
* Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584)
* remove useless code for cookie
* Hdrp/fix camera switcher (#591)
* Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions.
* update changelog.
* fix issue that prevents PS4 from building (#596)
* Removed experimental namespace for ray tracing code. (#612)
* Hdrp/multi view pt (#518)
* Multiview (scene + game) path tracing accumulation.
* Cosmetic.
* Modifications to address comments in PR.
* Updated PT fog test.
* Updated Changelog.
* Fixed issue with unlit shader graphs in path-traced mode.
* Update CHANGELOG.md
* Update HDUnlitSubTarget.cs
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix Look Dev default profile not updating correctly (#630)
* Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window.
* Update changelog
* Fix Unlit.template in shadergraph (#637)
* Remove unused unlitpass.template
* Update Lit.hlsl
* re-add unlit pass
* Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609)
* - Fixed a bug where the light list is not cleared but still used when resizing the RT.
* add changelog
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Histogram view improvements (#589)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* review fixups
* print exposure values in debug view
* commit but it is nothing, need to switch branch
* Add option to center histogram around exposure (fixed tonemap curve)
* change color of text
* fixup debug display merge issue
* fixup merge issues
* fixup issue with tonemap curve
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Update 9702_CustomPass_API.png.meta
* Fix warning (#663)
* add shader macros for XR single-pass (#687)
* Adding 2 SG Pathtracer test scenes (#624)
* New unlit pt scene
* Add scene for PT Lit
* Removing collider from the meshes
* Renaming
* Adding screenshots for PT scenes
* Changing threshold for SSS deferred tests for stability
* updating screenshot after staging being merged
* Slightly increasing threshold for 5007 and 902 unlit scenes
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Render Graph Unit Tests (#607)
* Render Graph Unit test WIP
Fixed pruning of passes with no output.
* Render Graph tests WIP
* Increase max limit in UX of lights (#702)
* Raise the max for lights
* Update CHANGELOG.md
* Fix null reference in volume debug menu (#705)
* Update reference image for "502_RecursiveRenderingDisabled" (#704)
* Update screenshot for 502 recursive rendering disabled test scene
* upgrade shader material
* Fix transparent movec scene view (#698)
* Disable transparent movec when object motion vectors are disabled
* changelog
* Port (#599)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Custom Pass API part 2 (#227)
* Begin to write the new custom pass API
* Begin to add custom pass utils shader
* Begin to add custom pass API test scenes
* Fixes for the Gaussian blur of the custom pass API
* Fix blur release
* Added custom pass copy test and fixed blur
* Added more custom pass documentation
* Added custom pass API graphic test reference image
* Added more obsolete things
* fix function visibility
* Added the API to override camera rendering
* Updated changelog
* Updated changelog
* Fixed compilation issue
* Added custom pass API test scene
* Begin to add custom pass override test
* Factorized protection function
* Update custom pass test scene
* Fixed custom pass API doc
* Begin to add camera override tests
* Fixed camera override in scene view
* Finished RenderFrom API fucntions
* Fixed XR disable class
* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update
* Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations
* Finished to fix the RenderFrom* functions
* Moved obsolete execute function into the new one
* Update reference images
* Added all the API doc
* Updated changelog
* revert mats
* Updated custom clear pass to use the new API
* Fixed depth buffer random read/write error
* Disable custom pass blur test part
* Revert camera pixel rect changes
* Rename multi-pass to single pass
* Disable custom pass test on vulkan and XR
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fix line that got lost in merge (#729)
* Porting console fixes to staging (#699)
* Path tracer: added support for transparency on the Unlit shader. (#717)
* Added support for transparency in Unlit.
* Updated Changelog.
* Update capture for 5007_PathTracing Unlit
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* HDRP Compositor related fixes (#730)
* Fixes for the compositor test
* Enable the compoositor test in build settings
* Avoid gc alloc, hide internal components from vomume menu
* Vulkan and DX12 screens, adjust compositor UI refresh
* Fixed a vulkan and metal warning in the SSGI compute shader. (#715)
* - Fixed a vulkan and metal warning in the SSGI compute shader.
* - Fixed an exception due to the color pyramid not allocated when SSGI is enabled.
- Fixed an issue with the first depth history mip was incorrectly copied.
* Fix path traced DoF focusing issue (#732)
* Remove mip padding from PlanarReflectionProbeCache.cs
* Disable 9702 test nor working + 9041 XR (instable)
* Hdrp/pt pass no bsdf data (#710)
* Removed direct use of BSDFData in path tracing pass.
* Updated changelog.
* Fixed float3 typo...
* fix metal 9800 reference screnshots
* update meta file and testcasefilter
* Pre warm RT Handle system so that reallocations are reduced. (#713)
* Pre warm rt handle system and initialize to screen width/height
* changelog
* not all was pushed
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Various fixes for Graphics tests with Render Graph (#725)
* WIP for enabling valid graphics tests with Render Graph.
Fixed a lot of gcalloc.
* Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled.
* First batch of disabled tests.
* Fixed decal rendering
* Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral)
* Revert "First batch of disabled tests."
This reverts commit 505924b6967041787c0698b4ede1d158686f990e.
* Temp "texture not bound" error fix until bloom is implemented.
* Fixed an error when using a stale invalid renderer list handle.
Reduced error message spam when encountering an execution error.
* Add some debug info to compiled passes and removed wrong refCount++ on passes.
* Added possibility to disallow pass pruning
Fixed a number of pass pruning issues.
* Small fixes
* temporarily removed pruning of passes without product
* Fixed HDRP asset for test 5009
* Implement alpha copy for post processes
* Small render graph error fix for motion vector pass.
* Disabled for render graph tests that are currently broken.
* Updated yamato with new render graph configurations
* Fixed lens distortion
* Reenabled 4021
* Revert "Reenabled 4021"
This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64.
* Revert "Updated yamato with new render graph configurations"
This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9.
* Revert "Disabled for render graph tests that are currently broken."
This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026.
* Reverted HDRP test framework files (will go to another PR)
* Revert "Fixed HDRP asset for test 5009"
This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc.
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Various fix and improvements for ray traced effects (#597)
* Adding a minimal lit used for RTGI in peformance mode
Dispatch binned rays in 1D instead of 2D
Fix an issue with the half resolution Mode for RTGI
Only read the geometric attributes that are required using the share pass info and shader graph defines
Fix an issue with the color intensity of emissive for performance rtgi
* Correct bug with shadow history rejection
* reduce the exponential accumulation value a bit
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Procedural metering mask that follows target (#723)
* some very incomplete stuff...
* sync point, rough working version
* Mostly working for now, moving onto debug vis and maybe revisit.
* Commit as I need branch switching - Start debug modes
* Add a bunch of debug mode and start of histogram
* Delimiters indicator with bars
* Add another option for percentile exttremes
* fix warning
* Moving debug modes
* Label bar separate (invisible otherwise)
* Push change to bar indicator
* remove fancy background of histogram frame
* start of procedural mask
* Small triangle instead of indicator bars
* Target exposure indicator
* add some margin
* Add an X at center
* Metering PiP
* Draw tonemap curve and use tonemapped texture for view
* Share some code
* Curve remapping for histogram and fix some warning
* Some comments fixup
* Simple comment changes
* Revert debug symbol in shader
* Changelog
* Some basic version of procedural working
* need to switch branch
* Exposure target and threshold.
* fix merge mess
* Fixes
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* - Added presets quality settings for RTAO and RTGI. (#724)
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compilation issue in HDRaytracingIndirectDiffuse
* fix shader warning in exposure
* Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648)
* - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR).
* Simplifying the culling override.
* Update 708_ShadowExtendedCulling.png
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Removed reference image for player (unused) in HDRP Test
* Update preview naming (#753)
* Cloud layer volume override (#461)
* Added uv distorsion for HDRISky cubemap
* Editable flow strength
* Better parameter name. Smooth flow on cube edges
* Added a graphic test. Updated Changelog
* Updated documentation
* Added screenshots
* Wait frames for test
* Wait more
* Update screenshots again...
* Static test
* Static screenshots
* use multi_compile
* Renamed all parameters
* Procedural distortion
* Update doc
* Set all keywords
* Revert to old behaviour
* doc
* update test
* remove useless variable
* doc
* CloudLayer HDRI
* CloudLayer Gradient
* CloudLayer Physically Based
* Documentation
* Add clouds to Static Lighting Sky
* Fix spherical conversion
* Fix procedural flow
* Fix lat long and procedural flow
* replace trig functions. Correct wind dir
* sync with hdri flow
* Renamed variables
* Allow full sphere coverage for procedural flowmap
* Added missing doc
* Fix cloud reset and unrelated warnings in hdri sky shader
* Try different blending method
* Fixes + test another blending
* Tint and intensity parameters. Fix static sky used by lightmapper
* Added graphic test. Updated doc
* Updated tests using a disabled static sky
If a sky override is used for static lighting and is disabled in the volume, it is not used anymore
* Update LocalAmbientOcclusionNoisy.asset
* update linux screenshots
* Update CloudLayer.cs
* update OSX screenshots
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Introduce LightLoop output structure (#754)
* Add concept of LightLoop Output
* update upgrade guide
* Update Upgrading-from-2020.1-to-2020.2.md
* update upgrade guide
* Fix lightloop-output (#755)
* Fix rendering when XrMaxViews is different than 2 (#733)
* Use a fixed size for xr related fields in cbuffers
* changelog
* Update local shader config
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Improve transition between LOD for lit and layeredLit tessellation (#517)
* Forest scale for tessellation change
* Forest scale for tessellation change
* Update Upgrading-from-2019.3-to-2020.1.md
* Update Upgrading-from-2019.3-to-2020.1.md
* fix ray tracing with XR single-pass (#769)
* Revert "fix ray tracing with XR single-pass (#769)"
This reverts commit 3e366334444febf450568b47ada2c00e4164ba12.
* reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766)
* Probe Volumes: Update SampleBakedGI() API (#759)
* Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time.
* Add some comment
Co-authored-by: pastasfuture <pastasfuture@gmail.com>
* Initial implementation for the new planar reflection filtering (#337)
* Initial implementation for the new planar reflection filtering
* Small improvement and "proper" support of oblique projection
* quality improvement to the filtering.
* Update PlanarReflectionFiltering.compute
* review corrections
* Update planar filter for all material (was not replaced) + update screenshots
* Update IBLFilterGGX.cs
* fix shader warning on vulkan
* update references screenshots
* Fixes for the plane normal and number of mips to be computed
* Fix shift that was to the right in the blurred version
* update references screenshots
* fix shader warning
* Some cleanup
* change to fast Atan
Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
* Fast memory support (#772)
* temp, gonna revert this, but have to merge staging.
* again, need to switch branch, nothing functional
* ESRAM support
* changelog
* Add guards
* Standard terrain upgrader (#762)
* Add render graph specific pipeline to HDRP tests. (#728)
* Added an option to ignore tests when render graph is enabled.
* Disabled for render graph tests that are currently broken.
* Reenabled 4021
* Updated yamato script to add the RenderGraph pipeline.
* Fixed HDRP asset for test 5009
* Revert unrelated yml files changes due to old configuration (#714)
* Fixed an issue with not unregistering render graph debug.
Disabled test 9401 for render graph after merge conflict.
* Disabled 9800 for render graph
* Revert hdrp asset for 5009
Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com>
* Added CPU and GPU timings for ray tracing effects. (#774)
* Added CPU and GPU timings for ray tracing effects.
* Only displaying the counters if ray tracing is supported on the asset.
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Workaround for GetKernelThreadGroupSizes returning wrong data (#760)
* Hard code group size
* changelog
* Add comment
* Fixed the distanced based denoising being exposed for area lights (1251558). (#782)
* Fix test project
* Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791)
* Fix issue accessing already released targets for rendergraph
* changelog
* Sanitize transparent motion vectors setting (#761)
* Sanitize transparent motion vectors setting
* Update CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Revert "Add render graph specific pipeline to HDRP tests. (#728)"
This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e.
* Increased path tracing roughness range. (#763)
* Increased path tracing roughness range.
* Updated failing tests reference images.
* Update Upgrading-from-2020.1-to-2020.2.md (#798)
* Force post process parent setting to be before child settings (#799)
* Force post process parent setting to be before child
* changelog
* Fix exposure white flash when enabling SSGI or SSR (#801)
* Inform post process that history have been nuked
* changelog
* Various fixes related to SSGI and RTGI (#803)
* Added support to combine RTSSS and RTGI
The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting.
Fixed an exception happening when using RTSSS without using RTShadows
Changing the default SSGI radius for the all configurations
Update screenshots for GI scenes
* changelog update
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Sean Puller <43151199+SeanPuller@users.noreply.github.com>
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Evgenii <evgenii@unity3d.com>
Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: pastasfuture <pastasfuture@gmail.com>
Co-authored-by: Theo Penavaire…
sebastienlagarde
added a commit
that referenced
this pull request
Jun 11, 2020
* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. * Increased path tracing roughness range. (#763) * Increased path tracing roughness range. * Updated failing tests reference images. * Update Upgrading-from-2020.1-to-2020.2.md (#798) * Force post process parent setting to be before child settings (#799) * Force post process parent setting to be before child * changelog * Fix exposure white flash when enabling SSGI or SSR (#801) * Inform post process that history have been nuked * changelog * Various fixes related to SSGI and RTGI (#803) * Added support to combine RTSSS and RTGI The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting. Fixed an exception happening when using RTSSS without using RTShadows Changing the default SSGI radius for the all configurations Update screenshots for GI scenes * changelog update * [Draft] Lighting/probevolumes cleanup (#756) * Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code * Fix clearing of uninitialized GI * Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different performance / quality tradeoffs. Data pipeline for this seems to be working now (though only properly verified with SH1 at the moment). Next step is to update sampling / evaluation code to handle SH0, and SH2 variants. * Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well. * Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same treatment for AtlasOctahedralDepth. * Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize * Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig * Probe Volumes: Bugfix: DataIsAssigned function needed in build as well. * Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Light loop mode is tooled up to do single evaluation. Material Pass mode still accumulates twice, because SampleBakedGI() is called twice. Need to modify SampleBakedGI() signature to take both normals and internally accumulate front and back lighting. * Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function. * Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions. * Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use. * Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering. * Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, we should remove this unnecessary allocation. * Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 atlas. Upsampling is lossy, but supported, i.e: sample L2 in L0 atlas. Atlas coefficient layout was changed to accomodate this, and ProbeVolumeAccumulate function was moved to its own include so that each order variant can be generated with the preprocessor. * Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include). * Probe Volumes: Fix to ProbeVolumeUI string names * Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention. * Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader * Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in seperate float array. This allows us to always bake and serialize SH2, but conditionally upload only SH0 and SH1 terms if user only requests SH1 atlas. This will also make it easier for SH2 terms to be stripped from the build in the future. * Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and SampleBakedGI. * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart() * Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default. * Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention. * Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest. Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> * update DXR Test project * Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#788) * Allow camera only transparent motion vectors * Changelog * revert old way of doing it. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Made VT settings classes internal rather than private/public (#805) Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> * update test filter * fix shad variables globals after merge * Update ShaderVariablesGlobal.cs.hlsl * Update LightingDebug.cs.hlsl * Fix reflection probe framesettings override (#796) * Fix reflection probe framsettings override * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix artifacts in volumetric lighting near opaque geometry (#493) * Add view bias to volumetrics * Implement geometry-distance-aware volume rendering * Comment * Fix the flickering issue * Clean * Fix * Changelog * Implement lookup bias for volumetrics * Update CHANGELOG.md * update test filter * fix refernce screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed WRITE_NORMAL_BUFFER macro redefinition and generated interpolators in ShadowCaster and META pass (#816) * update reference screenshots * Hdrp/fix/cookie area light update (#828) * Fixed area light cookie not used when a spot cookie is assigned * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode (#827) * Make sure update of dynamic res happens only in game view and not when playing. * changelog * Allow forced res to still be valid while not playing Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix raytracing keyword & static render state leak (#829) * Fix raytracing keyword value * Fix static render state being modified and causing side effects * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow (#823) * specular color needs to be weighted back with the blend factor. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update HDShaderPasses.cs * Add custom post process before TAA injection point (#817) * Added custom post process before TAA injection point * Updated custom pp graphic test * Added before TAA post process in HDRP default settings * Re-enabling the bloom test (#809) * Re-enabling the bloom test * Moving the test at the proper position Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fix depth pyramid issues with dynamic resolution (#806) * Recompute the mip info before generating the mipchain * changelog * avoid compute mipchain if not needed Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix decal being duplicated in prefab isolation mode. (#789) * Fixed decals being duplicated in prefab isolation mode. * Update changelog. * Fix decals in the player. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue where rendering preview with MSAA might generate render graph errors. (#800) * Fixed an issue where rendering preview with MSAA might generate render graph errors. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile issue on PS4 for PlanarReflectionFiltering.compute (#830) * Fix compile issue for PS4. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue * IES Light Support (Point, Spot & Rectangular Lights) (#459) * IES Importe & Generate 2D/Cube/Equirectangular Textues * Enable PreviewGUI for IES Light, Split Core & HDRP * IES Point sampling enable Octahedral * missing file * spaces * for test * Cut of push Yamato generation * Wrong merge: Missing file * Missing file * wip * Octahedral Tilling * Cleaner & introduce IESObject * missing dead code * Allow only Power of 2 textures, update when resize * Clean code, + change log + Area Light * remove useless code * minor update * Merge * Cleanup * Remove useless log * Unify code + cleanup * Update documentation * Disable IES for Directionnal Lights * Fix when we update the spot angle baked * Update documentation & rename UI * com * Fix error for Area/Rectangular lights * Minor typo + move internal (WIP) * minor * minor * fix Pyramid + Box light & Add support of IES for them * Unreachable code fix * fix HDRPTest for Box lights * Add missing public doc * Last missing doc issues - fix * Remove all CGAlloc; Remove IES + Cookie for emissive mesh of area light(+Update doc) * Remove useless code, typo * Update versions in manifests (#647) * update manifests * Update manifest.json * update hdrp runtime [skip ci] * update testing packages [skip ci] * remove unused references * Update reference to support octahedral for animated texture * Update GI Support (HDRP Test valid) * Update image reference * Add migration message for Cookies * Fix message * Typo in light-component.md * Forgot an "and" * Typo in display emissive mesh property * Update documentation to clarify the case for light baking + IES cases * Switch from slider to ComboBox for IES Resolution * Rewording sentence on cookie/ies baking tooltip * Used same sentence from elsewhere for coherence * Fix compilation issue after merge * Update Vulkan reference images * Update OSX Metal reference image for CubeCookie * Formating, type & convention * Formating & code convention * Fix warning message * Update upgrading 2020.1 to 2020.2 doc * Update light loop for fetching * Update Upgrading-from-2020.1-to-2020.2.md * Update Upgrading-from-2020.1-to-2020.2.md * Update LightCookieManager.cs * Update HDRenderPipelineAsset.Migration.cs * Fix DXR Text * Fix Yamato XR * update reference screenshots * update reference screenshots * fix for Yamato OSXEditor/Metal Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> * Revert "Re-enabling the bloom test (#809)" This reverts commit cc9a6498c9213174f27b14d5aa5f081667346d99. * Update reference screenshots for IES * fix shader warning in DepthTAA.shader * Update 2313_Shadow_Mask_Spotlight_Shapes.unity * Update VFX reference screenshots * Update 4060_CustomPostProcess.unity * Update HDSRP_ Test reference screenshots * Update TestCaseFilters.asset Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Evgenii <evgenii@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com> Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Jun 11, 2020
* Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. * Increased path tracing roughness range. (#763) * Increased path tracing roughness range. * Updated failing tests reference images. * Update Upgrading-from-2020.1-to-2020.2.md (#798) * Force post process parent setting to be before child settings (#799) * Force post process parent setting to be before child * changelog * Fix exposure white flash when enabling SSGI or SSR (#801) * Inform post process that history have been nuked * changelog * Various fixes related to SSGI and RTGI (#803) * Added support to combine RTSSS and RTGI The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting. Fixed an exception happening when using RTSSS without using RTShadows Changing the default SSGI radius for the all configurations Update screenshots for GI scenes * changelog update * [Draft] Lighting/probevolumes cleanup (#756) * Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code * Fix clearing of uninitialized GI * Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different performance / quality tradeoffs. Data pipeline for this seems to be working now (though only properly verified with SH1 at the moment). Next step is to update sampling / evaluation code to handle SH0, and SH2 variants. * Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well. * Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same treatment for AtlasOctahedralDepth. * Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize * Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig * Probe Volumes: Bugfix: DataIsAssigned function needed in build as well. * Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Light loop mode is tooled up to do single evaluation. Material Pass mode still accumulates twice, because SampleBakedGI() is called twice. Need to modify SampleBakedGI() signature to take both normals and internally accumulate front and back lighting. * Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function. * Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions. * Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use. * Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering. * Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, we should remove this unnecessary allocation. * Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 atlas. Upsampling is lossy, but supported, i.e: sample L2 in L0 atlas. Atlas coefficient layout was changed to accomodate this, and ProbeVolumeAccumulate function was moved to its own include so that each order variant can be generated with the preprocessor. * Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include). * Probe Volumes: Fix to ProbeVolumeUI string names * Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention. * Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader * Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in seperate float array. This allows us to always bake and serialize SH2, but conditionally upload only SH0 and SH1 terms if user only requests SH1 atlas. This will also make it easier for SH2 terms to be stripped from the build in the future. * Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and SampleBakedGI. * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart() * Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default. * Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention. * Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest. Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> * update DXR Test project * Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#788) * Allow camera only transparent motion vectors * Changelog * revert old way of doing it. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Made VT settings classes internal rather than private/public (#805) Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> * update test filter * fix shad variables globals after merge * Update ShaderVariablesGlobal.cs.hlsl * Update LightingDebug.cs.hlsl * Fix reflection probe framesettings override (#796) * Fix reflection probe framsettings override * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix artifacts in volumetric lighting near opaque geometry (#493) * Add view bias to volumetrics * Implement geometry-distance-aware volume rendering * Comment * Fix the flickering issue * Clean * Fix * Changelog * Implement lookup bias for volumetrics * Update CHANGELOG.md * update test filter * fix refernce screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed WRITE_NORMAL_BUFFER macro redefinition and generated interpolators in ShadowCaster and META pass (#816) * update reference screenshots * Hdrp/fix/cookie area light update (#828) * Fixed area light cookie not used when a spot cookie is assigned * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode (#827) * Make sure update of dynamic res happens only in game view and not when playing. * changelog * Allow forced res to still be valid while not playing Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix raytracing keyword & static render state leak (#829) * Fix raytracing keyword value * Fix static render state being modified and causing side effects * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow (#823) * specular color needs to be weighted back with the blend factor. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update HDShaderPasses.cs * Add custom post process before TAA injection point (#817) * Added custom post process before TAA injection point * Updated custom pp graphic test * Added before TAA post process in HDRP default settings * Re-enabling the bloom test (#809) * Re-enabling the bloom test * Moving the test at the proper position Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fix depth pyramid issues with dynamic resolution (#806) * Recompute the mip info before generating the mipchain * changelog * avoid compute mipchain if not needed Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix decal being duplicated in prefab isolation mode. (#789) * Fixed decals being duplicated in prefab isolation mode. * Update changelog. * Fix decals in the player. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue where rendering preview with MSAA might generate render graph errors. (#800) * Fixed an issue where rendering preview with MSAA might generate render graph errors. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile issue on PS4 for PlanarReflectionFiltering.compute (#830) * Fix compile issue for PS4. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue * IES Light Support (Point, Spot & Rectangular Lights) (#459) * IES Importe & Generate 2D/Cube/Equirectangular Textues * Enable PreviewGUI for IES Light, Split Core & HDRP * IES Point sampling enable Octahedral * missing file * spaces * for test * Cut of push Yamato generation * Wrong merge: Missing file * Missing file * wip * Octahedral Tilling * Cleaner & introduce IESObject * missing dead code * Allow only Power of 2 textures, update when resize * Clean code, + change log + Area Light * remove useless code * minor update * Merge * Cleanup * Remove useless log * Unify code + cleanup * Update documentation * Disable IES for Directionnal Lights * Fix when we update the spot angle baked * Update documentation & rename UI * com * Fix error for Area/Rectangular lights * Minor typo + move internal (WIP) * minor * minor * fix Pyramid + Box light & Add support of IES for them * Unreachable code fix * fix HDRPTest for Box lights * Add missing public doc * Last missing doc issues - fix * Remove all CGAlloc; Remove IES + Cookie for emissive mesh of area light(+Update doc) * Remove useless code, typo * Update versions in manifests (#647) * update manifests * Update manifest.json * update hdrp runtime [skip ci] * update testing packages [skip ci] * remove unused references * Update reference to support octahedral for animated texture * Update GI Support (HDRP Test valid) * Update image reference * Add migration message for Cookies * Fix message * Typo in light-component.md * Forgot an "and" * Typo in display emissive mesh property * Update documentation to clarify the case for light baking + IES cases * Switch from slider to ComboBox for IES Resolution * Rewording sentence on cookie/ies baking tooltip * Used same sentence from elsewhere for coherence * Fix compilation issue after merge * Update Vulkan reference images * Update OSX Metal reference image for CubeCookie * Formating, type & convention * Formating & code convention * Fix warning message * Update upgrading 2020.1 to 2020.2 doc * Update light loop for fetching * Update Upgrading-from-2020.1-to-2020.2.md * Update Upgrading-from-2020.1-to-2020.2.md * Update LightCookieManager.cs * Update HDRenderPipelineAsset.Migration.cs * Fix DXR Text * Fix Yamato XR * update reference screenshots * update reference screenshots * fix for Yamato OSXEditor/Metal Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> * Revert "Re-enabling the bloom test (#809)" This reverts commit cc9a6498c9213174f27b14d5aa5f081667346d99. * Update reference screenshots for IES * fix shader warning in DepthTAA.shader * Update 2313_Shadow_Mask_Spotlight_Shapes.unity * Update VFX reference screenshots * Update 4060_CustomPostProcess.unity * Update HDSRP_ Test reference screenshots * Update TestCaseFilters.asset * Adding missing references image for HDRP 4038 (#856) * Adding Linux Vulkan, OSX Metal, Win D12, Win Vulkan ref image for 4038 bloom * Win D11 * Fix message for metal and ao (#859) * Add texture import preset to automatically apply to "ActualImages" (#861) * Fix issue with the blue line of prefab modifications for Volume mode (#860) * Fix blueline in prefab mode * changelog * Fixing the internsity being applied to RTAO too early leading to unexpected results (1254626). (#825) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * add color clear pass while rendering XR occlusion mesh to avoid leaks (#688) * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix (#865) * test manual fov computation * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix/shader stack normals (#852) * Fixed normal space in templates * Fix nullref in material inspector * Updated changelog * Added iris and coat normal spaces Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Evgenii <evgenii@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com> Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: RemyUnity <32760367+RemyUnity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some missing doc