Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the upper clamp values for recursive rendering and light cluster size (case 1294620) #2753

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Removed the upper clamp values for recursive rendering and light cluster size (case 1294620) #2753

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca1ab0
- Removed the superior clamping value for the recursive rendering max…
anisunity Nov 26, 2020
9da7c83
minor change
anisunity Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
minor change
  • Loading branch information
@anisunity
anisunity committed Nov 26, 2020
commit 9da7c830c1a4f95fefdb4a2935a3815bc20a29ce
6 changes: 4 additions & 2 deletions ...er-pipelines.high-definition/Editor/RenderPipeline/Raytracing/RecursiveRenderingEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using UnityEngine;
using UnityEditor.Rendering;
using UnityEditor.Rendering.HighDefinition;
using UnityEngine.Rendering.HighDefinition;
using UnityEngine.Rendering;

namespace UnityEditor.Experimental.Rendering.HighDefinition
{
Expand All @@ -26,6 +26,8 @@ public override void OnEnable()
m_MinSmoothness = Unpack(o.Find(x => x.minSmoothness));
}

static public readonly GUIContent k_RayLengthText = EditorGUIUtility.TrTextContent("Max Ray Length", "This defines the maximal travel distance of rays.");

public override void OnInspectorGUI()
{
HDRenderPipelineAsset currentAsset = HDRenderPipeline.currentAsset;
Expand All @@ -47,7 +49,7 @@ public override void OnInspectorGUI()
{
PropertyField(m_LayerMask);
PropertyField(m_MaxDepth);
PropertyField(m_RayLength);
PropertyField(m_RayLength, k_RayLengthText);
PropertyField(m_MinSmoothness);
}
}
Expand Down
1 change: 0 additions & 1 deletion ....render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/RecursiveRendering.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public sealed class RecursiveRendering : VolumeComponent
/// <summary>
/// This defines the maximal travel distance of rays.
/// </summary>
[Tooltip("Max Ray Length. This defines the maximal travel distance of rays.")]
public MinFloatParameter rayLength = new MinFloatParameter(10.0f, 0.0f);

/// <summary>
Expand Down