Fixed SSGI texture allocation with RG disabled #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
anisunity
reviewed
Nov 27, 2020
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
Show resolved
Hide resolved
|
Did you run the DXR tests locally? |
i don't support DXR locally, I can launch yamato but I guess it will be launched on the bugfix branch altogether |
sebastienlagarde
approved these changes
Nov 27, 2020
For this kind of thing, you should indeed run DXr test on yamato, I will do it |
|
good for the test , merging |
Merged
sebastienlagarde
added a commit
that referenced
this pull request
Nov 30, 2020
* Fixed volume component tooltips using the same parameter name (#2754) * Use the proper history info for Bicubic resampling in TAA (#2759) * Use proper info for previous buffer info * changelog * Fixed lookdev movement (#2757) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix issue with saving some quality settings in volume overrides (#2758) * Fix issue with saving some quality settings volume overrides * Fix typo in changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765) * fix issue with confusing text (#2766) * Fixed SSGI texture allocation with RG disabled (#2768) * [HDRP] Fixed max shadow crash (#2760) * Fixed NullReference Exception when setting Max Shadows On Screen to 0 in the HDRP asset * Updated changelog * Fixed nullref again + debug * Initialize shadow request count Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Formatting * Update CHANGELOG.md Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1293020/
SSGI works even if raytracing is not supported
removes if before RTHandles.Release because they are already done inside the function
Testing status
tested the repro steps