Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VFX] Update & Compile all VFX #3476

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Conversation

PaulDemeulenaere
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere commented Feb 12, 2021

Purpose of this PR

  • Fix lost menu entry due to a // in MenuItem path : 858ebaa
    image

  • Update all visual effect asset due to the increment of graph version : avoid any local change in package data

  • Update URP.asset in VFX_URP project to avoid known assetDb instability while building a player : 1e95b3b


Testing status

Yamato only ⏳


Comments to reviewers

N/A

The `//` was causing an untracked issue
m_GraphVersion 6 => 7 + Sanitize VFXCameraBuffer
Avoid instability from `[Assert] On demand scheduler requested to import while stopped`
Remove useless 102_RenderDepth.asset
@PaulDemeulenaere PaulDemeulenaere marked this pull request as ready for review February 12, 2021 11:38
@PaulDemeulenaere PaulDemeulenaere merged commit d540c1a into master Feb 12, 2021
@PaulDemeulenaere PaulDemeulenaere deleted the vfx/fix/update-all-vfx branch February 12, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants