-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Emissive Color Override Debug Display (Case 1313123) #3602
Merged
Merged
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
b9da5fa
Hd/fix 1299116 tesselation cull (#3057)
kecho 5b57f64
Change the source value for the ray tracing frame index iterator from…
anisunity b21345b
[HDRP] Added a RenderGraph pass that resets the camera size after the…
alelievr 9581f38
Fix Light Intensity UI Prefab Override Application (1299563) (#3061)
johnpars 525ebf5
Fix Undo/Redo Stability for Light Temperature (1304176, 1301076) (#3079)
johnpars 8007c48
Fix labels style (#3046)
adrien-de-tocqueville 2df0185
Fixed side effect on styles during compositor rendering. (#3081)
adrien-de-tocqueville bf833ce
[HDRP][Compositor] Fix size and spacing of compositor info boxes (#3101)
pmavridis 7be5e6c
[HDRP][Compositor] Fix color picker UI glitch in the Graphics Composi…
pmavridis 6413dc6
Fix 1299233 ies resize bug (#3094)
skhiat 8998567
filter for xbone addded (#3116)
martint-unity 027cb37
[Yamato] Enable cache server for standalone build jobs (#3106)
sophiaaar 6429445
Fix undo redo on layered lit editor (#3059)
adrien-de-tocqueville d910dc8
Merge branch 'master' into hd/bugfix
sebastienlagarde 9c216c8
[HDRP] Added Vulkan install in system requirements (#3122)
alelievr 8dbde86
[HDRP] Fix issue with compositor related custom passes (#3055)
pmavridis a5a6590
Fixed some render texture leaks. (#3050)
JulienIgnace-Unity 229f3e8
Hd/fix wizard runtime resources (#3123)
RSlysz 0a42f9b
[HDRP] Fixed lookdev reload bug when viewing a scene object (#3108)
alelievr eb1d074
[HDRP] Fix error in Depth Of Field near radius blur calculation (#3131)
pmavridis 22b5b7f
[HDRP] Fix GC allocs (#3136)
pmavridis 8cd8fe6
Revert: Fix 1299233 ies resize bug (#3094)
sebastienlagarde 9bcb75f
Merge branch 'master' into hd/bugfix
sebastienlagarde 31defd2
Merge branch 'master' into hd/bugfix
sebastienlagarde 6dffbc8
Hide light shadow near plane gizmo when shadows are disabled (#3114)
adrien-de-tocqueville 9ba9620
Hd/fix backplate globalcubemap2 (#3111)
JulienIgnace-Unity b4214a4
[HDRP][Path Tracing] Added alpha channel to path traced results (#3127)
eturquin feb0fe0
Doc update (#3160)
JulienIgnace-Unity d315646
Merge branch 'master' into hd/bugfix
sebastienlagarde f9c97c1
Fix various shader warnings (#3158)
FrancescoC-unity 316d6a6
Update Override-Screen-Space-GI.md
sebastienlagarde be8f685
Fixed shadow matte not working with ambient occlusion when MSAA is en…
sebastienlagarde 44ba81f
Merge branch 'master' into hd/bugfix
sebastienlagarde 4de9b07
Update HDLightUI.cs (#3203)
sebastienlagarde 1557004
[HDRP] fix nullref when chaging RP from HDRP to URP (#3191)
alelievr acd6199
fix case 1307653 (#3205)
sebastienlagarde f18d053
Merge branch 'master' into hd/bugfix
sebastienlagarde abd7de7
Fix LookDev env library assignment after leaving playmode. (#3214)
JulienIgnace-Unity 6349ef2
Update Hair Shader Preset Documentation (#3208)
johnpars cace53e
[HDRP] Fix locale diffusion profile shader property value in ShaderGr…
alelievr 760837b
Fix error in the RTHandle scale of Depth Of Field when TAA is enabled…
pmavridis 3f480bd
Reset to current quality settings after preprocess build in HDRP (#3218)
jenniferd-unity 4c7dfb6
Merge branch 'master' into hd/bugfix
sebastienlagarde 3b4b1fb
Have bilinear default (#3223)
FrancescoC-unity a890c49
Merge branch 'master' into hd/bugfix
sebastienlagarde 4477283
Update CHANGELOG.md
sebastienlagarde 3112950
Added missing character to the layered lit document (#3310)
JordanL8 ac55059
Fix needs of exposure for debug display "SSR Transparent" (#3308)
skhiat bc0aa7d
[HDRP] Fix GUI exception in material UI (#3315)
alelievr c34ba38
[HDRP] Update decal angle fade tooltip (#3322)
alelievr 1f827f1
Mention in TAA doc that a certain use case will lead to problems. (#3…
FrancescoC-unity fe86016
Hide shadow resolution value (#3335)
adrien-de-tocqueville 7a6ec1e
Bump timer of 2nd runtime test to make it work on all platforms. (#3…
FrancescoC-unity b84c14b
Fix light frustum planes (#3341)
adrien-de-tocqueville 2cc4b51
Project skybox without perspective for ortho cameras (#2955)
adrien-de-tocqueville 1c9a0ff
Fix non temporal SSAO issues with the rendergraph pass (#3351)
FrancescoC-unity b648896
Merge branch 'master' into hd/bugfix
sebastienlagarde 4338bc4
Reset ambient probe upon switching to very different skies (#3340)
FrancescoC-unity 0c56c5f
Fix white flash on camera cuts with volumetric (#3354)
FrancescoC-unity 43e6d15
Fix issues with light layers issues when editing multiple lights (#3323)
FrancescoC-unity bd1934f
Maximum of reflection distance must be bound by the min of all dimens…
kecho e813067
Fixed debug panel reseting when going through enum items (#3370)
JulienIgnace-Unity 317f976
Fix keywords with fbx importer (#3350)
adrien-de-tocqueville b480510
Fixed lightmaps not working properly with shader graphs in ray traced…
anisunity ff57004
revert: Reset ambient probe upon switching to very different skies (#…
sebastienlagarde 8250779
Merge branch 'master' into hd/bugfix
sebastienlagarde f41f5cf
Hdrp/fix tesselation wireframe (#3355)
kecho ab6fc9e
Adding missing meta from HDRP_test
sebastienlagarde 0923df0
Hd/fix input registering domain reload (#3373)
RSlysz 14bb032
Merge branch 'master' into hd/bugfix
sebastienlagarde 53be5eb
Fix nullref (#3460)
adrien-de-tocqueville 5d7fb34
Merge branch 'master' into hd/bugfix
sebastienlagarde 7655f87
Fix DepthOfField CoC debug view (#3466)
FrancescoC-unity 890195a
Fixed an issue with first frame of ao causing some kind of ghosting e…
JulienIgnace-Unity 78864e9
Fix mipmap generation internal format (#3470)
pmavridis 4402cf2
Change wizard check to be ok with -force api (#3422)
FrancescoC-unity cac2a5a
Merge branch 'master' into hd/bugfix
sebastienlagarde 4ec6ec4
Delete Volumes.meta
sebastienlagarde 24fa85c
revert: Hd/fix input registering domain reload #3373
sebastienlagarde 9160de3
update Vulkan win reference screenshots
sebastienlagarde c11fb81
Merge branch 'master' into hd/bugfix
sebastienlagarde e1d44d1
Fixed performance issue with ShaderGraph and Alpha Test
sebastienlagarde b0aaf41
Fixed dimensionality of a couple vectors (from 3 to 2). (#3395)
eturquin 0ef72d6
Fix error when increasing the maximum planar reflection limit (#3332)
pmavridis 0818713
Updated documentation of RequestRenderNextUpdate (#3368)
fredericv-unity3d 3c893e8
Fix alpha output in AOVs and debug views when using shadow matte (#3593)
pmavridis 57b3f7d
Merge branch 'master' into hd/bugfix
sebastienlagarde 614c7ca
Update the test's Unlit SG graph to connect the map to the emission s…
johnpars 4020182
Enable debug display for forward emissive in deferred pass.
johnpars 078049d
Changelog
johnpars f5a756d
Implement PR feedback
johnpars a08bf7e
Merge branch 'master' into HDRP/case-1313123
sebastienlagarde ed7dea1
Merge branch 'master' into HDRP/case-1313123
sebastienlagarde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Enable debug display for forward emissive in deferred pass.
- Loading branch information
commit 4020182871cc3ad3b9ef953e109a49968026b13a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to decouple the debug display check from
LightingOrMaterial
? Not sure if this new emissive pass qualifies as "lighting or material" (and also, adding it into the LightingOrMaterial check causes other issues).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I will suggest to make thing clearer.
Let's create a
pass.NeedDebugDisplay() (or any better name :)
with
public static bool NeedDebugDisplay(this PassDescriptor pass) =>
return pass.IsLightingOrMaterial() || pass.lightMode == HDShaderPassNames.s_ForwardEmissiveForDeferredStr
At least the purpose of the function is clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!