Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding (refactoring to) Gbuffer optional slot 3 #4528

Merged
merged 96 commits into from
May 20, 2021
Merged

Adding (refactoring to) Gbuffer optional slot 3 #4528

merged 96 commits into from
May 20, 2021

Commits on Feb 26, 2021

  1. enabled MSAA when the RenderPass API is used. Resolving implicitly to… 

    … the color target's resolve surface
    @manuele-bonanno
    manuele-bonanno committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ddbee5f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Initial lazy merging prototype

    @manuele-bonanno
    manuele-bonanno committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    8f7db74 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Lazy merging prototype: all the needed attachments are now added to t… 

    …he RenderPass attachment list. Merging subpasses and attachments which are the same or compatible
    @manuele-bonanno
    manuele-bonanno committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    fe5cadb View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. initial work to add lazy merging to the deferred renderer (doesn't ha… 

    …ndle coorrectly edge cases)
    @manuele-bonanno
    manuele-bonanno committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e50c046 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. MRT attachments merging improvements

    @manuele-bonanno
    manuele-bonanno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    3ba7c7b View commit details
    Browse the repository at this point in the history

  2. fix for a crash because of incomplete Targets setup for merged render… 

    … passes
    @manuele-bonanno
    manuele-bonanno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    b66f183 View commit details
    Browse the repository at this point in the history

  3. change m_ShadowmapWidth/Height variables to use renderTargetWidth

    @jonuuukas
    jonuuukas committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    422ed1b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'universal/render-pass-conversion' of ssh://github.com/U… 

    …nity-Technologies/Graphics into universal/render-pass-conversion
    @jonuuukas
    jonuuukas committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    9bdd3ef View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. m_ActiveRenderPassQueue[i] to var renderPass

    @jonuuukas
    jonuuukas committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    7d3c5ba View commit details
    Browse the repository at this point in the history

  2. changing hash ctor logic to merge width/height and include depth rtID

    @jonuuukas
    jonuuukas committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6f5d3f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. fix setlastpass flag loop

    @jonuuukas
    jonuuukas committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7dc34fa View commit details
    Browse the repository at this point in the history

  2. NativeArray memory leak fix

    @manuele-bonanno
    manuele-bonanno committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    72d51d2 View commit details
    Browse the repository at this point in the history

  3. refactoring to remove duplicated code

    @manuele-bonanno
    manuele-bonanno committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    73d666d View commit details
    Browse the repository at this point in the history

  4. fix non-renderpass passes getting hashes and etc.

    @jonuuukas
    jonuuukas committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d86b828 View commit details
    Browse the repository at this point in the history

  5. more cleaning up, moving RenderPass code in separate functions for cl… 

    …arity
    @manuele-bonanno
    manuele-bonanno committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ac46e52 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. lists to arrays and other gc.alloc related stuff

    @jonuuukas
    jonuuukas committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    bc45166 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'universal/render-pass-conversion' of ssh://github.com/U… 

    …nity-Technologies/Graphics into universal/render-pass-conversion
    @jonuuukas
    jonuuukas committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7b828d8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into universal/render-pass-conversion

    @jonuuukas
    jonuuukas committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    44d350e View commit details
    Browse the repository at this point in the history

  4. merge leftovers

    @jonuuukas
    jonuuukas committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    e57a3ed View commit details
    Browse the repository at this point in the history

  5. moving all the RenderPass API specific code in separate methods as a … 

    …preparation step to move into different files (potentially)
    @manuele-bonanno
    manuele-bonanno committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    432dc6b View commit details
    Browse the repository at this point in the history

  6. remove Configure in SetLastPassFlag

    @jonuuukas
    jonuuukas committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    bf030cb View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. refatoring (in progress): moving all the RenderPass API specific code… 

    … to NativeRenderPassUtils
    @manuele-bonanno
    manuele-bonanno committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f7d061a View commit details
    Browse the repository at this point in the history

  2. fixing depth-only offscreen camera and exposing usesNativeRenderPass

    @jonuuukas
    jonuuukas committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    1b0b6bf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'universal/render-pass-conversion' of ssh://github.com/U… 

    …nity-Technologies/Graphics into universal/render-pass-conversion
    @jonuuukas
    jonuuukas committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    6a6dd1f View commit details
    Browse the repository at this point in the history

  4. merge leftovers

    @jonuuukas
    jonuuukas committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f8a8e62 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. more cleaning up and refactoring

    @manuele-bonanno
    manuele-bonanno committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    d84f779 View commit details
    Browse the repository at this point in the history

  2. splitting initial scene index setup from RenderPass data, and moved R… 

    …enderPass data to the NativeRenderPass class
    @manuele-bonanno
    manuele-bonanno committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ef3e215 View commit details
    Browse the repository at this point in the history

  3. Revert "splitting initial scene index setup from RenderPass data, and… 

    … moved RenderPass data to the NativeRenderPass class"

This reverts commit ef3e215.
    @manuele-bonanno
    manuele-bonanno committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    eb3514d View commit details
    Browse the repository at this point in the history

  4. fix for RenderPass MRT attachments being setup when the RenderPass AP… 

    …I is disabled
    @manuele-bonanno
    manuele-bonanno committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    b89f1e8 View commit details
    Browse the repository at this point in the history

  5. adding profiler samples to NativeRenderPass code

    @jonuuukas
    jonuuukas committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ebd2d04 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. moving more RenderPass related code in NativeRenderPass.cs

    @manuele-bonanno
    manuele-bonanno committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    82d7d6b View commit details
    Browse the repository at this point in the history

  2. removed any direct references to RenderPass frame data outside of Nat… 

    …iveRenderPass
    @manuele-bonanno
    manuele-bonanno committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    304a9ab View commit details
    Browse the repository at this point in the history

  3. fixing targetTexture != null and depthOnly pass cornercase with wrong… 

    … target being picked
    @jonuuukas
    jonuuukas committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    391784c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. NativeRenderPass from static to partial class conversion

    @jonuuukas
    jonuuukas committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    617322d View commit details
    Browse the repository at this point in the history

  2. add RenderPassDescriptor to contain dimensions and etc.

    @jonuuukas
    jonuuukas committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8a00998 View commit details
    Browse the repository at this point in the history

  3. add GetDefaultGraphicsFormat for RenderPass attachment descriptors

    @jonuuukas
    jonuuukas committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    a62901e View commit details
    Browse the repository at this point in the history

  4. remove isFirstMergeable and isLastMergeable and add comments

    @jonuuukas
    jonuuukas committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    bc7a4b8 View commit details
    Browse the repository at this point in the history

  5. moving some stuff and removing some parameters for methods due to par… 

    …tial class impl
    @jonuuukas
    jonuuukas committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2ee17b8 View commit details
    Browse the repository at this point in the history

  6. some more cleanup

    @jonuuukas
    jonuuukas committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    073e77e View commit details
    Browse the repository at this point in the history

  7. more cleanup: making methods non static and reducing the input parame… 

    …ters
    @manuele-bonanno
    manuele-bonanno committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    279d157 View commit details
    Browse the repository at this point in the history

  8. renamed attachmentIndices in m_InputAttachmentIndices

    @manuele-bonanno
    manuele-bonanno committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    c5d86db View commit details
    Browse the repository at this point in the history

  9. more cleanup: removing unnecessary statics

    @manuele-bonanno
    manuele-bonanno committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    f1c6990 View commit details
    Browse the repository at this point in the history

  10. improved subpass merging

    @manuele-bonanno
    manuele-bonanno committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    e2c0ebe View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. more renaming of methods

    @manuele-bonanno
    manuele-bonanno committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    bcc0638 View commit details
    Browse the repository at this point in the history

  2. renaming more stuff for consistency with previous renamings

    @manuele-bonanno
    manuele-bonanno committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    276e7d8 View commit details
    Browse the repository at this point in the history

  3. renderPass MRT clear logic fixed

    @jonuuukas
    jonuuukas committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    eb5be47 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. useDepth always if depthOnly is true

    @jonuuukas
    jonuuukas committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    49506d5 View commit details
    Browse the repository at this point in the history

  2. fixing useDepth not picking up default depth attachment

    @jonuuukas
    jonuuukas committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    6412f03 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. adding SupportsNativeRenderPass to rendererFeatures and adding mechan… 

    …ism to enable/disable it properly
    @jonuuukas
    jonuuukas committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    43fc427 View commit details
    Browse the repository at this point in the history

  2. formatting check fix

    @manuele-bonanno
    manuele-bonanno committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    a3c0d85 View commit details
    Browse the repository at this point in the history

  3. more formatting check fixes...

    @manuele-bonanno
    manuele-bonanno committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    8357b72 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. include cleanup

    @jonuuukas
    jonuuukas committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    8a17123 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into universal/render-pass-conversion

    @jonuuukas
    jonuuukas committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    a4ada9d View commit details
    Browse the repository at this point in the history

  3. add validation check and fallback

    @jonuuukas
    jonuuukas committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    c5c3bc0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. reviewer feedback changes

    @jonuuukas
    jonuuukas committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    00a359a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Merge branch 'master' into universal/render-pass-conversion

    @jonuuukas
    jonuuukas committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    7350695 View commit details
    Browse the repository at this point in the history

  2. merge cleanup

    @jonuuukas
    jonuuukas committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    0e287cb View commit details
    Browse the repository at this point in the history

  3. quick hack to add input attachments

    @jonuuukas
    jonuuukas committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    1d08a1e View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. some more changes for input attachment handling

    @jonuuukas
    jonuuukas committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    700b261 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into universal/render-pass-input

    @jonuuukas
    jonuuukas committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d7ebdf5 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. some changes to fb fetch color attachments, depthTexture switched wit… 

    …h depthAttachment, not final as it doesn't work just yet
    @jonuuukas
    jonuuukas committed May 4, 2021
    Configuration menu
    Copy the full SHA
    0b1b9c4 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. adding _RENDER_PASS_ENABLED keyword and all of the fb fetch logic

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    a69003e View commit details
    Browse the repository at this point in the history

  2. some cleanup regarding non-renderpass depthcopy texture

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    0f48003 View commit details
    Browse the repository at this point in the history

  3. fix non-renderpass path depth

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    716ecd4 View commit details
    Browse the repository at this point in the history

  4. fix deferred fog using fb fetch

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b6b6b75 View commit details
    Browse the repository at this point in the history

  5. adding positionCS to remaining InputData gbuffer related passes and f… 

    …ixing BeginRenderPass errors
    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    0696520 View commit details
    Browse the repository at this point in the history

  6. fix scene view not rendering properly

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    c6c3c50 View commit details
    Browse the repository at this point in the history

  7. more fixes for scene and other cameratypes - disabling renderPass alt… 

    …ogether for all of the pipeline logic
    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    48f0ab7 View commit details
    Browse the repository at this point in the history

  8. exposing Native RenderPass option in the renderer asset

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    df55ba0 View commit details
    Browse the repository at this point in the history

  9. whitespace cleanup

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    60a7198 View commit details
    Browse the repository at this point in the history

  10. some more cleanup and refactoring

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b52f795 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into universal/render-pass-input

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    47f43f6 View commit details
    Browse the repository at this point in the history

  12. formatting fixes

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    92efd45 View commit details
    Browse the repository at this point in the history

  13. GC.Alloc fixes for deferred renderer

    @jonuuukas
    jonuuukas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    f4b78b2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. formatting fixes

    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    be3faeb View commit details
    Browse the repository at this point in the history

  2. Revert "formatting fixes" 

    This reverts commit be3faeb.
    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    5e10778 View commit details
    Browse the repository at this point in the history

  3. retry formatting fixes without other file changes

    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    66844b6 View commit details
    Browse the repository at this point in the history

  4. adding GBUFFER number defines for more clear fb fetch macros

    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d23d5d7 View commit details
    Browse the repository at this point in the history

  5. disabling RenderPass API for SSAO/DepthNormal/Decals

    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    1fc338b View commit details
    Browse the repository at this point in the history

  6. minor MRT attachment clear fix

    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    f544348 View commit details
    Browse the repository at this point in the history

  7. disable input attachments if there is a Depth/Normal pass injected in… 

    …between Gbuffer and defrred passes
    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    514227e View commit details
    Browse the repository at this point in the history

  8. first pass with input attachments changing hard return to warning msg

    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    e78b327 View commit details
    Browse the repository at this point in the history

  9. reverting some changes for rendererFeatures, as they have renderpass … 

    …disable already
    @jonuuukas
    jonuuukas committed May 6, 2021
    Configuration menu
    Copy the full SHA
    86fa4a6 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. some comments and other stuff regarding review feedback

    @jonuuukas
    jonuuukas committed May 7, 2021
    Configuration menu
    Copy the full SHA
    4b745cb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. some depthcopy logic skip for RenderPass Deferred

    @jonuuukas
    jonuuukas committed May 10, 2021
    Configuration menu
    Copy the full SHA
    4be1266 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into universal/render-pass-input

    @jonuuukas
    jonuuukas committed May 10, 2021
    Configuration menu
    Copy the full SHA
    344b9e5 View commit details
    Browse the repository at this point in the history

  3. typo fix

    @jonuuukas
    jonuuukas committed May 10, 2021
    Configuration menu
    Copy the full SHA
    ad80f20 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'universal/render-pass-input' of ssh://github.com/Unity-… 

    …Technologies/Graphics into universal/render-pass-input
    @jonuuukas
    jonuuukas committed May 10, 2021
    Configuration menu
    Copy the full SHA
    496dc12 View commit details
    Browse the repository at this point in the history

  5. LOAD_FRAMEBUFFER_INPUT using same parameter for single channel read

    @jonuuukas
    jonuuukas committed May 10, 2021
    Configuration menu
    Copy the full SHA
    39a2606 View commit details
    Browse the repository at this point in the history

  6. removing clipPos from inputData init

    @jonuuukas
    jonuuukas committed May 10, 2021
    Configuration menu
    Copy the full SHA
    d258506 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. optional slot 3 added to GBuffer

    @jonuuukas
    jonuuukas committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0342131 View commit details
    Browse the repository at this point in the history

  2. additionl _render_pass_enabled check to determine correct type for op… 

    …tional slot
    @jonuuukas
    jonuuukas committed May 11, 2021
    Configuration menu
    Copy the full SHA
    20b5672 View commit details
    Browse the repository at this point in the history

  3. fixing the #ifdef logic a bit for optional slot2

    @jonuuukas
    jonuuukas committed May 11, 2021
    Configuration menu
    Copy the full SHA
    22f3c70 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge branch 'master' into universal/gbuffer-optional-slot3

    @jonuuukas
    jonuuukas committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d8e4d18 View commit details
    Browse the repository at this point in the history

  2. Update DeferredLights.cs

    @jonuuukas
    jonuuukas committed May 13, 2021
    Configuration menu
    Copy the full SHA
    951e56b View commit details
    Browse the repository at this point in the history

  3. Update DeferredLights.cs

    @jonuuukas
    jonuuukas committed May 13, 2021
    Configuration menu
    Copy the full SHA
    513da1f View commit details
    Browse the repository at this point in the history