Fix and re-enable two URP Stereo graphics tests #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n test filters. Update materials.
|
It appears that you made a non-draft PR! |
DennisDeRykeUnity
added
ready-to-merge
sophiaaar
approved these changes
Jun 28, 2021
JarkkoUnity
pushed a commit
that referenced
this pull request
Jun 30, 2021
…n test filters. Update materials. (#4975)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Two Stereo Graphics Tests were failing as described in case 1307744:
https://fogbugz.unity3d.com/f/cases/1307744/
Material updates and explicitly specifying which scene the lighting data pertains to fixed these two tests. This PR re-anables these two tests in the project's test filters.
005_xr_PBS_EnvironmentBRDF_Spheres
010_xr_Shader_PBRvalidation_Specular
Testing status
Since this PR only touches files in TestProjects/UniversalGfxTestStereo so I believe the following green "Universal_Stereo on Win__Standalone_mono_Linear on version trunk" job is sufficient for approval:
https://unity-ci.cds.internal.unity3d.com/job/7403137
Comments to reviewers
Approval by Sophia or Theo should suffice; both need not review.
Whoever first approves this may merge this if they wish -- thanks!
This PR does not pertain to the single-eye-stereo test system. This is the older separate project that runs fewer tests but generates left-eye-right-eye images.