Art Updates to the template #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added lens flares - volumetric clouds - increased blocker sample count for high quality mode - removed ssgi for medium - fixed decals contributing to GI - rebaked lightmaps - added dead leaves
|
It appears that you made a non-draft PR! |
iM0ve
reviewed
Jul 5, 2021
There was a problem hiding this comment.
What's tested:
- Checked changed files and went through them in the scene, looking for unexpected behavior
- Played the level to walk through all rooms
- Previewed all the new functionality added
Conclusion:
No technical issues found. Have a few minor questions related to art @pierre-unity
- I have limited knowledge about flares, but from gaming/movie experience it feels like the lamps in the second room would be too weak to cause a flare? Maybe flares in the 3rd room + sun would be enough?
- In HDRP samples we have a Flare that is dedicated for Sun, called Sun_Flare_w_Ring. We currently use one called Polycount. Both are viable ? Do we want to use the Sun one?
Current
Sun_Flare_w_Ring
Once again Im not asking for changes here, just pointing out what caught my eye. The PR could be merged as is.
|
Looks great, I would vote for the "Sun_Flare_w_Ring" used on the directional light. |
SeanPuller
approved these changes
Jul 5, 2021
sebastienlagarde
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR is meant to update the template with a couple of new features, such as lens flares, volumetric clouds, and fix a few tiny graphics issues.
added lens flares
added volumetric clouds
increased blocker sample count for high-quality mode
removed SSGI from Medium quality
fixed decals contributing to GI (some decals were blocking the light)
rebaked lightmaps
added dead leaves (much-reduced number though, as the count was extremely high and hitting CPU very hard)
Comments to reviewers
Please check with 2021.2 (you might need to wait for beta 4). I have used 2022.1 alpha to do the work, as 2021.2 beta 3 and below are not really useable.