Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDRP] Adding a 004 standalone test with flares, decals, volumetric cloud reflections and MSAA #5096

Merged
merged 17 commits into from
Jul 9, 2021

Conversation

JMargevics
Copy link
Contributor

@JMargevics JMargevics commented Jul 8, 2021

004-CloudsFlaresDecals

Hello, after fixing the remaining issues with wind on MacOS, I'm finally adding a 005 standalone test that covers the following:

  • Volumetric Clouds
  • Flares. Out of screen (on the left) and occluded (behind the statue)
  • MSAA 8x. More precisely how clouds planar reflections play along with MSAA
  • Angle faded decals, both dept biased (left column) and view biased (right column)
  • Shadow matte receiving shadows from the statue
  • Everything reflected in a planar reflection

Yamato green on all platforms.

Also contains a small fix from @johnpars

@JMargevics JMargevics requested review from sebastienlagarde and a team July 8, 2021 05:35
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde changed the title [HDRP] Adding a 005 standalone test with flares, decals, volumetric cloud reflections and MSAA [HDRP] Adding a 004 standalone test with flares, decals, volumetric cloud reflections and MSAA Jul 9, 2021
@sebastienlagarde sebastienlagarde merged commit 0959e93 into master Jul 9, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/tests/volumetric-clouds-msaa-flares branch July 9, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants