Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShaderGraph] [2021.2] Fixing isNan node and re-enabling IsNaN test #5110

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

cdxntchou
Copy link
Contributor

@cdxntchou cdxntchou commented Jul 9, 2021

Purpose of this PR

Change the isNan node to use the isnan() HLSL function.
Re-enabling the disabled IsNan test.
The reason it was disabled was that it was waiting on a platform fix for the isnan function, that has now landed.
https://fogbugz.unity3d.com/f/cases/1300409


Testing status

  • Tested node on PC D3D11 and PC Vulkan -- returns true for nan, false for not-nan.
  • Verified the isNaN test shader was producing isnan() call.
  • Verified the isNaN test shader changes colors depending on the value passed in.
isNaN.mp4

Yamato:

Nightly ShaderGraph: 🟢
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/sg%252Ffix%252Fnan-test2/.yamato%252Fall-shadergraph.yml%2523Nightly_ShaderGraph_2021.2/7599033/job/pipeline


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@cdxntchou cdxntchou changed the title Sg/fix/nan test2 [ShaderGraph] [2021.2] Re-enabling IsNaN test Jul 9, 2021
@cdxntchou cdxntchou changed the title [ShaderGraph] [2021.2] Re-enabling IsNaN test [ShaderGraph] [2021.2] Fixing isNan node and re-enabling IsNaN test Jul 9, 2021
@cdxntchou cdxntchou marked this pull request as ready for review July 9, 2021 14:39
@cdxntchou cdxntchou requested a review from a team as a code owner July 9, 2021 14:39
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdxntchou cdxntchou requested a review from a team July 9, 2021 15:35
@jessebarker jessebarker merged commit 4f36f48 into master Jul 9, 2021
@jessebarker jessebarker deleted the sg/fix/nan-test2 branch July 9, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants