Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2021.2][ShaderGraph] Add BuiltIn Target variant stripping #5204

Merged
merged 4 commits into from
Jul 23, 2021
Merged

[2021.2][ShaderGraph] Add BuiltIn Target variant stripping #5204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43c98eb
Don't set viewDirectionWS for BuiltIn Target.
jessebarker Jul 22, 2021
1b6a755
First pass at shader variant stripping for the BuiltIn Target (fogbug…
jessebarker Jul 22, 2021
e0baa07
Restrict logging to passes which are shader graphs but not SRP passes
jessebarker Jul 22, 2021
24c26ea
Add changelog entry for shader variant stripping
jessebarker Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.shadergraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed ShaderGraph exception when trying to set a texture to "main texture" [1350573].
- Fixed a ShaderGraph issue where Float properties in Integer mode would not be cast properly in graph previews [1330302](https://fogbugz.unity3d.com/f/cases/1330302/)
- Fixed a ShaderGraph issue where hovering over a context block but not its node stack would not bring up the incorrect add menu [1351733](https://fogbugz.unity3d.com/f/cases/1351733/)
- Fixed the BuiltIn Target to perform shader variant stripping [1345580] (https://issuetracker.unity3d.com/product/unity/issues/guid/1345580/)

## [11.0.0] - 2020-10-21

Expand Down
2 changes: 1 addition & 1 deletion ...h/Editor/Generation/Targets/BuiltIn/Editor/ShaderGraph/Templates/SharedCode.template.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ void SurfaceVertexToVaryings(v2f_surf surfVertex, inout Varyings result)
result.positionCS = surfVertex.pos;
$Varyings.positionWS: result.positionWS = surfVertex.worldPos;
$Varyings.normalWS: result.normalWS = surfVertex.worldNormal;
$Varyings.viewDirectionWS: result.viewDirectionWS = surfVertex.viewDir;
// viewDirectionWS is never filled out in the legacy pass' function. Always use the value computed by SRP
// World Tangent isn't an available input on v2f_surf
$Varyings.shadowCoord: result.shadowCoord = surfVertex._ShadowCoord;

Expand Down
Loading