Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal/package samples 2 #5455

Merged
merged 25 commits into from
Sep 17, 2021
Merged

Conversation

Jonasmortensen
Copy link
Contributor

@Jonasmortensen Jonasmortensen commented Aug 27, 2021

Purpose of this PR

With 21.2 comes a lot of new features to URP. These new features should be represented in the package samples so users can quickly interact and play with them.

All samples now also have some kind of movement to make them interesting in play mode.

The existing samples also had some issues that are addressed in this PR (case 1360832).

In the PR the sample has also been renamed from "Teaching Samples" to " URP Package Samples"

So far the samples have supported building them to mobile. This is not longer actively supported. It is still doable but because of the limits of the package sample system its up to the user to setup project settings correctly (this was previously handled badly by sample scripts).

Samples that are added in this iteration:
3D Skybox
image

Blob Shadow
image

Proxy Lighting
image

Paint Splat
image

Sun Flare
image

Lens Flare Showroom
image

Keep Frame
image

Trail Effect
image


Testing status


Comments to reviewers

Should not be tested on mobile as support is deprecated.

To QA: Would be good to get some feedback on the descriptions (both typos and clarity) and of course whether the scenes load and behave as they should.

To Dev: As QA will try the scenes in Editor, I only ask for a review of the code in the .cs files in the PR. Specifically the KeepFramesFeature.cs renderer feature as that code is expected to be looked at by users.

These errors might print on some samples :
image
This is a known issue being handled in another branch (case 1359269)

Some samples might also throw a "is missing renderer features" error. This is caused by the package manager not compiling all scripts before running the check and needs to be fixed by package manager team (they are aware of it)
Error2

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Jonasmortensen Jonasmortensen marked this pull request as ready for review September 7, 2021 08:52
@Jonasmortensen Jonasmortensen requested review from a team as code owners September 7, 2021 08:52
@hdb-unity hdb-unity self-requested a review September 16, 2021 15:27
Copy link
Contributor

@hdb-unity hdb-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA testing complete.

Checked the project imported to a built-in project, and a URP project.

Some actions remaining, these are tracked in the test report and we'll keep discussing those.

No shipstoppers found in testing.

Thanks for the clear and detailed PR description, and images of each new test scene!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants