Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the templates pipelines #5627

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Conversation

theopnv
Copy link
Collaborator

@theopnv theopnv commented Sep 13, 2021

Purpose of this PR

  • Removed the optional pre-pack step from the templates pipelines (slack thread).
    - Added the templates pipelines to the nightly for easier checks (request from Sebastien). EDIT: Undo-ed that until the 13.0.0 packages land into the editor codebase (see comment below).
  • Bumped the universal template to version 13.0.0 to fix the pack jobs.

Testing status

Ran the nightly pipeline,
Saw that it triggered the templates pipeline,
Saw that the pre-pack step was removed from the templates pipeline.
Canceled the nightly, results are not relevant.
Running the templates pipeline alone to confirm that removing the pre-pack step is not an issue.

@theopnv
Copy link
Collaborator Author

theopnv commented Sep 14, 2021

Pipeline is failing because of

 com.unity.render-pipelines.high-definition: Package [com.unity.render-pipelines.high-definition@13.0.0] cannot be found

That's because the 13.0.0 packages have not landed yet in the editor codebase. Unrelated to this PR.

@theopnv theopnv marked this pull request as ready for review September 14, 2021 14:39
@theopnv theopnv requested a review from a team as a code owner September 14, 2021 14:39
@theopnv theopnv merged commit 01254d6 into master Sep 14, 2021
@theopnv theopnv deleted the yamato/templates-pipelines-update branch September 14, 2021 15:14
theopnv added a commit that referenced this pull request Sep 21, 2021
@theopnv theopnv mentioned this pull request Sep 21, 2021
theopnv added a commit that referenced this pull request Sep 21, 2021
@theopnv theopnv mentioned this pull request Sep 21, 2021
theopnv added a commit that referenced this pull request Sep 21, 2021
@theopnv theopnv mentioned this pull request Sep 21, 2021
theopnv pushed a commit that referenced this pull request Sep 21, 2021
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Backport #5721
theopnv pushed a commit that referenced this pull request Sep 21, 2021
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Update ppv2 publish filename
theopnv pushed a commit that referenced this pull request Sep 21, 2021
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Change ppv2 filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants