Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fogbugz # 1355839] Making Flare occlusion radius consistent for directional lights regardless of far plane #5643

Merged
merged 2 commits into from
Sep 16, 2021
Merged

[Fogbugz # 1355839] Making Flare occlusion radius consistent for directional lights regardless of far plane #5643

merged 2 commits into from
Sep 16, 2021

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Sep 13, 2021 •
edited
Loading

Purpose of this PR

Occlusion radius is inconsistent across different values of the far plane. Adding the concept of a projected occlusion radius for directional lights, and using an angular radius of 3.3 degrees as a reference. This value provides also a great tunning point directional lights and will require to retune scenes / tests.

https://fogbugz.unity3d.com/f/cases/1355839/

Testing status

Tried by setting up a directional light with a srp lens flare component.

NOTES

This PR changes the tunnable behaviour of occlusion radius for directional lights, makes it more friendly.

Note to @Unity-Technologies/gfx-qa-hdrp change has been verified by Sean Pauler.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Sep 13, 2021
@kecho kecho marked this pull request as draft September 13, 2021 21:01
@kecho kecho force-pushed the core/occlusion-radius-fix-far-plane branch from 396b6d5 to 54fa746 Compare September 13, 2021 21:04
@SeanPuller SeanPuller self-requested a review September 14, 2021 12:48
SeanPuller
SeanPuller approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@SeanPuller SeanPuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested multiple light types, especially directional.
Tested scene and game view.
Great fix!

@kecho kecho changed the title Making occlusion radius consistent for directional lights, regardless… [Fogbugz # 1355839] Making Flare occlusion radius consistent for directional lights regardless of far plane Sep 14, 2021
@kecho kecho force-pushed the core/occlusion-radius-fix-far-plane branch from 617fa64 to bd7027d Compare September 15, 2021 13:02
@kecho
Copy link
Contributor Author

kecho commented Sep 15, 2021

Tests are passing. Seams like we are only failing on crash at shutdown, unrelated issue.

@kecho kecho marked this pull request as ready for review September 15, 2021 16:19
@kecho kecho requested a review from a team September 16, 2021 13:16
@kecho
Copy link
Contributor Author

kecho commented Sep 16, 2021

Note to @Unity-Technologies/gfx-qa-hdrp change has been verified by Sean Pauler.

@kecho kecho closed this Sep 16, 2021
@kecho kecho reopened this Sep 16, 2021
@kecho kecho requested a review from a team September 16, 2021 13:36
@kecho kecho merged commit 506d2c8 into master Sep 16, 2021
@kecho kecho deleted the core/occlusion-radius-fix-far-plane branch September 16, 2021 13:36
sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021
@kecho @sebastienlagarde
[Fogbugz # 1355839] Making Flare occlusion radius consistent for dire…
0b0fe4a 
…ctional lights regardless of far plane (#5643)

* Making occlusion radius consistent for directional lights, regardless of near/far plane distance.

* Changelog
@SeanPuller SeanPuller mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@SeanPuller SeanPuller SeanPuller approved these changes

@JMargevics JMargevics JMargevics approved these changes

@skhiat skhiat skhiat approved these changes

Assignees
No one assigned
Labels
backported-2021.2 SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kecho @sebastienlagarde @SeanPuller @JMargevics @skhiat