Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all packages to 13.1.0 #5812

Merged
merged 10 commits into from
Sep 30, 2021
Merged

Bump all packages to 13.1.0 #5812

merged 10 commits into from
Sep 30, 2021

Conversation

theopnv
Copy link
Collaborator

@theopnv theopnv commented Sep 27, 2021

Purpose of this PR

  • Bumped SRP packages to 13.1.0
  • Moved some release notes to the new section, as they were added after the commit used for the current vendoring (and therefore correspond to the next vendoring).

Testing status

Package Tests (upm validation): https://unity-ci.cds.internal.unity3d.com/project/902/branch/srp%2Fbump-packages/jobDefinition/.yamato%2F_projectcontext.yml%23all_package_ci_project_trunk

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@theopnv theopnv marked this pull request as ready for review September 27, 2021 15:47
@theopnv theopnv requested review from a team as code owners September 27, 2021 15:47
@github-actions github-actions bot added the sdet label Sep 27, 2021
Copy link
Contributor

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the various remark for 21.2 PR

@theopnv
Copy link
Collaborator Author

theopnv commented Sep 29, 2021


## [13.0.0] - 2021-09-01

Version Updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this one, there is item here

Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some smoke testing - imported all the URP required packages and checked if there are no conflicts/ errors. Works fine

@theopnv theopnv merged commit ef3e51a into master Sep 30, 2021
@theopnv theopnv deleted the srp/bump-packages branch September 30, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants