Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag on all shader #5839

Merged
merged 2 commits into from
Sep 30, 2021
Merged

add tag on all shader #5839

merged 2 commits into from
Sep 30, 2021

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Sep 29, 2021

This PR add missing tag Tags{ "RenderPipeline"="HDRenderPipeline" } on all HDRP shaders. Required to improver cross pipeline project build time

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@alex-vazquez alex-vazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@sebastienlagarde sebastienlagarde marked this pull request as ready for review September 30, 2021 07:28
@sebastienlagarde sebastienlagarde merged commit 46a8977 into master Sep 30, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/tag-shaders branch September 30, 2021 07:28
sebastienlagarde added a commit that referenced this pull request Sep 30, 2021
* add tag on all shader

* fix compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants