-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors #6153
Merged
sebastienlagarde
merged 4 commits into
master
from
hdrp-template-bumpup-iet-framework-version
Nov 24, 2021
Merged
HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors #6153
sebastienlagarde
merged 4 commits into
master
from
hdrp-template-bumpup-iet-framework-version
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-unity
changed the title
HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors
[not ready] HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors
Oct 27, 2021
Side note, we had #6134 land the other day to bump the IET package version to address a bug, but it did not include the other fixes for default layout included in this PR |
sebastienlagarde
approved these changes
Nov 4, 2021
kecho
approved these changes
Nov 5, 2021
sebastienlagarde
deleted the
hdrp-template-bumpup-iet-framework-version
branch
November 24, 2021 17:49
sebastienlagarde
changed the title
[not ready] HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors
HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors
Nov 24, 2021
sebastienlagarde
restored the
hdrp-template-bumpup-iet-framework-version
branch
November 24, 2021 18:22
Note: PR have been reverted, shouldn't have been merge |
sebastienlagarde
added a commit
that referenced
this pull request
Dec 8, 2021
….1 and better default layout for 1080p monitors (#6153) * bumped up iet framework to 2.1, created new 1080p and 4k friendly layout * Merge branch 'master' into hdrp-template-bumpup-iet-framework-version Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Dec 8, 2021
* Fixed references to probes not cleared when unloading a scene #5945 * [Fogbugz # 1365368] Fixing debug views for drs #5948 * [HDRP] Stacklit RTR: Fix issues with RTR reflections from stacklit materials #6103 * [HDRP] Lit coat ssr-rtr: Fix various issues with using SSR lighting with IBL fallback (case 1380351) #6106 * [HDRP] StackLit coat ssr-rtr light hierarchy and IBL fallback fixes. #6107 * AxF ssr-rtr: Implement refined light reflection hierarchy with separate weight for coat and base lobe to correctly fallback from SSR light to light reflection probes and also implement the same coat-traced light "reuse" as Lit for bottom lobe when roughnesses are similar. (#6108) This also cleans up the overlapping contributing reflection probes / dual normal setup problem in EvaluateBSDF_Env(). Based on previously discussed #4968. * Fix issue with reflection probe normalization via APV (#6140) * fix issue * - * [not ready] HDRP Scene Template: Bumped up IET framework version to 2.1 and better default layout for 1080p monitors (#6153) * bumped up iet framework to 2.1, created new 1080p and 4k friendly layout * Merge branch 'master' into hdrp-template-bumpup-iet-framework-version Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix custom pass utils in XR #6271 * Update reference screenshots Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR is needed so that the IET framework used by the HDRP scene template can be on its latest production-ready version, that is 2.1, instead of the current 2.0.
This PR also ensures that the tutorial panel looks fine at 1080p and 4k resolution:
1080p:
4K:
Comments to reviewers
Please test that the