Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables per node includes on the DecalPass.template #6245

Merged

Conversation

Jonasmortensen
Copy link
Contributor

This line is also in the ShaderPass.template used by the other URP targets.

Without it, custom function nodes referencing a file cannot be used with the decal target.
The PR also fixes procedural shadergraph nodes (like simple noise) not compiling when used with the decal target. Reason being that the required include was not being included.

This is necasary for custom functions and some other nodes
@Jonasmortensen Jonasmortensen marked this pull request as ready for review November 8, 2021 12:18
@Jonasmortensen Jonasmortensen requested review from a team as code owners November 8, 2021 12:18
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Jonasmortensen Jonasmortensen changed the title Adds a line to the DecalPass.template that enables per node includes. Enables per node includes on the DecalPass.template Nov 8, 2021
@Jonasmortensen Jonasmortensen changed the base branch from master to universal/staging November 8, 2021 13:37
@Jonasmortensen Jonasmortensen requested review from a team as code owners November 8, 2021 13:37
@Jonasmortensen Jonasmortensen changed the base branch from universal/staging to master November 8, 2021 13:39
@Jonasmortensen Jonasmortensen removed request for a team November 8, 2021 13:39
@Jonasmortensen Jonasmortensen changed the base branch from master to universal/staging November 8, 2021 13:40
@Jonasmortensen Jonasmortensen changed the base branch from universal/staging to master November 8, 2021 13:41
@phi-lira phi-lira changed the base branch from master to universal/staging November 10, 2021 09:23
@phi-lira phi-lira merged commit 0344aee into universal/staging Nov 10, 2021
@phi-lira phi-lira deleted the universal/bugfix/missing-includes-in-decal-target branch November 10, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants