Avoid having screen space overlays being rendered by the camera when HDR is off #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix AxF debug output in certain configurations. * Update comment
* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add info on info box * Clarify a bit better
* Avoided unnecessary ambient probe updates Updated doc with dynamic ambient probe limitations * Update Environment-Lighting.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
#5882) * Fix issue when changing volume profiles in runtime with a script * Add new kine in changelog * Improve comment * Changelog typo Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Enable debug symbols * tentative * test using cos from cpu * Finalize fix * Missing file * Remove debug symbols.
This reverts commit a34f336.
FrancescoC-unity
requested review from
alelievr,
sebastienlagarde and
a team
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
alelievr
approved these changes
Nov 17, 2021
sebastienlagarde
approved these changes
Nov 25, 2021
|
For Qa: Merging this fix as there is no much to test outside of what Francesco test already |
sebastienlagarde
deleted the
HDRP/screen-space-overlay-standard-behaviour
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for: https://fogbugz.unity3d.com/f/cases/1380194/
For HDR we need to have it drawn by camera (or well.. we could if we accept something fairly slow, so we'll first wait to see if we get complaints), but we can revert the whatever the pipeline used to do before for non HDR cases.
I will add an entry in the HDR docs that are currently under review to specify this behaviour in HDR.
What did I test: I used renderdoc :P But can check having no camera and UI, and see that it will render now and won't before (or in HDR mode)