-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2021.2][RenderPass] Depth, Normals, Decals fixes #6354
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
This reverts commit f24490a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The developer has already ran RenderPass suites.
In addition, I have also ran Winter project with RenderPass enabled to check any regressions.
Tested device:
MacBook Pro (16-inch, 2021), CPU: Apple M1 Max, Memory: 64 GB, macOS: Monterey 12.0
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
This PR backports some fixes from this PR
This includes:
Testing status
Manually ran all of the tests suites with RenderPass enabled on all of the Renderers inside them
Comments to reviewers
Notes for the reviewers you have assigned.