Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2021.2][RenderPass] Depth, Normals, Decals fixes #6354

Merged
merged 12 commits into from
Feb 18, 2022

Conversation

jonuuukas
Copy link
Contributor

@jonuuukas jonuuukas commented Nov 22, 2021


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


This PR backports some fixes from this PR

This includes:

  • Fixing Input attachments on Metal Editor
  • Enable RenderPass on some Decal techniques and fixed DBuffer to render properly if UseRenderPass is enabled
  • Disabled RenderPass on DepthOnly pass
  • Backporting some of the API to control Transient Input Attachments to fix DepthNormals pass (as currently if Input is used - all of the attachments will be transient and we need to disable that for GBuffer2 when DepthNormals are used)

Testing status

Manually ran all of the tests suites with RenderPass enabled on all of the Renderers inside them


Comments to reviewers

Notes for the reviewers you have assigned.

@jonuuukas jonuuukas requested review from a team as code owners November 22, 2021 11:15
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%2F_abv.yml%23all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@jonuuukas jonuuukas changed the title 2021.2/render pass fixes [2021.2][RenderPass] Depth, Normals, Decals fixes Nov 22, 2021
Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The developer has already ran RenderPass suites.
In addition, I have also ran Winter project with RenderPass enabled to check any regressions.

Tested device:
MacBook Pro (16-inch, 2021), CPU: Apple M1 Max, Memory: 64 GB, macOS: Monterey 12.0

@phi-lira phi-lira merged commit d3212b4 into 2021.2/staging Feb 18, 2022
@phi-lira phi-lira deleted the 2021.2/render-pass-fixes branch February 18, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants