Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IET Updates (version bump, 1080p Layout fix, fixed typo) #6411

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

pierre-unity
Copy link
Contributor

@pierre-unity pierre-unity commented Nov 26, 2021

Purpose of this PR

  • Upgrade to IET framework version 2.1.1 (was 2.1)
  • Fixed typo in Volume tutorial
  • Fixed 1080p layout issue (too narrow panel)
  • Improved a link leading to doc (using #)
  • Fixed unnecessary indentation for Fog section

1080p:
image

4K:
image

Comments to reviewers

Test that the layout looks fine at 1080p and 4K

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Nov 26, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@pierre-unity pierre-unity changed the title IET Updates (version bump, 1080p Layout fix, fixed typo) [Ready for Merge] IET Updates (version bump, 1080p Layout fix, fixed typo) Nov 26, 2021
@pierre-unity pierre-unity changed the title [Ready for Merge] IET Updates (version bump, 1080p Layout fix, fixed typo) IET Updates (version bump, 1080p Layout fix, fixed typo) Nov 26, 2021
Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good with a few small nit picks:

  • Materials Bush_01_Mat and Fern_01_Mat have their height map amplitude changed from 0.01 to 0.02. But in the scene they're not using any height map so I dont see any difference. Was this an intentional change or maybe something with upgrade system? Does it have some effect and I missed it? Do we want to revert these files if its accidental? We could merge as is, just want to understand.
  • Its not introduced with this PR, but maybe we could also change the indentation of the tutorial Volumetric Fog tutorial with this PR?

Volumetric fog
Screenshot 2021-11-29 at 14 18 58

General result(good)
Screenshot 2021-11-29 at 13 59 24

We could merge as is but we can consider the optional fixes

@pierre-unity
Copy link
Contributor Author

Its good with a few small nit picks:

  • Materials Bush_01_Mat and Fern_01_Mat have their height map amplitude changed from 0.01 to 0.02. But in the scene they're not using any height map so I dont see any difference. Was this an intentional change or maybe something with upgrade system? Does it have some effect and I missed it? Do we want to revert these files if its accidental? We could merge as is, just want to understand.
  • Its not introduced with this PR, but maybe we could also change the indentation of the tutorial Volumetric Fog tutorial with this PR?

Volumetric fog Screenshot 2021-11-29 at 14 18 58

General result(good) Screenshot 2021-11-29 at 13 59 24

We could merge as is but we can consider the optional fixes

Thanks, I've now fixed the indentation issue. For the 0.02 amplitude, I'll leave it as it is for the template, as it doesn't alter visuals.

@sebastienlagarde sebastienlagarde merged commit 0c5b28b into master Dec 3, 2021
@sebastienlagarde sebastienlagarde deleted the hdrp-template-IET-updates branch December 3, 2021 17:48
sebastienlagarde pushed a commit that referenced this pull request Dec 9, 2021
* fixed typo, bumped up IET to 2.1.1, cleaning

* fixed unwanted line returns

* removed unnecessary leading space
sebastienlagarde pushed a commit that referenced this pull request Dec 10, 2021
* fixed typo, bumped up IET to 2.1.1, cleaning

* fixed unwanted line returns

* removed unnecessary leading space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants