-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IET Updates (version bump, 1080p Layout fix, fixed typo) #6411
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its good with a few small nit picks:
- Materials Bush_01_Mat and Fern_01_Mat have their height map amplitude changed from 0.01 to 0.02. But in the scene they're not using any height map so I dont see any difference. Was this an intentional change or maybe something with upgrade system? Does it have some effect and I missed it? Do we want to revert these files if its accidental? We could merge as is, just want to understand.
- Its not introduced with this PR, but maybe we could also change the indentation of the tutorial Volumetric Fog tutorial with this PR?
We could merge as is but we can consider the optional fixes
Thanks, I've now fixed the indentation issue. For the 0.02 amplitude, I'll leave it as it is for the template, as it doesn't alter visuals. |
* fixed typo, bumped up IET to 2.1.1, cleaning * fixed unwanted line returns * removed unnecessary leading space
* fixed typo, bumped up IET to 2.1.1, cleaning * fixed unwanted line returns * removed unnecessary leading space
Purpose of this PR
1080p:
4K:
Comments to reviewers
Test that the layout looks fine at 1080p and 4K