Enable state was not taken into account when pasting a Block

[julienamsellem]

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1315482/

Copy paste or duplicate a block in a context would ignore the disable state.

---

Testing status

Tested:

• copy paste disabled block with CTRL+C / CTRL+V
• copy paste disabled block with context menu commands
• duplicate with CTRL+D
• duplicate with context menu commands
• enabled blocks still works like before

---

Comments to reviewers

This is one liner fix, very low risk 😀

[github-actions]

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

[VladNeykov]

Thanks for the fix and for the testing status!
Tried a few other bits including undo/redo of the operations you already listed and it's looking good.

I did however find an issue which does not reproduce in master - creating subgraph blocks sets all blocks in the subgraph to be disabled. In master, the issue before was that all blocks are enabled, even if some were disabled when creating the subgraph (maybe that's something we can improve on?)

Here is the all blocks disabled issue particular to this branch:

This is accompanied with a console error when the block is opened (though the error itself also reproduces in master):
An infinite import loop has been detected. The following Assets were imported multiple times, but no changes to them have been detected. Please check if any custom code is trying to import them: Assets/ccc.vfxblock - (Force Reimport)(modified date 2021-12-11T12:39:35.1240259Z) Assets/New VFX.vfx - (Force Reimport)(modified date 2021-09-10T18:21:23.295811Z)

[julienamsellem]

Thanks for the finding, it should be fixed with this commit 5c3ad9b

[VladNeykov]

Thanks for the fix; looking solid!

Tested:
Copy/duplicate via right click or keyboard shortcuts on:

• blocks, subgraph blocks
• between different contexts, systems, and VFX assets
• within blocks
• from blocks (copy) to VFX contexts (paste)
• copying/duplicating/creating subgraphs from selections containing disabled and enabled blocks
• undo/redo on all of the above

[PaulDemeulenaere]

Looks good to me but you can probably update the change log to track this resolution.
Thanks 🟢