-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed output add button could become invisible #6660
Fixed output add button could become invisible #6660
Conversation
This can happen when the scrollview is too small and the horizontal scrollbar is not at the right most position
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved on 2021.2.0a15 (37767e16dc73)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approving as the fix is cosmetic and been already verified by Julien and Marie. Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is a workaround from the GraphView behavior, offsetting the button position according to the scroller cursor. Only cosmetic, the risk is pretty low.
LGTM. Thanks for the fix.
* [Hack] Fixed output add button could become invisible This can happen when the scrollview is too small and the horizontal scrollbar is not at the right most position * Fixed an issue when there's no output category in the blackboard * Fixed formatting issue * Updated changelog
* [Hack] Fixed output add button could become invisible This can happen when the scrollview is too small and the horizontal scrollbar is not at the right most position * Fixed an issue when there's no output category in the blackboard * Fixed formatting issue * Updated changelog
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1389927/
In a VFX subgraph, the output add button (+) in the blackboard can become invisible when the output category has a visible scrollbar.
[Before]
[After]
Testing status
Comments to reviewers
The original issue is rather in the scope of GraphView because the same issue happens in ShaderGraph.
But since there's no more development on GraphView I fixed it specifically for VFX (the fix is a hack ...)