Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some operators where not visible in node searcher #6662

Merged
merged 5 commits into from
Jan 11, 2022
Merged

Some operators where not visible in node searcher #6662

merged 5 commits into from
Jan 11, 2022

Conversation

julienamsellem
Copy link
Contributor

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1390149/

Some operators where missing from the node searcher when dragging a connection from a port in a context.

Steps to reproduce

  • Create a default VFX Graph and open it
  • In the Output Particle Quad context, drag from the color port in the "Set Color over Life " block
  • You should see Operator=>Inline=>Gradient
    => But the operator is missing

[Before]
gh8BGeJgDT

[After]
6rMFzcdREF

Testing status

Tested with Set Color over Life and Set Size over Life

@julienamsellem
Some operators where not visible in node searcher
0e027ed 
because now that they are not sync anymore at loading time we were missing ports.
Now, the sync is done only when needed (only once anyway)
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@VitaVFX VitaVFX requested review from VitaVFX and removed request for a team December 23, 2021 19:44
@VitaVFX
Copy link

VitaVFX commented Dec 23, 2021

For testing used AllBlocksNodes.vfx
image

Testing dragging form block or node and and looked for a matching operators/ confirmed there are no empty search:

  1. Checked all possible types (gradient, animation curve, camera, shape, space types, texture types, camera)
  2. Blocks with various Compositions (Blend, Overwrite, Add, Multiply)
  3. Also observed that empty search was specifically present with:
    - Angle blocks
    - Shape blocks
    - Bounds (IIRC)
    - Attribute Map
    - Signed Distance Field
    These now look good, Search display possible operators
  4. Checked dragging from contexts to make sure things are good
  5. Tried changing type lets say from curve to vector and then dragging an edge. Search display matching type of the operator

@julienamsellem julienamsellem marked this pull request as ready for review January 3, 2022 12:31
MarieGuff
MarieGuff approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@MarieGuff MarieGuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good
tested on 2022.2.0a1_2dd09014126d

PaulDemeulenaere
PaulDemeulenaere reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, I've a just a question about a potential unexpected change.
Tested locally as well.
_tested_missing_inline

com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXDataAnchor.cs Show resolved Hide resolved
com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXDataAnchor.cs Outdated Show resolved Hide resolved
PaulDemeulenaere
PaulDemeulenaere approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked applied changed at 9d45d9d
Thanks 🟢

@julienamsellem julienamsellem merged commit bfe1e9b into master Jan 11, 2022
@julienamsellem julienamsellem deleted the vfx/fix/1390149-missing-operator-drag-from-port branch January 11, 2022 13:10
julienf-unity pushed a commit that referenced this pull request Jan 13, 2022
@julienamsellem @julienf-unity
Some operators where not visible in node searcher (#6662)
a8f3b2c 
* Some operators where not visible in node searcher

because now that they are not sync anymore at loading time we were missing ports.
Now, the sync is done only when needed (only once anyway)

* Update changelog

* Applied code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulDemeulenaere PaulDemeulenaere PaulDemeulenaere approved these changes

@VitaVFX VitaVFX VitaVFX approved these changes

@MarieGuff MarieGuff MarieGuff approved these changes

Assignees
No one assigned
Labels
backported-2022.1 vfx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienamsellem @VitaVFX @PaulDemeulenaere @MarieGuff