Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Editor Issue for LiftGammeGain and ShadowsMidtonesHighlights #6813

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

johnpars
Copy link
Contributor

Purpose of this PR

There was a small issue that popped up with the trackball UI utility, where a material was being created in a static constructor.

Case: https://fogbugz.unity3d.com/f/cases/1392513/

I'm targeting the PR against master (instead of hd/bugfix) since I believe there was a recent change to the volume system that made this static constructor initialization an issue, so a backport should not be necessary.

This PR fixes the issue by moving the material's initialization from static constructor to its first use.


Testing status

I manually verified that adding these two volume components works again, and double checked that the new material initialization approach works as intended.


Comments to reviewers

~

@johnpars johnpars requested review from sebastienlagarde and a team January 24, 2022 15:40
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Jan 24, 2022
Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked that no other post processing override used these trackball. ✔️

@sebastienlagarde sebastienlagarde merged commit 4362bab into master Feb 2, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-1392513 branch February 2, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants