Check if a path is a folder before trying to import vfx #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a unit test
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
julienf-unity
approved these changes
Feb 1, 2022
Added two unit tests
|
Did not spot errors or any other obscure behavior, thanks for the fix! Test results:Windows:
MacOS:
|
VitaVFX
approved these changes
Feb 2, 2022
julienf-unity
approved these changes
Feb 2, 2022
julienf-unity
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Check if a path is a folder before trying to import vfx Also added a unit test * Updated changelog * Removed redundant test Added two unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1385206/
When naming a folder with a "vfx" extension the vfx post processor was failing on macOS.
Testing status
No change on Windows since the issue only appears on Mac.
Comments to reviewers
I added a unit test so that it can be catch on macOS build machines.