Use context label in inspector when available #7004
Conversation
Also prevent context label from overlapping when empty Added label in inspector for spawning context Set the output mesh label in the same color as its border like other outputs
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
com.unity.visualeffectgraph/Editor/Inspector/VFXContextEditor.cs
Outdated
Show resolved
Hide resolved
Should we consider implementing character limit?
When in Edit mode text is duplicated (observe that we can see green and white letters
Let's move Update name in top of the Inspector?
Green: It seems that multi lines are being displayed in Output Order. Maybe is it worth only to show the first one? |
Prevent context label from shifting when entering in edit mode Limit label length to 175 characters and limit height to 5 visible lines In the inspector, display labels on a single line even if there are line breaks In the inspector, move update label to the top
julienamsellem
deleted the
vfx/fix/1363908-output-context-name-inspector
branch
* Use context label in inspector when available Also prevent context label from overlapping when empty Added label in inspector for spawning context Set the output mesh label in the same color as its border like other outputs * Added missing context types to display lable in inspector * Updated changelog * Avoid context label to change color when hovering (it's not an interactive element) * Fixed formatiing issue * Cleaned up using * Hide context label while editing Prevent context label from shifting when entering in edit mode Limit label length to 175 characters and limit height to 5 visible lines In the inspector, display labels on a single line even if there are line breaks In the inspector, move update label to the top
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1363908/
OutputParticle contexts show a default letter in the inspector (A, B, C ...) but even when the user give a label to those contexts, the same letter remains.
[Before]
[After]
For the sake of consistency I also managed to display this label in the inspector for all kind of context
💡 Notice the label in the inspector has the same color has context borders in the graph so it's even easier to identify what kind of context is selected.
The label element was also overlapping other elements and was not easy to discover. So it's not overlapping anymore.
[Before]
[After]
💡 I added a tooltip so that it's more obvious it can be edited and how to do it
And one last minor improvement is for the
Mesh Outputlabel which color did not match the context borders[Before]
[After]
Testing status
Tested most of the context types.
Add a label, remove it.