HDRP Template: new material sphere and various art fixes #7114
Conversation
…shadows, updated cutscene
|
It appears that you made a non-draft PR! |
|
@pierre-unity please could you separate the change on the resources inside the hdrp package from the change of the template in differente PR? This week we are proceeeding to the move to private repo and your PR could be problematic, need to split it. |
|
Thanks, I'll do this today ASAP. @sebastienlagarde Very odd these changes in the global resources btw (volume profiles), I thought it was part of the upgrade process, that's why I pushed them (I only inspected these files, they must have changed automatically). I'll also update the tutorial to reflect the changes to the default global volume. Thanks @iM0ve. |
|
I've reverted the change to non-template files. I've also reverted the change to the global profile, and therefore the tutorial is working as expected again. Ready to merge. |
pierre-unity
dismissed
iM0ve’s stale review
Thank you, the change to the global volume profile has been reverted.
There was a problem hiding this comment.
The RP can land. I have found some issues that we might want to address later regarding the template but they are not introduced by this change.
What's tested:
- Scene visual with the new changes
- Some bits of tutorial
- Entering playmode
- Launching cinematics
- Creating new scenes
Issues:
-
Entering playmode results in "missing scripts" warnings
-
Creating new indoor scene results in an overly bright image. Caused by volumetric clouds.
-
Small suggestion to make it easier to use cinematics. Both parent object (Media) and child object (Cinematic timeline) are disabled. Users need to check 2 checboxes to see the cinematic, I would suggest to enable the child and keep partent disabled so its easier to access. TLDR check the checbox in the image
sebastienlagarde
deleted the
hdrp-template-new-material-sphere-and-fixes
branch
* added new material sphere, tuned contact shadows, and overall shadowing quality * recaptured all reflection probes, removed srgb on detail maps, tuned shadows, updated cutscene * medium quality by default * slightly tuned exposure transition in corridor to room3 * fixed bad normal on metal trims * reverted changes to default volume profiles * reassigned default volume profile to level to avoid issues with tutorial * swapped new material ball for the new one in core resources to avoid duplicate
Purpose of this PR
Added new material sphere in Room 1 and 3, removed previous one, and updated cinematic as a result
Removed sRGB flag on all detail maps, and tuned corresponding materials to compensate for visual change (very minor change)
Tuned shadows (cascades, contact shadows, directional light biases) to maximize quality on the new material sphere, at both Medium and High quality
Fixed bad normals on metal trims in room 3
Comments to reviewers
Very minor changes, mostly artistic related.