Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URP] Fixed VFX yflip regression #7169

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Conversation

thomas-zeng
Copy link
Contributor

@thomas-zeng thomas-zeng commented Feb 16, 2022


Purpose of this PR


Testing status

  • ABV

Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@thomas-zeng thomas-zeng marked this pull request as ready for review February 16, 2022 22:33
@thomas-zeng thomas-zeng requested a review from a team as a code owner February 16, 2022 22:33
@thomas-zeng
Copy link
Contributor Author

VFX is passing with the fix: https://unity-ci.cds.internal.unity3d.com/job/11707007/dependency-graph
Yamato still has me red in postpro tests. I kicked off re-run and I believe failures are not related to the PR change(same failure happens in master couple days ago see: https://unity-ci.cds.internal.unity3d.com/job/11646510).
Still need to look into other failures

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm, this job is 🟢
Thanks for the fix!

@thomas-zeng
Copy link
Contributor Author

postpro tests and missing doc test are the tests failing. Failures are not related to the PR change as the same failure could be observed in master branch yamato test.

@thomas-zeng thomas-zeng merged commit 61c4147 into master Feb 17, 2022
@thomas-zeng thomas-zeng deleted the universal/xr/fix-yflip-regression branch February 17, 2022 18:21
unity-emilk pushed a commit that referenced this pull request Apr 29, 2022
…y issue

This PR backports 
[URP] Fixed VFX yflip regression 
#7169
[URP] Add intermediate texture mode back without changing the old behavior for compatibility purpose. 
#7077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants