Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable old gitattributes (Fix ppv2 tests) #7408

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

theopnv
Copy link
Collaborator

@theopnv theopnv commented May 6, 2022

Purpose of this PR

Fix PPV2 tests by overriding the new .gitattributes file (in some folders only), imported from our internal mirroring.
This PR introduces several "children" .gitattributes in the folders whose source of truth is still the graphics repository.
This fixes the LFS issues that can occur when cloning the repo and running the tests:

[02:15:50.189 Information] error: Could not create asset from Packages/com.unity.postprocessing/PostProcessing/Textures/BlueNoise64px/LDR_LLL1_60.png: File could not be read

We have to fix this by introducing children gitattributes as we can't edit the main gitattributes file (else it will be overridden by the next mirroring).


Testing status

🔴 Master: https://unity-ci.cds.internal.unity3d.com/job/13579605/dependency-graph
🟢 VS branch: https://unity-ci.cds.internal.unity3d.com/job/13595180/dependency-graph

@theopnv theopnv requested a review from a team as a code owner May 6, 2022 14:01
@github-actions
Copy link

github-actions bot commented May 6, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@theopnv
Copy link
Collaborator Author

theopnv commented May 6, 2022

The formatting job is expected to fail in the graphics repo until it has a higher repoconfig version than the internal source of truth (see thread).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant