Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/master #7521

Merged
merged 39 commits into from
Jun 30, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
b0b760e
[YAMATO][HDRP] Divided HDRP playmode test run time by two.
JulienIgnace-Unity Jun 15, 2022
e55505a
New iteration on the water system.
anisunity Jun 15, 2022
b9601b7
[RND-175][URP-964] SSAO Improvements
ellioman Jun 15, 2022
db55fe7
MTT-1785 Marked player settings BuildTargetGroup API as obsolete
cdmazom Jun 15, 2022
62cc093
[URP] Render Graph hotfixes (v2)
jonuuukas Jun 15, 2022
955a832
[URP][2D] Fix vertex color for Sprite Shapes in default URP shaders a…
kennytann Jun 22, 2022
883dd15
[HDRP] Updates to Diffusion profiles handling
adrien-de-tocqueville Jun 22, 2022
61df766
[URP][2D] Fix bug where render target is incorrect when post process …
kennytann Jun 22, 2022
0b1571d
Rendering Layers
lukaschod Jun 22, 2022
a5d317d
Deprecated DrawX commands on the SRPContext + Updated URP&HDRP (v2)
debaetsd Jun 22, 2022
f529672
Changed ACES luminance fit to allow pure whites
sebastienlagarde Jun 22, 2022
e76b183
URP Automatic Alpha-To-Coverage Regression Fixes
gmitrano-unity Jun 22, 2022
46f4136
[URP] Depth Priming + DepthNormalsPass + MSAA fix
manuele-bonanno Jun 22, 2022
6c4197e
Significant improvements to TAA ghosting, added control for jitter sc…
FrancescoC-unity Jun 22, 2022
3b27c69
[Fogbugz 1375978, 1413534] Fixed pb dof artifacts
pmavridis Jun 22, 2022
5e9057a
[VFX] Update Cube Mesh Test
PaulDemeulenaere Jun 22, 2022
e454c59
[Fogbugz # 1423890] Virtual Texturing feedback support feedback for t…
kecho Jun 22, 2022
180c3cf
Fix incorrect use of half for lighting attenuation.
eh-unity Jun 28, 2022
7529e50
[URP] Fixing broken Foundation tests on iPhone
ellioman Jun 28, 2022
f3de423
Add debug view for Motion Vector Intensities
FrancescoC-unity Jun 28, 2022
e26054d
[HDRP] Fix compile error on certain platforms that load the denoising…
pmavridis Jun 28, 2022
fdfd800
[URP] MSAA Swapbuffer fix for Post-processing (v2)
jonuuukas Jun 28, 2022
c38dda0
[23.1][URP][2D] Fix Light2D upgrading issue with m_AlphaBlendOnOverla…
kennytann Jun 28, 2022
82c5374
Fix explicit precision texture declaration macros to emit Texture2D<h…
joravainen Jun 28, 2022
ddf46a2
[URP] Moving the Render Graph toggle from Global Settings to the URP …
manuele-bonanno Jun 28, 2022
24102a0
Public Api doc improvements for URP, 2D URP and Core
ellioman Jun 28, 2022
3a97459
Add Apple Silicon reference images for URP test projects
theopnv Jun 28, 2022
aee83ab
[HDRP] bunch of bug fixes for HDRP (version 5)
sebastienlagarde Jun 28, 2022
1f501a7
Bump graphics packages to 15.0.0
theopnv Jun 28, 2022
76a5e5a
Fix HDRP Yamato issues
sebastienlagarde Jun 28, 2022
d8e5463
[HDRP] quality Review HDRP doc by doc team - 2 - bis
sebastienlagarde Jun 28, 2022
f26d188
[URP] PostPro project: Adding a #if check for XRSettings conditional …
ellioman Jun 28, 2022
7ba7cdf
[VFX] Fix MotionVector with TargetOffset
PaulDemeulenaere Jun 28, 2022
8eb03c2
[URP][RenderGraph] Added URP postfx passes to URP Render Graph (v5)
thomas-zeng Jun 28, 2022
c5ab2fd
[RPW] Tooltips improvement
kirill-titov-u Jun 28, 2022
0e80090
Add .buginfo files to URP folders
pbbastian Jun 28, 2022
043969f
[HDRP] Always use diffusion profiles in previews
adrien-de-tocqueville Jun 28, 2022
9ae0537
[RPW] Allow shader from HDRP and URP correctly fallback to error shader
kirill-titov-u Jun 28, 2022
ba30079
A error is thrown when creating an Output Particle Lit Decal
julienamsellem Jun 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Public Api doc improvements for URP, 2D URP and Core
Initiative: https://jira.unity3d.com/browse/RND-205
JIRA card: https://jira.unity3d.com/browse/URP-1152

Currently URP has a lot of missing documentation for public API, over 600 functions, enums, etc. This PR adds minimal documentation to each of those and allows us to enable the "Find missing docs - urp" job on Yamato, preventing future developers from adding public API without documentation.
  • Loading branch information
ellioman committed Jun 28, 2022
commit 24102a0de3658877fc96bccf2e0f9c48e3db0dbb
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,7 @@ public bool TryGetScreenClearColor(ref Color color)
return false;
}

/// <summary>
/// Creates the panel
/// </summary>
/// <returns>The panel</returns>
/// <inheritdoc/>
public IDebugDisplaySettingsPanelDisposable CreatePanel()
{
return new SettingsPanel(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ public enum ShaderVariantLogLevel
/// <summary>Disable all log for Shader Variant</summary>
[Tooltip("No shader variants are logged")]
Disabled,

/// <summary>Only logs SRP Shaders when logging Shader Variant</summary>
[Tooltip("Only shaders that are compatible with SRPs (e.g., URP, HDRP) are logged")]
OnlySRPShaders,

/// <summary>Logs all Shader Variant</summary>
[Tooltip("All shader variants are logged")]
AllShaders,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,14 @@ namespace UnityEditor.Rendering.Universal
/// <seealso cref="Converters.RunInBatchMode(UnityEditor.Rendering.Universal.ConverterContainerId, List{UnityEditor.Rendering.Universal.ConverterId}, UnityEditor.Rendering.Universal.ConverterFilter)"/>.)
public enum ConverterFilter
{
/// <summary>
/// Use this to include converters matching the filter.
/// </summary>
Inclusive,

/// <summary>
/// Use this to exclude converters matching the filter.
/// </summary>
Exclusive
}

Expand All @@ -21,8 +28,19 @@ public enum ConverterFilter
/// <seealso cref="Converters.RunInBatchMode(UnityEditor.Rendering.Universal.ConverterContainerId)"/>.)
public enum ConverterContainerId
{
/// <summary>
/// Use this for Built-in to URP converter.
/// </summary>
BuiltInToURP,

/// <summary>
/// Use this for Built-in to 2D (URP) converter.
/// </summary>
BuiltInToURP2D,

/// <summary>
/// Use this to upgrade 2D (URP) assets.
/// </summary>
UpgradeURP2DAssets,
}

Expand All @@ -32,14 +50,40 @@ public enum ConverterContainerId
/// <seealso cref="Converters.RunInBatchMode(UnityEditor.Rendering.Universal.ConverterContainerId, List{UnityEditor.Rendering.Universal.ConverterId}, UnityEditor.Rendering.Universal.ConverterFilter)"/>.)
public enum ConverterId
{
/// <summary>
/// Use this for the material converters.
/// </summary>
Material,

/// <summary>
/// Use this for the render settings converters.
/// </summary>
RenderSettings,

/// <summary>
/// Use this for the animation clip converters.
/// </summary>
AnimationClip,

/// <summary>
/// Use this for readonly material converters.
/// </summary>
ReadonlyMaterial,

/// <summary>
/// Use this for post processing V2 converters.
/// </summary>
PPv2,

/// <summary>
/// Use this for parametric to freeform light converters.
/// </summary>
ParametricToFreeformLight,
}

/// <summary>
/// Class for the converter framework.
/// </summary>
public static class Converters
{
static Type GetContainerType(ConverterContainerId containerName)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

namespace UnityEditor
{
/// <summary>
/// Editor script for the Lighting Explorer.
/// </summary>
[LightingExplorerExtensionAttribute(typeof(UniversalRenderPipelineAsset))]
public class LightExplorer : DefaultLightingExplorerExtension
{
Expand Down Expand Up @@ -33,6 +36,7 @@ private static class Styles
public static readonly int[] ReflectionProbeSizeValues = { 16, 32, 64, 128, 256, 512, 1024, 2048 };
}

/// <inheritdoc />
protected override LightingExplorerTableColumn[] GetReflectionProbeColumns()
{
return new[]
Expand Down
Loading