Fix up SYS_gettid usage on macOS for jitdump #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // effective uid/gid a thread is operating under) | ||
| // There is pthread_threadid_np(), but it returns a uint64_t. | ||
| // Given that we need a uint32_t, just return 0 here for now. | ||
| return 0; |
There was a problem hiding this comment.
I think this actually needs to use pthread_threadid_np for correctness - perhaps upstream needs long for tid record
There was a problem hiding this comment.
It can't -- this field is part of the jitdump binary specification. From reading some other source, pthread_threadid_np is uint64, but in practice it's actually always the size of a pid_t. However for this use I really don't think it matters. All this ends up recording is what thread generated the jit code; not very useful info IMO.
alexey-zakharov
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while creating upstream patch (which aborts during build because syscall() is deprecated in the newer SDKs). Turns out macOS
SYS_gettidis completely unrelated to linux gettid (it returns effective uid/gid a thread is operating under). There is pthread_threadid_np(), but it returns a uint64_t and we need a uint32_t. This just sets thetidto 0. Profilers care about the thread ID anyway.