Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps - Upgrade to Emotion v11 (from v10) [BREAKING CHANGES] #247

Merged
merged 10 commits into from
Jan 11, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Jan 11, 2021

See https://emotion.sh/docs/emotion-11

Changes

Breaking changes with useTheme due to Emotion TS changes

  • Before: const customerTheme = useTheme<CustomerTheme>();
  • After: const customerTheme = useTheme();, useTheme doesn't support dynamic type anymore, as it's now handled for the whole app in src/types/emotion-theme.ts instead.

Status

All blocking issues have been fixed, ready for merge. Works locally and on Vercel.

Issues

Both issues were related to webpack/babel configuration and were solved thanks to Andarist

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 7323339 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-n8tic8uj6.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-update-emot.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 914996e successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-r3mj5u31t.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-update-emot.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 914996e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-r3mj5u31t.vercel.app
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 914996e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-r3mj5u31t.vercel.app

@github-actions
Copy link

❌  Deployment FAILED
Commit a6a0aff failed to deploy to
click to see logs

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 210da53 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-4fo1vx0jw.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-update-emot.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 210da53 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4fo1vx0jw.vercel.app
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 210da53 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4fo1vx0jw.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 797b66a successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-3a8og8kyo.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-update-emot.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 797b66a previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-3a8og8kyo.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit a103326 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-p970ki06e.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-update-emot.vercel.app

@Vadorequest Vadorequest changed the title Deps - Upgrade Emotion Deps - Upgrade to Emotion v11 (from v10) [BREAKING CHANGES] Jan 11, 2021
@github-actions
Copy link

✅  E2E tests SUCCESS for commit a103326 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-p970ki06e.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant