feat: leverage logger to hide sensitive data in ingest logs #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. I noticed it left null for the Unstructured api_key when it was missing and then masked it when it was there. Thats great. |
|
This is working well and masks all the things that I was finding. |
rbiseck3
force-pushed
the
roman/hide-sensitive-data-ingest-logs-2
branch
from
18d63fc
to
fceb7c0
Compare
rbiseck3
force-pushed
the
roman/hide-sensitive-data-ingest-logs-2
branch
from
4f036c1
to
883a87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the logger being used by ingest to leverage a new class implemented inheriting
logging.Formatterwhich adds in some middleware to update the message being logged to omit any sensitive content. It does this by dynamically pulled out any valid json from the string being logged and runs that through ahide_sensitive_fieldsmethod which updated any values that are considered sensitive. Replaces the original json strings with thejson.dumpsversion of the new dictionary.