Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ppt parameters include_page_breaks and include_slide_notes #2996

Merged
merged 6 commits into from
May 10, 2024

Conversation

Coniferish
Copy link
Collaborator

@Coniferish Coniferish commented May 9, 2024

Pass the parameters include_slide_notes and include_page_breaks to partition_pptx from partition_ppt.

Also update the .ppt example doc we use for testing so it has slide notes and a PageBreak (and second page)

Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@scanny scanny added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2024
@Coniferish Coniferish added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 593aa47 May 10, 2024
42 checks passed
@Coniferish Coniferish deleted the jj/ppt branch May 10, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants