Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role fact_workspace_info: refactor desktop fact? #147

Closed
dometto opened this issue Jun 18, 2024 · 1 comment
Closed

Role fact_workspace_info: refactor desktop fact? #147

dometto opened this issue Jun 18, 2024 · 1 comment

Comments

@dometto
Copy link
Member

dometto commented Jun 18, 2024

The fact_workspace_info role currently uses a call to the package_facts module to determine installed packages on the system, in order to then determine if the workspace has a desktop environment.

packages_facts allows us to check for packages on the system with something like 'bla' in ansible_facts.packages. This is cleaner and more generic than using the command module to check for an installed package and registering the result, but it also looks significantly slower (on a podman container it takes about 3-5 seconds). Not terribly long, but if it's repeated for a number of components it might add up to have a minute deploy time just to check for package installations.

On the other hand, it could be efficient if many packages need to be checked.

Need to determine whether to keep things as is, or refactor with a command call.

@dometto
Copy link
Member Author

dometto commented Jun 26, 2024

Resolved in #155

@dometto dometto closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant