fix(review): mv getExpandedAriaLabel to getIconLabel

VKCOM · Dec 5, 2023 · 9f9ec08 · 9f9ec08
1 parent 4965258
commit 9f9ec08
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/vkui/src/components/ChipsSelect/ChipsSelect.tsx b/packages/vkui/src/components/ChipsSelect/ChipsSelect.tsx
@@ -28,7 +28,7 @@ import {
   DEFAULT_SELECTED_BEHAVIOR,
   FOCUS_ACTION_NEXT,
   FOCUS_ACTION_PREV,
-  getExpandedAriaLabelDefault,
+  getIconLabelDefault,
   isCreateNewOptionPreset,
   isEmptyOptionPreset,
   isNotServicePreset,
@@ -72,7 +72,10 @@ export interface ChipsSelectProps<O extends ChipOption>
    * Иконка раскрывающегося списка
    */
   icon?: React.ReactNode;
-  getExpandedAriaLabel?(opened: boolean): string;
+  /**
+   * Функция должна возвращать человекочитаемый текст для открытого/закрытого состояния dropdown'а.
+   */
+  getIconLabel?(opened: boolean): string;
   /**
    * Добавляет значение в список на событие `onBlur` (использовать вместе с `creatable`)
    */
@@ -99,7 +102,7 @@ export const ChipsSelect = <Option extends ChipOption>({
   status = 'default',
   before,
   icon,
-  getExpandedAriaLabel = getExpandedAriaLabelDefault,
+  getIconLabel = getIconLabelDefault,
   onChangeStart,
 
   // CustomSelectDropdownProps
@@ -387,7 +390,7 @@ export const ChipsSelect = <Option extends ChipOption>({
             className={styles['ChipsSelect__dropdown']}
             activeMode=""
             hoverMode=""
-            label={getExpandedAriaLabel(opened)}
+            label={getIconLabel(opened)}
             onClick={toggleOpened}
           >
             {icon ?? <DropdownIcon className={styles['ChipsSelect__icon']} opened={opened} />}

diff --git a/packages/vkui/src/components/ChipsSelect/constants.tsx b/packages/vkui/src/components/ChipsSelect/constants.tsx
@@ -19,7 +19,7 @@ export const FOCUS_ACTION_NEXT: FocusActionType = 'next';
 
 export const FOCUS_ACTION_PREV: FocusActionType = 'prev';
 
-export const getExpandedAriaLabelDefault = (opened: boolean) => (opened ? 'Скрыть' : 'Развернуть');
+export const getIconLabelDefault = (opened: boolean) => (opened ? 'Скрыть' : 'Развернуть');
 
 export const renderOptionDefault = (props: CustomSelectOptionProps) => (
   <CustomSelectOption {...props} />