fix(ChipsSelect/CustomSelect): Change key back to option.value #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 914ed52 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7276 +/- ##
==========================================
- Coverage 84.08% 84.08% -0.01%
==========================================
Files 363 362 -1
Lines 10985 11026 +41
Branches 3629 3634 +5
==========================================
+ Hits 9237 9271 +34
- Misses 1748 1755 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
approved these changes
Jul 31, 2024
BlackySoul
approved these changes
Aug 1, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Aug 1, 2024
…#7276) В момент когда делали ChipsSelect стабильным (#6206), мы поменяли key на использование option.label вместо option.value. Это не совсем правильно, так как текстовое представление label может совпадать, в то время как value должно быть уникальным. Поменял key в ChipsInput при рендере Chips и в ChipsSelect при рендере options. Обновил key в CustomSelect для единообразия по аналогии с ChipsSelect.
| ✅ v6.4.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В момент когда делали ChipsSelect стабильным (#6206), мы поменяли key на использование
option.labelвместоoption.value. Это не совсем правильно, так как текстовое представлениеlabelможет совпадать, в то время какvalueдолжно быть уникальным.Пример с воспроизведением: https://codesandbox.io/p/sandbox/muddy-water-4jxc78?file=/src/App.tsx:13,1
Изменения
Поменял key в
ChipsInputпри рендереChipsи вChipsSelectпри рендере options.Обновил key в
CustomSelectдля единообразия по аналогии с ChipsSelect.