Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include UnistallCompletionFilesCommand #72

Merged
merged 37 commits into from
May 18, 2023
Merged

feat: include UnistallCompletionFilesCommand #72

merged 37 commits into from
May 18, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented May 17, 2023 •
edited
Loading

Status

READY

Description

  • Adds UnistallCompletionFilesCommand to uninstall the command.

Builds on #70

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago
refactor: added ScriptConfigurationEntry
12eb748
@alestiago
refactor: remove empty space
000aa81
@alestiago
refactor: use completion installation to verify installation
ac0a310
@alestiago
refactor: removing unused code
4421964
@alestiago
feat: reformatted start and end comments
8e6939c
@alestiago
refactor: used barrel file
3397c16
@alestiago
test: refactor expectation
6d37050
@alestiago
test: remove white space
c9cca0a
@alestiago
Merge branch 'main' into refactor/script-configuration-entry
ba6eaaf
@alestiago
feat: fixed merge issue
ac810c3
@alestiago
test: removed extra space
98f4cf0
@alestiago
feat: uninstall logic
ccf8de3
@alestiago
Merge branch 'main' into refactor/uninstallation-logic
111892c
@alestiago
test: removeFrom
fd16cfa
@alestiago
fix: added break condition
2b19a14
@alestiago
refactor: used while instead of do while
817ae1b
@alestiago
feat: refined removedFrom
c87eb66
@alestiago
feat: refined uninstall logic
b571c14
@alestiago
feat: tested and configured uninstalling behaviour
e8335c9
@alestiago
test: included missing executable script deletion
c327c2c
@alestiago
feat: refined uninstallation logic
bfccc39
@alestiago
feat: improved uninstall behaviour for multiple shells
11b990e
@alestiago
test: added CompletionUnistallationException
b2db32a
@alestiago
docs: improved uninstall documentation
ac3a066
@alestiago
test: improved names
55ee7ec
@alestiago
refactor: renamed executablName to rootCommand
e249a97
@alestiago
refactor: made shouldDelete false by default
96b2796
@alestiago
docs: fixed wrong documentation
db0b752
@alestiago
test: renamed file
cba7174
@alestiago
test: include _test in test name
0736ca5
@alestiago alestiago self-assigned this May 17, 2023
renancaraujo
renancaraujo previously approved these changes May 17, 2023
View reviewed changes
Base automatically changed from refactor/uninstallation-logic to main May 17, 2023 14:39
@renancaraujo renancaraujo self-requested a review May 18, 2023 10:27
@alestiago alestiago merged commit 7675b26 into main May 18, 2023
@alestiago alestiago deleted the feat/uninstall-command branch May 18, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alestiago @renancaraujo