Only include url_helpers in Preview class when they are defined #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we encounter the following error when running `bundle exec rake docs:build`: ``` Converting YARD documentation to Markdown files. rake aborted! NoMethodError: undefined method `routes' for nil:NilClass /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:7:in `<class:Preview>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:6:in `<module:ViewComponent>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:5:in `<top (required)>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/base.rb:11:in `require' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/base.rb:11:in `<top (required)>' /Users/rmacklin/src/github.com/ViewComponent/view_component/Rakefile:81:in `require' /Users/rmacklin/src/github.com/ViewComponent/view_component/Rakefile:81:in `block (2 levels) in <top (required)>' /Users/rmacklin/.asdf/installs/ruby/2.7.5/bin/bundle:23:in `load' /Users/rmacklin/.asdf/installs/ruby/2.7.5/bin/bundle:23:in `<main>' Tasks: TOP => docs:build (See full trace by running task with --trace) ```
rmacklin
force-pushed
the
only-include-route-helpers-when-they-are-defined
branch
from
21c98b3
to
40fd68a
Compare
joelhawksley
approved these changes
Jul 8, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…Component#1795) Without this, we encounter the following error when running `bundle exec rake docs:build`: ``` Converting YARD documentation to Markdown files. rake aborted! NoMethodError: undefined method `routes' for nil:NilClass /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:7:in `<class:Preview>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:6:in `<module:ViewComponent>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:5:in `<top (required)>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/base.rb:11:in `require' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/base.rb:11:in `<top (required)>' /Users/rmacklin/src/github.com/ViewComponent/view_component/Rakefile:81:in `require' /Users/rmacklin/src/github.com/ViewComponent/view_component/Rakefile:81:in `block (2 levels) in <top (required)>' /Users/rmacklin/.asdf/installs/ruby/2.7.5/bin/bundle:23:in `load' /Users/rmacklin/.asdf/installs/ruby/2.7.5/bin/bundle:23:in `<main>' Tasks: TOP => docs:build (See full trace by running task with --trace) ```
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…Component#1795) Without this, we encounter the following error when running `bundle exec rake docs:build`: ``` Converting YARD documentation to Markdown files. rake aborted! NoMethodError: undefined method `routes' for nil:NilClass /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:7:in `<class:Preview>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:6:in `<module:ViewComponent>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/preview.rb:5:in `<top (required)>' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/base.rb:11:in `require' /Users/rmacklin/src/github.com/ViewComponent/view_component/lib/view_component/base.rb:11:in `<top (required)>' /Users/rmacklin/src/github.com/ViewComponent/view_component/Rakefile:81:in `require' /Users/rmacklin/src/github.com/ViewComponent/view_component/Rakefile:81:in `block (2 levels) in <top (required)>' /Users/rmacklin/.asdf/installs/ruby/2.7.5/bin/bundle:23:in `load' /Users/rmacklin/.asdf/installs/ruby/2.7.5/bin/bundle:23:in `<main>' Tasks: TOP => docs:build (See full trace by running task with --trace) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Addresses #1765 (comment)
Without this, we encounter the following error when running
bundle exec rake docs:build: