Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tests for truth table generator. #3

Merged
merged 5 commits into from
Feb 25, 2023
Merged

added tests for truth table generator. #3

merged 5 commits into from
Feb 25, 2023

Conversation

ravikamath123
Copy link
Contributor

added test cases for

  • basic operations
    • or
    • and
    • not
    • xor
    • conditional
    • bi conditional
  • complex case
    • (a + ~b) -> b
    • a + ( b * c )

Vipul-Cariappa
Vipul-Cariappa reviewed Feb 23, 2023
View reviewed changes
Copy link
Owner

@Vipul-Cariappa Vipul-Cariappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the necessary changes

tests/test_logic.py Outdated Show resolved Hide resolved
tests/test_logic.py Outdated Show resolved Hide resolved
tests/test_logic.py Outdated Show resolved Hide resolved
@Vipul-Cariappa
Copy link
Owner

Vipul-Cariappa commented Feb 23, 2023 •
edited
Loading

The test_combinations is testing for 3 variable equation only. Please write test cases for 1, 2, 4 and 5 variable equations also.
Also test some complex 4 and 5 variable equations (1 each is sufficient).
Everything else looks great. 👍

@Vipul-Cariappa
Copy link
Owner

Everything looks great 👍.
Please verify the changes I have asked for. Once done I will merge it.

@ravikamath123
Copy link
Contributor Author

I have verified and done the necessary changes.

@Vipul-Cariappa Vipul-Cariappa merged commit aabc03c into Vipul-Cariappa:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vipul-Cariappa Vipul-Cariappa Vipul-Cariappa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ravikamath123 @Vipul-Cariappa