Enable warnings

Vipul-Cariappa · Aug 25, 2020 · 4202b7f · 4202b7f
1 parent 038878f
commit 4202b7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -70,7 +70,7 @@ cxx_binary:
     - cd lfortran-${lfortran_version}
     - cmake
          -DCMAKE_BUILD_TYPE=Release
-         -DCMAKE_CXX_FLAGS_RELEASE="-Wall -Wextra -Wno-unused-parameter -fno-common -O3 -march=nehalem -funroll-loops -DNDEBUG"
+         -DCMAKE_CXX_FLAGS_RELEASE="-Wall -Wextra -O3 -march=nehalem -funroll-loops -DNDEBUG"
          -DWITH_LLVM=yes
          -DLFORTRAN_STATIC_BIN=yes
          .

diff --git a/cmake/UserOverride.cmake b/cmake/UserOverride.cmake
@@ -8,17 +8,17 @@
 
 if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     # g++
-    set(common "-Wall -Wextra -Wno-unused-parameter -fno-common")
+    set(common "-Wall -Wextra")
     set(CMAKE_CXX_FLAGS_RELEASE_INIT "${common} -O3 -march=native -funroll-loops -DNDEBUG")
     set(CMAKE_CXX_FLAGS_DEBUG_INIT   "${common} -g -ggdb")
 elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
     # icpc
-    set(common "-Wall -fno-common")
+    set(common "-Wall")
     set(CMAKE_CXX_FLAGS_RELEASE_INIT "${common} -xHOST -O3")
     set(CMAKE_CXX_FLAGS_DEBUG_INIT   "${common} -g -O0")
 elseif (CMAKE_CXX_COMPILER_ID MATCHES Clang)
     # clang
-    set(common "-Wall -Wextra -Wno-unused-parameter")
+    set(common "-Wall -Wextra")
     set(CMAKE_CXX_FLAGS_RELEASE_INIT "${common} -O3 -march=native -funroll-loops -DNDEBUG")
     set(CMAKE_CXX_FLAGS_DEBUG_INIT   "${common} -g -ggdb")
 elseif (CMAKE_CXX_COMPILER_ID STREQUAL "PGI")