Tags: Viyond/learn-go-with-tests
Tags
Added additional context to example changes for the 'it returns acept… …ed on POST' (quii#525) As written it was a bit confusing the exact change that needed to be made, so I dug into the example code to look up where it was to go. The main bit of confusion was the name of the test changed. I've added the rest of the function around the previous code snippet to add additional context
PDF generation fixes (quii#503) * Issue: Automate the gofmt in markdown files using gofmtmd during build Issue Link: quii#353 Modifications: * Modified the build script to download and run the gofmtmd tool on the markdown files * Ran the script locally and fixed the issues reported by gofmtmd tool Note: Intro to generics md file contains some syntax related to generics which is not recognised by the tool. So some valid code fences are not marked as go * Issue: Errors regarding epubcheck Issue Link: quii#420 Solution: * Corrected the SVG syntax by omitting the version tag and dtd info * Minorr markup corrections in md files Test Case: * Ran build books script locally and is able to view the generated epub file * Added newly created epub file to Google Play books and is able to read the book * Issue: PDF generation build fixes Issue link: quii#205 Solution: 1. Created a custom docker image with fonts needed for CJK support and some fonts 2. Updated the build script to use the custom pandoc image Test case: 1. Ran the build script locally and verified that the books generation is successful * Update go.yml to add support to upload assets Made changes to GH actions to add generated epub and PDF to the release once published * Corrected the yaml format * Made changes to add cover page before the toc
Fix for epub rejected by Google Play Books, EPUBCheck (quii#500) * Issue: Automate the gofmt in markdown files using gofmtmd during build Issue Link: quii#353 Modifications: * Modified the build script to download and run the gofmtmd tool on the markdown files * Ran the script locally and fixed the issues reported by gofmtmd tool Note: Intro to generics md file contains some syntax related to generics which is not recognised by the tool. So some valid code fences are not marked as go * Issue: Errors regarding epubcheck Issue Link: quii#420 Solution: * Corrected the SVG syntax by omitting the version tag and dtd info * Minorr markup corrections in md files Test Case: * Ran build books script locally and is able to view the generated epub file * Added newly created epub file to Google Play books and is able to read the book
PreviousNext