Feature small changes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 9, 2023 17:27
there is an if statement to get a variable which is not used or printed, I guess it can be skiped
VladimirMikulic
requested changes
Jan 10, 2023
There was a problem hiding this comment.
Hi @Paker30. I appreciate you submitting the PR.
The two console logs actually create line breaks inside terminal so we do need them.
|
I haven't realize about the breaking lines, thanks for the answer! I've restore the |
added 2 commits
January 10, 2023 12:20
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers two topics:
console.logstatement without message so I guessed they're not neededflatMapwas added into Node at version 11 so it can be used instead ofmap+flat