Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the right initial byte for the top-level 6-element array. #454

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Use the right initial byte for the top-level 6-element array. #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deec7bd
Use the right initial byte for the top-level 6-element array.
jyasskin Jul 10, 2019
07c00e4
Fix the magic number for the new format.
jyasskin Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-yasskin-wpack-bundled-exchanges.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ steps, taking the `stream` as input.
1. Seek to offset 0 in `stream`. Assert: this operation doesn't fail.

1. If reading 10 bytes from `stream` returns an error or doesn't return the
bytes with hex encoding "84 48 F0 9F 8C 90 F0 9F 93 A6" (the CBOR encoding of
the 4-item array initial byte and 8-byte bytestring initial byte, followed by
bytes with hex encoding "86 48 F0 9F 8C 90 F0 9F 93 A6" (the CBOR encoding of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic number in Section 6.1 should be updated as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

the 6-item array initial byte and 8-byte bytestring initial byte, followed by
🌐📦 in UTF-8), return a "format error".

1. Let `version` be the result of reading 5 bytes from `stream`. If this is
Expand Down Expand Up @@ -911,7 +911,7 @@ at <https://www.iana.org/assignments/media-types>.
* Additional information:

* Deprecated alias names for this type: N/A
* Magic number(s): 84 48 F0 9F 8C 90 F0 9F 93 A6
* Magic number(s): 86 48 F0 9F 8C 90 F0 9F 93 A6
* File extension(s): .wbn
* Macintosh file type code(s): N/A

Expand Down