Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Rename integer-to-integer widening instructions to "extend"? #467

Closed
ngzhian opened this issue Feb 12, 2021 · 5 comments · Fixed by #478 or #481
Closed

Rename integer-to-integer widening instructions to "extend"? #467

ngzhian opened this issue Feb 12, 2021 · 5 comments · Fixed by #478 or #481

Comments

@ngzhian
Copy link
Member

ngzhian commented Feb 12, 2021

Referring to this section https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#integer-to-integer-widening, was there a reason why we chose "widen"? That isn't a terminology used in the current Wasm spec, it uses "extend" (e.g. see https://webassembly.github.io/spec/core/appendix/index-instructions.html).

Can we change the names to extend? (Everything else stays the same, only s/widen/extend/.

@tlively
Copy link
Member

tlively commented Feb 16, 2021

SGTM

@zeux
Copy link
Contributor

zeux commented Feb 17, 2021

If we switch from widen to extend, what do we do with narrow? Doesn't look like scalar spec has an equivalent.

@tlively
Copy link
Member

tlively commented Feb 17, 2021

The scalar spec has i32.wrap_i64, but wrap isn't great for the SIMD version because it saturates rather than wrapping :/

@ngzhian
Copy link
Member Author

ngzhian commented Feb 17, 2021

We can keep narrow since there is no equivalent instruction in scalar spec.

@tlively
Copy link
Member

tlively commented Feb 19, 2021

There were no strong objections to this renaming at today's meeting. @ngzhian, do you want to put a PR together?

ngzhian added a commit to ngzhian/simd that referenced this issue Feb 19, 2021
Changes to interpreter will come in a follow-up patch.

Fixed WebAssembly#467.
ngzhian added a commit that referenced this issue Feb 23, 2021
Changes to interpreter will come in a follow-up patch.

Fixed #467.
ngzhian added a commit to ngzhian/wasmparser that referenced this issue Mar 2, 2021
See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.
ngzhian added a commit to ngzhian/wasmparser that referenced this issue Mar 2, 2021
See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.
ngzhian added a commit to ngzhian/wasmparser that referenced this issue Mar 3, 2021
See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.
bmeurer pushed a commit to wasdk/wasmparser that referenced this issue Mar 4, 2021
See WebAssembly/simd#452 for finalized opcodes
and WebAssembly/simd#467 for some renamings.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants