Introduce explicit type for full AST #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | Binary of Kernel.binop * expr * expr | ||
| | Select of Kernel.selop * expr * expr * expr | ||
| | Compare of Kernel.relop * expr * expr | ||
| | Convert of Kernel.cvt * expr |
There was a problem hiding this comment.
Would it be possible to move memop, literal, unop, binop, etc. out of Kernel and into Ast, and have Kernel import then from Ast instead? Since the Ast module is the thing that has the 1-1 correspondence with the design repo, it would be nice to have all the fields described in the design repo here, in one place.
There was a problem hiding this comment.
This dependency will disappear with the flattened AST in the follow-up patch anyway, so is it worth worrying about?
|
lgtm, as a first step with others to follow. |
rossberg
added a commit
that referenced
this pull request
Nov 17, 2015
Introduce explicit type for full AST
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 towards explicitly representing full operator syntax as given in AstSemantics.
This mainly renames some modules and introduces a new type for the full AST, currently copying the structure of the kernel one. It does not yet flatten it into individual opcodes -- I split that into a follow-up patch, since it involves massive changes to lexer and parser.