Implement globals #313
Merged
Implement globals #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping :) |
|
lgtm |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
This is sufficient to pass simd_load.wast and simd_store.wast. There are some extra instructions, like swizzle and i8x16.shl that is implemented here, because simd_load.wast uses them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements global declarations as of WebAssembly/design#682. Still missing: mutability, import/export.
Also, binary opcodes currently don't match WebAssembly/design#727, due to conflicts with WebAssembly/design#711.