Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library version #21

Closed
carlosgcampos opened this issue Jul 10, 2018 · 1 comment
Closed

Library version #21

carlosgcampos opened this issue Jul 10, 2018 · 1 comment
Assignees
@aperezdc
Labels
bug enhancement
Milestone
Version 1.0.0

Comments

@carlosgcampos
Copy link
Contributor

I've noticed that we are using the project version as the library version. We shouldn't do that, because they mean different things. We should use the libtool convention for the library version, see http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
@aperezdc aperezdc mentioned this issue Jul 11, 2018
Closed
@aperezdc
Copy link
Contributor

aperezdc commented Jul 12, 2018 •
edited
Loading

Right, we should be careful with this kind of thing. Probably the best is to import the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() macro from the WebKit sources and use that.

If nobody is against, I will do that, and cut a new release 0.2.1 tomorrow.

Edit: @carlosgcampos pointed out in a chat that we may as well wait for the next ABI break to change to the library version to use the libtool convention.

@aperezdc aperezdc added this to the Version 1.0.0 milestone Jul 25, 2018
aperezdc added a commit that referenced this issue Aug 19, 2018
@aperezdc
Use the libtool versioning scheme for libWPEBackend
6a8e886 
This is needed in preparation for the 1.0.0 release.

VersioningUtils.cmake is imported from the WebKit source tree:
https://trac.webkit.org/browser/webkit/trunk/Source/cmake/VersioningUtils.cmake

Fixes #21
@aperezdc aperezdc mentioned this issue Aug 19, 2018
Merged
aperezdc added a commit that referenced this issue Aug 20, 2018
@aperezdc
Use the libtool versioning scheme for libWPEBackend
ce40c39 
This is needed in preparation for the 1.0.0 release.

VersioningUtils.cmake is imported from the WebKit source tree:
https://trac.webkit.org/browser/webkit/trunk/Source/cmake/VersioningUtils.cmake

Fixes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aperezdc aperezdc

Labels
bug enhancement
Milestone
Version 1.0.0
Development

No branches or pull requests
2 participants
@aperezdc @carlosgcampos