Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming #27

Closed
mcatanzaro opened this issue Aug 19, 2018 · 3 comments
Closed

Consider renaming #27

mcatanzaro opened this issue Aug 19, 2018 · 3 comments
Assignees
Milestone

Comments

@mcatanzaro
Copy link
Contributor

The name WPEBackend is problematic because it sounds like a backend, not a dependency of the actual backends. Even people who would be expected to have some experience with WPE fail to understand this, and that's reasonable since you would certainly expect it to be a backend.

I think we've discussed this in the past and decided to keep the name, but it's a bad name and should be corrected before the damage becomes too great. E.g. we have a Fedora package now wpebackend, but it's new: changing the package name now would be less problematic than waiting a couple years and then changing it.

@aperezdc aperezdc self-assigned this Aug 19, 2018
@aperezdc aperezdc added this to the Version 1.0.0 milestone Aug 19, 2018
@aperezdc
Copy link
Contributor

aperezdc commented Aug 19, 2018

If we are going to do this, I would do it before v1.0.0 which we should be releasing soon. We would need a name and also I would like approvals by @zdobersek and @carlosgcampos (at least) before proceeding.

Do you have any suggestion for the name? I would rather go with something which describes what the library does, for example it could be WPEInterface, because it interfaces between WPE WebKit and backends.

@mcatanzaro
Copy link
Contributor Author

WPEInterface, WPEBackendInterface, libwpe... I'm not picky.

@aperezdc
Copy link
Contributor

Now that I think of it, using libwpe would nicely match the name of the .pc file, because it has always been a bit awkward to me that the library is named differently.

My suggestion is therefore to use wpe-${APIVER}.pclibwpe-${APIVER}.so*

@carlosgcampos @zdobersek: WDYT?

aperezdc added a commit that referenced this issue Aug 20, 2018
This library does not actually implement any backend for WPE, and
therefore its name can be misleading. Instead, it contains the code
needed by WebKit to interface with actual backend implementations,
loading them, and some utility code. The libwpe name is much more
fitting.

This is a good moment to do this rename, because the API version will
be bumped for release 1.0.0 as well: packagers and users of the library
will need to update anyway for the API version change and rebuild
software which uses libWPEBackend^W libwpe anyway.

Fixes #27
aperezdc added a commit that referenced this issue Aug 20, 2018
This library does not actually implement any backend for WPE, and
therefore its name can be misleading. Instead, it contains the code
needed by WebKit to interface with actual backend implementations,
loading them, and some utility code. The libwpe name is much more
fitting.

This is a good moment to do this rename, because the API version will
be bumped for release 1.0.0 as well: packagers and users of the library
will need to update anyway for the API version change and rebuild
software which uses libWPEBackend^W libwpe anyway.

Fixes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants